GitLab

GIT_SILENT

GIT_SILENT

GIT_SILENT

All the network-related classes are still without replacement,
and used at least by Ksirk & KFourinline.

This reverts commit 8d23afef.

kapidox/ecmaddqch know about Q_DECLARE_FLAGS macro

GIT_SILENT

Conflicting overloads are part of hidden deprecated API

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

Friedrich W. H. Kossebau authored Jun 14, 2022 and Albert Astals Cid committed Jun 14, 2022

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Some KDE Games allow to switch between different themes. The theme
selector shows previews, based on pixmaps which are scaled down to fit
within the available UI space. By default `Qt::FastTransformation` is
used within `KgThemeSelector`, however this can result in subpar image
quality, even for non-HiDPI use cases.

Changing the scaling method to `Qt::SmoothTransformation` improves the
look of the previews. Since `generatePreview` is not exactly a hot code
path, performance implications of the change should not be an issue.

Note: The similar class `KGameThemeSelector` is already using
`Qt::SmoothTransformation` for its previews.

Test Plan:

Open KPatience, "Settings -> Change Appearance -> Game Theme" now shows
less blocky previews.

A couple of KDE games allow to choose between different themes via their
settings menu. While HiDPI-rendering of the theme itself is SVG based
and already fixed in at least some of the games, the theme selection
dialog still only showed a pixelated preview. Note that only games using
`KGameThemeSelector` are affected (e.g. KBlocks, KSudoku), as games
relying on `KgThemeSelector` (e.g. KPatience, KMines) where already
fixed in 6047bc31.

Even if the preview is based on a static PNG image, by setting the
proper `devicePixelRatio` for the pixmap the image quality of the
preview can be considerably improved already.

Test Plan:

Launch `QT_SCALE_FACTOR=1.4 kblocks`, "Settings -> Theme -> Preview"
should not be pixelated anymore.

When running a game in HiDPI mode, the icon within the popup message
would not be vertically centered anymore, and the distance between icon
and text would be too large.

This is caused by the message itself getting too large, due to
calculations using the dimensions of the icon's pixmap in device pixels.

By converting the icon pixmap size to device independent pixels, the
popup message is correctly sized again, leading to correct alignment of
icon and text as well.

Test Plan:

Launch `QT_SCALE_FACTOR=2.4 kblocks`, check centered alignment of icon
and text in popup messages after startup and when pausing/resuming.

Popup messages do not scale in size along with the canvas fitting into
its viewport, to keep the text readable regardless of screen size. Still
their distance to the canvas border (`SHOW_OFFSET`) would change when
resizing the game window.

This is due to the offset being specified in screen pixels, while
calculations the offset is used in are expecting scene coordinates.

Conversion via `mapToScene` will make the offset constant. The offset
itself is also increased to a more pleasing distance (the old offset
changed depending on window size, therefore it is hard to judge what the
original intention was).

Note that dimensions are given in device independent pixels, so
the offset scales up automatically for HiDPI use cases.

Test Plan:

Start a new game in KBlocks and resize the window. The message when
pausing the game should have the same offset from the window border as
the welcome message, and the offset should be visually matching the
popup's inner margin.

`KGamePopupItem` can be used to show popup messages overlayed over the
game's canvas, appearing as specified in one of the four corners or in
the center. While this worked fine for `Position::TopLeft`, positioning
for the other locations could be wrong, e.g. too far off from the right
border, cut off, or not perfectly centered. In particular positioning
relative to the edges of the canvas also incorrectly depended on canvas
size and aspect ratio, while the popup message should always be placed
adjacent to the respective edges of the canvas.

This is because dimensions in physical/screen pixels are used in
calculations to determine the position, while drawing is tied to scene
coordinates, which can have different scaling depending on how the
canvas has been scaled to fit within the viewport.

By properly mapping on-screen dimensions of the popup message to scene
coordinates via `mapToScene`, popup messages show up in their correct
locations again. Note that popup messages are not supposed to scale
along with the rest of the game content, to keep them readable
regardless of screen size.

This patch is also required to be able to properly test later HiDPI fixes.

Test Plan:

In KBlocks, change `KBlocksScene::showMessage` to use `TopLeft`,
`TopRight`, `BottomLeft`, `BottomRight` and `Center`. Starting a new
game and pausing/resuming now shows popup messages which are not
cut off, properly adjacent to the canvas border, and perfectly centered.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

kgame includes kcoreaddons_export.h, so we need to link the target

Lets cmake know about the version and allows to automatically add
new versions to bugzilla.

By not saving the original file name and timestamp when running gz

oldherl oh authored Jan 17, 2022 and Albert Astals Cid committed Jan 17, 2022

This is a step towards fixing KDE BUG: 448364 and BUG: 276970.