Commit 16dcd2b9 authored by Friedrich W. H. Kossebau's avatar Friedrich W. H. Kossebau
Browse files

Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

Nested classes inherit the visibility of their outer class,
so all the KClass::Private symbols have also been exported
if the ones of KClass were.
parent f55ff0b6
......@@ -25,7 +25,7 @@
#include "kgopenalruntime_p.h"
#include "virtualfileqt-openal.h"
class KgSound::Private
class Q_DECL_HIDDEN KgSound::Private
{
public:
KgSound::PlaybackType m_type;
......
......@@ -42,7 +42,7 @@
Q_LOGGING_CATEGORY(GAMES_HIGHSCORE, "org.kde.games.highscore", QtWarningMsg)
class KHighscore::KHighscorePrivate
class Q_DECL_HIDDEN KHighscore::KHighscorePrivate
{
public:
KHighscorePrivate() {}
......
......@@ -51,7 +51,7 @@ this software.
typedef QList<KScoreDialog::FieldInfo> GroupScores; ///<The list of scores in a group
class KScoreDialog::KScoreDialogPrivate
class Q_DECL_HIDDEN KScoreDialog::KScoreDialogPrivate
{
public:
//QList<FieldInfo*> scores;
......
......@@ -40,7 +40,7 @@
//BEGIN KgDifficultyLevel
class KgDifficultyLevel::Private
class Q_DECL_HIDDEN KgDifficultyLevel::Private
{
public:
bool m_isDefault;
......@@ -145,7 +145,7 @@ KgDifficultyLevel::StandardLevel KgDifficultyLevel::standardLevel() const
//END KgDifficultyLevel
//BEGIN KgDifficulty
class KgDifficulty::Private
class Q_DECL_HIDDEN KgDifficulty::Private
{
public:
QList<const KgDifficultyLevel*> m_levels;
......
......@@ -27,7 +27,7 @@
Q_LOGGING_CATEGORY(GAMES_LIB, "org.kde.games.lib", QtWarningMsg)
class KgTheme::Private
class Q_DECL_HIDDEN KgTheme::Private
{
public:
const QByteArray m_identifier;
......
......@@ -27,7 +27,7 @@
#include <KConfigGroup>
#include <KSharedConfig>
class KgThemeProvider::Private
class Q_DECL_HIDDEN KgThemeProvider::Private
{
public:
KgThemeProvider *q;
......
......@@ -44,7 +44,7 @@ namespace Metrics
//BEGIN KgThemeSelector
class KgThemeSelector::Private
class Q_DECL_HIDDEN KgThemeSelector::Private
{
public:
KgThemeSelector* q;
......
......@@ -24,7 +24,7 @@
#include "kplayer.h"
#include "kgame.h"
class KGameSequence::KGameSequencePrivate
class Q_DECL_HIDDEN KGameSequence::KGameSequencePrivate
{
public:
KGameSequencePrivate()
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment