GitLab

(cherry picked from commit 99c4ef6a)

Loading plugins via KServiceTypeTrader is deprecated. Instead the
plugins should embed their metadata, be installed in a well-known
subdirectory of the plugin dir and loaded via
KPluginLoader/KPluginMetaData.

Any existing out-of-tree plugin would need to be adapted, otherwise it
will not be loaded. The adjustment is easy however and I doubt there are
actually any out-of-tree plugins.

(cherry picked from commit ada384e1)

This may well be a Qt bug, but without this, when moving pieces into a
holder, it often does not disappear from its current position.

Previously this could potentially call fdatasync once per puzzle, which
was pretty bad for loading times. That was exacerbated by the previous
date comparison bug that caused the config to be regenerated at every
start.

My guess would be that this was an optimization for very slow load times,
which I've also seen.  But the reason for these are repeated fdatasync
calls which are completely unnecessary. By removing the threading, we can
actually more easily optimize this in a followup patch.

This is probably not a complete removal of all the threading-related cruft.
I suspected a number of mutexes are no longer necessary now, but that can
be left for later.

There were two problems here: the QDateTime comparisons didn't return
true for files with unchanged mtime.  Using the same conversion on both
sides of the comparison fixes that.  As a result, startup now becomes
much faster since we're not rebuilding the cache each time.  Since
the format of the date has changed on-disk, this should be backwards
compatible, causing a one-time rebuild.

That exposed another problem that I was half-observing already before,
which is that the PNG thumbnails weren't being restored properly.
Converting the raw data to base64 when saving fixes that as well.

This seems to solve a crash that sometimes occured when using piece holders.
One of the symptoms was that when trying to call removeAll on one of the
pieces to be removed, the return value from removeAll was zero, indicating that
no piece was removed from the list - so it must have been in a different list.
The code for merging pieces seems to have been unaware of the existence of
multiple scenes.

(cherry picked from commit 15f4fbd8)

(cherry picked from commit 6e0fd219)

The whole concept is almost unused and there's no point in having it there but empty

See also https://phabricator.kde.org/T13553

(cherry picked from commit d9321b6e)

(cherry picked from commit 294e0c45)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

(cherry picked from commit 677fbebd)

They do not belong to an user-facing documentation, but rather to
separate download/build development pages.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

(cherry picked from commit 0901406f)

(cherry picked from commit 1817f22e)

Summary: When using fractional scaling, icons on the top are blurred. This patch fixes the issue.

Test Plan: No side effects.

Reviewers: #kde_games, yurchor

Reviewed By: yurchor

Subscribers: yurchor, kde-games-devel

Differential Revision: https://phabricator.kde.org/D29659