GitLab

BUG:410463

The assert is already fixed in my other commits, so the workaround
is not needed anymore. Moreover it causes a hangup if the user presses
Delete key right in the middle of the brush stroke :(

This reverts commit 07167cd2.

This commit constrains the position of each assistant editor widget
within the bounds of the viewport, allowing the user to manipulate
assistants that would typically be off-screen (for example: a distant
and subtle vanishing point).

The tooltip referred to the ‘Uniform Scaling’ checkbox, but
the actual checkbox is called ‘Scale Styles’. This is now fixed.
Also made some other minor improvements to the tooltip text.

It may be triggered when opening the very first document in Krita

BACKPORT:krita/4.2

The label was ‘Move right’, which is a different action.

When switching canvases (creating new ones), it might happen that the
tool proxy will be switched right in the middle of the stroke. In
such a case we should deactivate/finish the action of the *old* canvas,
not the new one.

BUG:398968

It is not used anymore

The info that is activated with a special compile-time switch must
never be moved into categorized debug log. It just wastes developer's
time.

Opening a waiting dialog may make the shortcuts matcher unhappy,
so we should avoid that.

CCBUG:409968,408826,409275

Some tools, e.g. text tool, may open a dialog right inside
beginPrimaryAction() callback. It may make KisShortcutMatcher crazy,
because all the modal dialogs have hey own event loop, therefore
the state machine of the shortcuts matcher will be broken.

This patch makes the matcher a bit more tolerant to such faults. It
just manually checks if it is entered more that once, and resets the
action in case a recursion is detected.

BUG:409968
CCBUG:408826,409275

Now all initialization of the transform tool has been moved into the
stroke's context. It means that the tool doesn't need to block event
loop until it image is finished anymore.

The fix uses he new features of the strokes framework, specifically
mutated stroke jobs.

CCBUG:409275

Calling blockUntilOperationsFinished() from tool event handler makes
KisShortcutMatcher to be entered recursively. It basically breaks events
flow and makes KisShortcutMatcher crazy.

I tried to move blocking into the shortcuts matcher itself (so that
it could treat recursive entrance correctly), but it doesn't handle
special cases like KisToolTransform::activate(), which should also
block (if we keep them blocking).

CCBUG:409275

The label for the ‘number of raindrops’ input field just said,
‘Number’. But the string ‘Number’ is also used, with a different
meaning, in the metadata editor, making it difficult to provide
a translation that worked for both strings. The raindrop label
has therefore been changed to ‘Number of drops’, which is also
easier to understand.

In the filter menu, the filter was called ‘Random Noise’,
but in the filter dialogue, it was called just ‘Noise’.
Now it’s ‘Random Noise’ in both places.

In the filter menu, the ‘Enhance’ submenu came before the ‘Emboss’
submenu, but in the filter dialogue, the order was reversed.
Now the order is consistent (and alphabetical in the English UI).

Filters that have names ending with ‘...’ now always open a dialogue,
and filters that have names not ending with ‘...’, don’t.

Use KIS_ASSERT instead of KIS_SAFE_ASSERT in
KisDocument::slotChildCompletedSavingInBackground. When any of these
conditions triggers, it means that something is really wrong and the
saved file may be corrupt. On systems with safe asserts hidden (e.g.
Windows), there is no feedback to the user that something bad happened
(apart from the fact that the document is still modified after save).

Adds unlocking of savingMutex to assert recover branches in
KisDocument::slotChildCompletedSavingInBackground.

Fixes a race condition in the saving process, which is caused by
processing user input events in multiple places during save.

BUG: 409395

Do not close Krita while KisMainWindow has the savingEntryMutex locked
(while the background saving process is being initiated). After the
background saving job is initiated, KisDocument blocks closing while it
saves itself.

CCBUG: 409395

Maniphest: T10784

Maniphest: T10784

The problem is caused by execution flow entering KisShortcutsMatcher
recursively because of doing QApplication::processEvent in the tool's
event hander.

CCBUG:408826
BACKPORT:krita/4.2

Adds a ‘msgctxt’ for the ‘Spot’ autofocus metering mode string
in the Exif editor, so that it can have a different translation
than other ‘Spot’ (colour) strings. Also changes the ‘Spot’
string in the palette editor to ‘Spot color’, to make it
clearer what the checkbox does.

BUG: 410339

In the Exif metadata, the ‘Portrait’ and ‘Landscapes’ strings
mean actual photos of people and landscape, but in the rest of
the Krita UI, they mean vertical/horizontal paper orientation.
This adds ‘msgctxt’ info for the Exif strings, so that they can
translated differently than the paper orientation strings.

BUG: 410342

The list of backers shown in the ‘About’ dialogue ended with
‘and xxx anonymous donors, .’. This fixes the trailing ‘, ’.
It also avoids a loop when adding the donor names.

Adds right click context menu to gradient editor widget with the ability
to sort gradients by value. 'Sort by Value' simply sorts the values onto
the gradient by the value of the color and thus is distributed
appropriately. 'Sort by Value (Even Distribution)' sorts the stops by
value but instead of placing them by color value onto the gradient, it
evenly distributes the colors across the entire gradient space. Both of
these values can be flipped using the 'reverse' button or the reverse
option in the right click menu.

At least check first unsigned is bigger than 0 before comparing.

Mark unused variable as such