KDE Review

KDE Review checklist

• If from outside KDE, has completed the Incubator process
• The REUSE Specification - Version 3.0 is applied when stating licenses and when adding license files to a project. Each source file either must contain SPDX identifiers or license headers to state under which terms the software may be used, modified and redistributed. See Licensing Policy
• Passing CI job for Reuse linting
• A Messages.sh file which extracts all the i18n() translations
• A metainfo.xml file (previously appdata.xml) with AppStream data AppStream Guidelines
• A screenshot in product-screenshots
• Check the code with some sanity tools like clazy or clang-tidy, if not already done as part of CI runs.
• Documentation appropriate to the project: if a library, API documentation (such as Doxygen for C++), if an application, user documentation (such as a README detailing what the application does or is for, how to install/build, and other such useful information)
• A bugs.kde.org product (file a sysadmin ticket)
• Passing Gitlab CI build jobs
• Passing KDE neon build
• App packages in Flatpak, Snap, AppImages and Windows etc. as appropriate

Additional notes

Please also take a look at #566 for know issues and open tasks. The mid-term goal is to use more functionality provided by KDE Frameworks and with that reduce dependencies on git submodules and custom solutions. Part of this is also to submit some pieces like the color widgets to KF.

Some of this has already been started by !35 (merged) and more is being worked on (eg. !42 (merged) ) however as this is a larger task we don't want to consider this a blocker for KDE review.