Skip to content
  • Valeriy Malov's avatar
    Try to keep ContextManager in sync with viewed files in MainWindow · b55420b2
    Valeriy Malov authored
    Summary:
    ContextManager now is responsible for switching to the directory
    containing requested URL and selecting it. However, if it is not
    possible, URL is still kept (in case of remote URLs), while selection is
    cleared (to avoid dragging in local files)
    
    MainWindow now relies on ContextManager's selection and/or
    selectedFileItemList instead of ThumbnailView selection. If selection &
    currentUrl are empty, refuse to open View tab, otherwise display
    selected items.
    
    This should prevent (reduce?) the amount of mismatches between which
    files user sees, and which files are being operated upon
    (e.g. by FileOpsContextManagerItem)
    
    BUG: 355493
    BUG: 275807
    BUG: 326190
    BUG: 306835
    
    Test Plan:
    Tried playing around to make sure it doesn't break any old behaviour
    Tried deleting all image files while in View mode, to make sure we back out when we run out of images
    Tried opening an http url and check that operations apply to it unless we select something in browse tab
    And then remote image should be unloaded from the View tab since our actions will now affect user-selected items
    
    Tests pass but they don't seem to cover this?
    
    Reviewers: #kde_applications, gateau, rkflx
    
    Reviewed By: gateau, rkflx
    
    Subscribers: ngraham, rkflx, gateau
    
    Differential Revision: https://phabricator.kde.org/D8196
    b55420b2