Commit 53330827 authored by Nate Graham's avatar Nate Graham
Browse files

Remove Spacebar and Backspace as navigation keys in View mode

These keys are problematic for a few reasons:
1. Spacebar conflicts with play/pause, so when you navigate to a video,
   you can't navigate away from it using the spacebar key anymore
2. The Backspace key is a slightly scary key to use for navigation since
   in all other contexts, it means "delete this thing"

In the past, the arrow keys did not trigger wrap or the "you've reach
the beginning/end" dialog, so you had to use space/backspace to do those
things. However this has since been corrected. So we can safely use only
the arrow keys for navigation.
parent 60e76331
...@@ -464,7 +464,6 @@ struct MainWindow::Private ...@@ -464,7 +464,6 @@ struct MainWindow::Private
mGoToPreviousAction->setIcon(QIcon::fromTheme("go-previous-view")); mGoToPreviousAction->setIcon(QIcon::fromTheme("go-previous-view"));
mGoToPreviousAction->setText(i18nc("@action Go to previous image", "Previous")); mGoToPreviousAction->setText(i18nc("@action Go to previous image", "Previous"));
mGoToPreviousAction->setToolTip(i18nc("@info:tooltip", "Go to previous image")); mGoToPreviousAction->setToolTip(i18nc("@info:tooltip", "Go to previous image"));
actionCollection->setDefaultShortcut(mGoToPreviousAction, Qt::Key_Backspace);
installDisabledActionShortcutMonitor(mGoToPreviousAction, SLOT(showFirstDocumentReached())); installDisabledActionShortcutMonitor(mGoToPreviousAction, SLOT(showFirstDocumentReached()));
mGoToNextAction = view->addAction("go_next", q, SLOT(goToNext())); mGoToNextAction = view->addAction("go_next", q, SLOT(goToNext()));
...@@ -472,7 +471,6 @@ struct MainWindow::Private ...@@ -472,7 +471,6 @@ struct MainWindow::Private
mGoToNextAction->setIcon(QIcon::fromTheme("go-next-view")); mGoToNextAction->setIcon(QIcon::fromTheme("go-next-view"));
mGoToNextAction->setText(i18nc("@action Go to next image", "Next")); mGoToNextAction->setText(i18nc("@action Go to next image", "Next"));
mGoToNextAction->setToolTip(i18nc("@info:tooltip", "Go to next image")); mGoToNextAction->setToolTip(i18nc("@info:tooltip", "Go to next image"));
actionCollection->setDefaultShortcut(mGoToNextAction, Qt::Key_Space);
installDisabledActionShortcutMonitor(mGoToNextAction, SLOT(showLastDocumentReached())); installDisabledActionShortcutMonitor(mGoToNextAction, SLOT(showLastDocumentReached()));
mGoToFirstAction = view->addAction("go_first", q, SLOT(goToFirst())); mGoToFirstAction = view->addAction("go_first", q, SLOT(goToFirst()));
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment