1. 09 Oct, 2020 1 commit
  2. 29 May, 2020 1 commit
  3. 27 May, 2020 1 commit
  4. 02 Oct, 2019 1 commit
    • Felipe Peter's avatar
      Change UI for setting jpeg quality to slider · 1a2623d9
      Felipe Peter authored
      Summary:
      [[ https://phabricator.kde.org/D23106 | D23106 ]] added a spinner box to set a save quality for JPEG images. I changed it to a slider to be consistent with the same functionality in Spectacle, but I didn't use the ticks because it makes the slider me misaligned with the respective label. Also, I used % as the label unit. I think it is more clear and will therefore propose the same for Spectacle.
      
      I did not really understand how in the [[ https://phabricator.kde.org/D23106 | original commit ]] the value from the spinner box was saved to the config, so I set it explicitly when the slider value changes.
      
      Test Plan:
      Set high quality in settings, don't change in save dialog -> Output image has high quality
      Set high quality in settings, override in save dialog with low quality -> Output image has low quality
      Set low quality in settings, don't change in save dialog -> Output image has low quality
      Set low quality in settings, override in save dialog with high quality -> Output image has high quality
      
      Reviewers: ngraham, #vdg, #gwenview
      
      Reviewed By: ngraham, #vdg, #gwenview
      
      Subscribers: #spectacle
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D24309
      1a2623d9
  5. 10 Sep, 2019 1 commit
  6. 27 Feb, 2019 1 commit
  7. 13 Jan, 2019 1 commit
  8. 02 Oct, 2018 1 commit
    • Chris Suran's avatar
      Add Zoom scroll wheel option · ddfcaa0f
      Chris Suran authored
      Summary:
      Adding a Zoom option for scrolling in the configuration
      
      BUG: 254511
      FIXED-IN: 18.12.0
      
      Test Plan: Test scrolling in image and folder view for each configuration selection.
      
      Reviewers: #gwenview, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: sourabhboss, muhlenpfordt, ngraham
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D15809
      ddfcaa0f
  9. 09 Apr, 2018 3 commits
    • Huon Imberger's avatar
      Rename Transparent background config options · 4fcdb821
      Huon Imberger authored
      Summary:
      This makes the meaning of this option more clear. It also uses the
      correct term "checkerboard" instead of "check board".
      
      I have left the `RasterImageView::AlphaBackground*` terminology the same
      as I believe it makes more sense as is in terms of what the code does.
      For example `AlphaBackgroundNone` means we do not draw a background or
      draw a transparent background.
      
      Depends on D11630
      
      Before:
      {F5778723}
      
      After:
      {F5781170}
      
      Test Plan: Ensure all transparent background options continue to function.
      
      Reviewers: #gwenview, rkflx, ngraham
      
      Reviewed By: #gwenview, rkflx
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D11824
      4fcdb821
    • Huon Imberger's avatar
      Add "None" option for transparent background in Image view · 7cb584e2
      Huon Imberger authored
      Summary:
      Some users may prefer viewing images with an alpha channel without a
      background. Before D11629 this was the behaviour for SVGs, but is now
      impossible for both SVGs and raster images. This patch adds this option,
      effectively adding functionality for raster images, and getting back the
      previous behaviour for SVGs.
      We also make {nav None} the default.
      
      For raster images, choosing {nav None} paints the buffer with
      `Qt::transparent` where needed.
      For SVGs, this option doesn't draw anything, which was the behaviour before
      D11629.
      
      Depends on D11629
      
      Example (PNG on left, SVG on right):
      {F5764317}
      
      Fullscreen:
      {F5766995}
      
      Test Plan:
      Test the {nav None} option for both raster images and SVGs.
      Ensure other options (checkboard and solid color) are unaffected.
      
      Reviewers: #gwenview, rkflx, ngraham
      
      Reviewed By: #gwenview, rkflx, ngraham
      
      Subscribers: zzag, muhlenpfordt
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D11630
      7cb584e2
    • Huon Imberger's avatar
      Add support for configurable transparent background to SVGs · 836ec0e4
      Huon Imberger authored
      Summary:
      SVGs do not honor the "Transparent background" config option, and simply have no
      background at all. This patch ensures this option is applied to SVGs as well as
      raster images.
      
      Unlike `RasterImageView` that uses a `QPixmap` buffer (`mCurrentBuffer`) for drawing
      the background and the image, SVGs are rendered directly on top of `SvgImageView`
      (`QGraphicsWidget`). Therefore we just paint the background in `SvgImageView::paint`
      which happens before the SVG is rendered.
      
      We move the checkboard texture code to `AbstractImageView` now that it's used by
      both subclasses `RasterImageView` and `SvgImageView`.
      
      This patch also configures kconf_update due to the moving of the above enum.
      Since I didn't want to litter `/app` with files, I've moved the update files to
      `/kconf_update`.
      
      Fixes T8125
      
      Before:
      {F5764298}
      
      After:
      {F5764299}
      {F5764300}
      
      Test Plan:
        - Open an SVG with solid color config option
        - Open and SVG with checkboard background config. At a high enough zoom (where the
          birdseye view shows up), panning/scrolling should have the checkboard pattern
          fixed to the image, like raster images
        - Ensure raster images with transparent backgrounds are unaffected
      
      ## kconf_update
      The script `gwenview-imageview-alphabackgroundmode-update.pl` must be in
      `/usr/share/kconf_update` in order for `/usr/lib/kf5/kconf_update` to find it.
      If successfull, instances of `RasterImageView::AlphaBackground*` should change to
      `AbstractImageView::AlphaBackground*`.
      
      Reviewers: #gwenview, rkflx, ngraham
      
      Reviewed By: #gwenview, rkflx, ngraham
      
      Tags: #gwenview
      
      Maniphest Tasks: T8125
      
      Differential Revision: https://phabricator.kde.org/D11629
      836ec0e4
  10. 14 Feb, 2018 1 commit
  11. 29 Jan, 2018 1 commit
    • Nathaniel Graham's avatar
      Add a user-facing control to choose the ICC color rendering intent · 338ffeee
      Nathaniel Graham authored
      Summary:
      FEATURE: 359909
      FIXED-IN: 18.04
      
      Allow the user to choose the ICC color rendering intent, instead of hardcoding INTENT_PERCEPTUAL
      
      Supersedes D8763
      
      Test Plan:
      The GUI control appears and seems to work as intended.
      
      {F5680320}
      
      - Tested that the default value of Perceptual is used when there is no value in ~/.config/gwenviewrc
      - Tested that the value gets set in ~/.config/gwenviewrc
      - Tested that removing the value in ~/.config/gwenviewrc reverts the GUI setting to Perceptual
      - Tested that toggling the setting back and forth actually has an impact when using a display with an active color profile. Here's an example:
      
      Perceptual:
      {F5677933}
      
      Relative Colorimetric:
      {F5677990}
      
      Reviewers: DrSlony, rkflx
      
      Reviewed By: rkflx
      
      Subscribers: muhlenpfordt, rempt, behrmann
      
      Differential Revision: https://phabricator.kde.org/D10076
      338ffeee
  12. 08 Oct, 2016 1 commit
    • Frederik Gladhorn's avatar
      Remove ConfigDialogPrivate · 562cc26f
      Frederik Gladhorn authored
      Gwenview is an app, there is no reason to allocate a private object for
      the data members of the config dialog. Simplify the whole thing.
      562cc26f
  13. 05 Mar, 2015 2 commits
  14. 13 Aug, 2014 3 commits
  15. 07 Aug, 2014 1 commit
    • John Zaitseff's avatar
      Allow different ways to handle zoom and position between images · 5572aded
      John Zaitseff authored
      (Taken from bug #337262 )
      
      Over the years, there has been much discussion about whether the zoom and position should be kept the same between images (see, for example, bug 293103, which I submitted, or bugs 291759, 294915, 321122, 327889, 331412, 334530, 337037 --- there may be more!).  I have even submitted a patch (with bug 293103) which was applied in modified form---thanks!  However, it has been subsequently broken...
      
      I have come to realise that there are THREE main ways people like to have the zoom and position settings applied to successive images:
      
      1. Each image should be opened in Zoom to Fit mode, even if the previous image was zoomed in or out and was panned to a different position.  This is Aurélien Gâteau's preferred mode of operation: call it Autofit zoom mode.
      
      2. The zoom and position settings should be shared across all images.  New images should be opened with the previous image's settings.  If you go back to a previous im...
      5572aded
  16. 16 Dec, 2011 1 commit
  17. 07 Dec, 2011 1 commit
  18. 04 Dec, 2011 1 commit
  19. 20 Nov, 2011 1 commit
  20. 18 Nov, 2011 1 commit
  21. 28 Oct, 2011 1 commit
  22. 15 Oct, 2011 1 commit
  23. 22 May, 2011 1 commit
  24. 22 Sep, 2010 1 commit
  25. 09 May, 2009 1 commit
  26. 26 Apr, 2009 2 commits
  27. 28 Mar, 2009 1 commit
  28. 01 Oct, 2008 2 commits
  29. 24 Jun, 2008 1 commit
  30. 23 Feb, 2008 1 commit
  31. 15 Feb, 2008 1 commit
  32. 02 Feb, 2008 1 commit
  33. 13 Jan, 2008 1 commit