1. 09 Oct, 2020 1 commit
  2. 02 Oct, 2019 1 commit
    • Felipe Peter's avatar
      Change UI for setting jpeg quality to slider · 1a2623d9
      Felipe Peter authored
      Summary:
      [[ https://phabricator.kde.org/D23106 | D23106 ]] added a spinner box to set a save quality for JPEG images. I changed it to a slider to be consistent with the same functionality in Spectacle, but I didn't use the ticks because it makes the slider me misaligned with the respective label. Also, I used % as the label unit. I think it is more clear and will therefore propose the same for Spectacle.
      
      I did not really understand how in the [[ https://phabricator.kde.org/D23106 | original commit ]] the value from the spinner box was saved to the config, so I set it explicitly when the slider value changes.
      
      Test Plan:
      Set high quality in settings, don't change in save dialog -> Output image has high quality
      Set high quality in settings, override in save dialog with low quality -> Output image has low quality
      Set low quality in settings, don't change in save dialog -> Output image has low quality
      Set low quality in settings, override in save dialog with high quality -> Output image has high quality
      
      Reviewers: ngraham, #vdg, #gwenview
      
      Reviewed By: ngraham, #vdg, #gwenview
      
      Subscribers: #spectacle
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D24309
      1a2623d9
  3. 24 Aug, 2019 1 commit
    • Nate Graham's avatar
      Allow the user to select the JPEG save/compression quality · 24cd548e
      Nate Graham authored
      Summary:
      Currently, anytime Gwenview is used to save a non-JPEG file as a JPEG, or anytime JPEG file is saved or re-saved after performing a lossy edit (e.g. crop or red eye, but not rotation), the new file is saved with 75% quality level, resulting in a noticeable degradation in appearance.
      
      This patch implements a user-selectable JPEG save/compression quality setting, which can be temporarily overridden in the {nav Save As} dialog when saving a file as a JPEG. The new default quality level is 90% -- same as Spectacle. This should prevent people from accdientally destroying their JPEGs.
      
      As before, when saving an existing JPEG file with a new name or after performing a non-lossy edit (e.g. rotation, which only changes the EXIF rotation tag), the appearance of the file is not changed because no actual image manipulation is done.
      
      FEATURE: 277996
      FIXED-IN: 19.12.0
      
      Test Plan:
      {F7205336}
      
      {F7208763}
      
      Set JPEG quality to 5% in the config file and test the following use cases:
      - Non-JPEG image: do {nav Save} or {nav Save As} in non-JPEG formats -> No changes or regressions.
      - JPEG image: do {nav Save} or {nav Save As} without changing the image format or the image's pixels at all -> No changes; quality level not taken into consideration because these are lossless operations that do not re-compress the image (which is good)
      - JPEG image: do {nav Save} or {nav Save As} after changing the image's pixels in some way (e.g. a crop operation) -> Image is saved with the user-specified 5% quality level and looks terrible
      - JPEG image: do {nav Save As} into a non-JPEG file format after changing the image image's pixels in some way, or not -> No changes or regressions (in particular, lossless images like PNG are not hugely ballooned in file size)
      
      Set JPEG quality to 90% in the config file and test the following use cases:
      - Non-JPEG image: do {nav Save As} in non-JPEG formats -> No changes or regressions; dialog box does not show quality spinbox
      - Non-JPEG image: do {nav Save As} into a JPEG and in the {nav Save As] dialog, change the quality from 90% to 5%-> Image is saved with the user-specified 5% quality level and looks terrible
      - JPEG image: do {nav Save As} into a non-JPEG file format -> No changes or regressions; dialog box does not show quality spinbox
      - JPEG image: do {nav Save As} after changing the image's pixels in some way (e.g. a crop operation), and in the {nav Save As] dialog, change the quality from 90% to 5%-> Image is saved with the user-specified 5% quality level and looks terrible
      
      Reviewers: #gwenview, #vdg
      
      Subscribers: filipf, pino
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D23106
      24cd548e
  4. 15 Feb, 2018 1 commit
    • rkflx's avatar
      Remove undesirable accelerators · a150e626
      rkflx authored
      Editing `.ui` files with Qt Designer in KDE Plasma can result in
      superfluous `&` accelerators being added (see
      https://stackoverflow.com/a/32711483 and D10421#206934 for discussion).
      This happened in 4a87ed95 and 4efdfcda, with the remaining
      accelerators at the start of words as a deliberate choice.
      
      Test Plan:
      Even after the removal keyboard access is still possible (ignoring the
      bug that for Crop and Red Eye Reduction the underline was not displayed
      anyway even though the accelerator worked and still works…).
      a150e626
  5. 14 Feb, 2018 1 commit
  6. 22 May, 2011 1 commit
  7. 30 Mar, 2010 1 commit
  8. 01 Oct, 2008 1 commit