1. 17 Oct, 2020 1 commit
  2. 26 Jul, 2018 1 commit
  3. 26 Jun, 2018 1 commit
  4. 02 Jun, 2018 1 commit
    • Huon Imberger's avatar
      Allow dragging files/folders to View mode · 131d2585
      Huon Imberger authored
      Summary:
      Specifically accepts drop events within the viewport of {nav View} mode.
      If a folder that contains images is dropped, it will open that folder
      and remain in {nav View} mode with the first image selected. If the
      folder doesn't contain images, it switches to {nav Browse} mode.
      Dragging multiple items is supported but only the first item is opened.
      
      BUG: 169408
      FIXED-IN: 18.08.0
      
      {F5781556}
      
      Test Plan:
      Test with different image formats, as well as unsupported format (Gwenview
      should display a nice error).
      Test with folder (with and without images within).
      {nav Browse} mode and the {nav Thumbnail Bar} drag drop should work as before.
      Drop operations should not be accepted anywhere else in the GUI where they aren't
      already supported. In other words, this should only add drop functionality to the
      {nav View} viewport.
      
      Ensure drops are only accepted for URL mimetypes (e.g. ignore text).
      
      Reviewers: #gwenview, rkflx, ngraham
      
      Reviewed By: #gwenview, rkflx
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D11879
      131d2585
  5. 25 Apr, 2018 1 commit
    • Huon Imberger's avatar
      Display document count labels in View, Browse, and Full Screen modes · 14199f3b
      Huon Imberger authored
      Summary:
      {nav Browse} mode: The existing total count is now split into images
      and videos, e.g. "5 images, 3 videos". When 2 or more documents (that
      is, images or videos) are selected, the label changes to display how
      many are selected and their total size. E.g. "4 of 10 selected (3.4
      MiB).
      
      {nav View} mode: A new label in the status bar, showing the current
      document index, and total in the folder, e.g. "32 of 753". This label is
      hidden in Lighttable mode, and elided if there's no room for it.
      
      {nav Full Screen} mode: Similar to {nav View}, the current index and
      total count is displayed. This is in the format "32 of 753", and is
      anchored to the bottom right of the information panel.
      
      Each mode calculates these values independently. This is because for
      {nav View} and {nav Full Screen}, the thumbnail bar model has already
      filtered out any item that isn't viewable, therefore it's easy to simply
      get the current index and total items. In {nav Browse}, folders and
      archives are displayed, so there needs to be extra logic that filters
      them out appropriately.
      
      BUG: 203042
      FIXED-IN: 18.08.0
      
      Browse:
      {F5811297}
      
      Browse (with selection):
      {F5811298}
      
      View:
      {F5811299}
      
      View (compare):
      {F5811300}
      
      Full Screen:
      {F5814068}
      
      Full Screen (large thumbnails):
      {F5814069}
      
      Full Screen (thumbnail bar disabled):
      {F5814071}
      
      Test Plan:
      Browse:
        - Only images and videos should be counted (directories and archives
        ignored).
        - Label should change to "Selected..." when 2 or more images/videos
        selected
      
      View:
        - Count/index should match the thumbnail view, i.e., only items in the
        thumbnail bar should be counted.
        - Changes to documents should be reflected in the index and total:
          - Renaming causing a change in sort order
          - Adding/deleting documents
        - Document count label should be hidden in Compare/Lighttable mode to
        allow room for the Synchronize checkbox
      
      Full Screen View:
        - Same as View above, plus;
        - Enable/disable the thumbnail bar
        - Enable and resize the thumbnail bar
        - View images with long filesnames, and/or addition meta info enabled
        - In Compare/Lighttable mode, current document index should reflect the
        currently selected image
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx, muhlenpfordt
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D12301
      14199f3b
  6. 04 Apr, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Set focus back to image view after leaving edit tool · 7369f471
      Peter Mühlenpfordt authored
      Summary:
      If you click on the toolbar of an image edit tool (crop, redeye)
      the focus is lost after leaving the tool and you cannot switch images
      with cursor keys.
      This patch resets the focus to image view after leaving the edit tool.
      
      BUG: 321091
      
      Test Plan:
      * Open image in Gwenview View Mode (normal or fullscreen)
      * Start crop tool ({key Shift C})
      * Click on {nav Crop} or {nav Cancel}
      * Switching images with cursor keys should work as usual
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx, huoni
      
      Differential Revision: https://phabricator.kde.org/D11899
      7369f471
  7. 15 Feb, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Fix squished toolbar buttons in fullscreen view mode · ce61ed46
      Peter Mühlenpfordt authored
      Summary:
      In fullscreen view mode the sidebar splitter can be moved to the right
      until the toolbar buttons are squished a bit.
      This is caused by a missing layout connection which would propagate
      the correct minimum size hints. Since the toolbar in view mode
      overlaps the image view a standard layout is not usable here.
      This patch sets a minimum size hint for the image view according to
      the internal layout of the overlay toolbar width.
      
      {F5690953}
      
      Test Plan:
      1. Open gwenview in fullscreen view mode
      2. Move sidebar splitter to right just before collapsing
      -> The buttons of the top toolbar should remain in original size
      
      Checked to correctly adjust width while:
      * Toggling status bar ({key F3})
      * Toggling {nav Show thumbnails}
      * Opening images with different length filenames (thumbnails off)
      
      Reviewers: rkflx, ngraham, #gwenview
      
      Reviewed By: rkflx
      
      Differential Revision: https://phabricator.kde.org/D10458
      ce61ed46
  8. 11 Feb, 2018 1 commit
    • rkflx's avatar
      Clean up code tracking fullscreen state · 140393d0
      rkflx authored
      Summary:
      After syncing Gwenview's fullscreen mode with that of the window manager
      in 0d917337, we can just ask the window for its fullscreen state
      instead of having to track this for ourselves.
      
      This gets rid of a bunch of `bools` and reduces chances those might
      accidentally get out of sync at some point. In addition, we can
      eliminate duplication and dependence on execution order in
      `MainWindow::toggleFullScreen`.
      
      Test Plan:
      - `qDebug()` comparing `mFullScreenMode` and `window()->isFullscreen()`
      - Manual testing of every functionality affected:
        - Switching to and from fullscreen mode (both via Gwenview and window manager).
        - {key Esc} to exit fullscreen mode.
        - Special fullscreen toolbar works.
        - Toggling sidebar resizes fullscreen toolbar.
        - Sidebar state remembered separately for normal and fullscreen mode.
        - Savebar not visible in fullscreen mode.
        - Memory warning bar still works in fullscreen mode.
      
      Reviewers: muhlenpfordt
      
      Reviewed By: muhlenpfordt
      
      Differential Revision: https://phabricator.kde.org/D10412
      140393d0
  9. 22 Jan, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Add browse mode action to action collection again · 5bcb8cc9
      Peter Mühlenpfordt authored
      Summary:
      The browse mode action with default shortcut {nav Esc} is not added to action collection (removed in D5824) and therefore not visible/changeable in {nav Settings > Configure Shortcuts}.
      Using {nav Esc} as shortcut for e.g. Quit does not work.
      This patch re-adds the browse mode action to action collection, but also checks for `ShortcutOverride` events to handle active tool dialogs.
      
      BUG: 385242
      
      Test Plan:
      1. Open gwenview
      2. Set alternate shortcut {nav Esc} in {nav Settings -> Configure Shortcuts} for Quit command
      3. Press {nav Esc}
      -> Should exit gwenview
      
      If tool dialog (crop, red eye reduction) is active, pressing {nav Esc} should not exit gwenview, but the tool dialog first.
      
      Reviewers: cfeck, rkflx, ngraham
      
      Reviewed By: rkflx, ngraham
      
      Subscribers: ngraham
      
      Differential Revision: https://phabricator.kde.org/D9943
      5bcb8cc9
  10. 04 Jun, 2017 1 commit
  11. 02 Jun, 2017 1 commit
  12. 03 Mar, 2017 1 commit
  13. 03 Oct, 2014 1 commit
  14. 13 Aug, 2014 1 commit
  15. 29 Sep, 2012 1 commit
  16. 07 Aug, 2012 1 commit
  17. 27 Jun, 2012 1 commit
    • Aurélien Gâteau's avatar
      Make "lock zoom" feature optional · d212ad8d
      Aurélien Gâteau authored
      Having used Gwenview with the lock zoom feature back in. I realize it
      is a useful feature, but strongly believes should not be enabled by default.
      
      This commit reverts to not locking zoom by default, but introduces an
      hidden config option which can be set with:
      
      kwriteconfig --file gwenviewrc --group ImageView \
        --key ShowLockZoomButton --type bool true
      
      When this is set, a lock button appears on the right of the zoom level.
      Clicking it will lock zoom, clicking it again will unlock zoom.
      
      I want to find a better solution for this in KDE SC 4.10: I don't like how
      the lock button adds clutter to the already cluttered, zoom widgetry, but
      this should do for KDE SC 4.9.
      
      CCBUG: 291759
      d212ad8d
  18. 13 Apr, 2012 1 commit
  19. 23 Dec, 2011 1 commit
  20. 09 Dec, 2011 2 commits
  21. 07 Dec, 2011 1 commit
  22. 02 Dec, 2011 1 commit
  23. 18 Nov, 2011 1 commit
  24. 04 Nov, 2011 1 commit
  25. 27 Oct, 2011 1 commit
  26. 23 Oct, 2011 1 commit
  27. 13 Oct, 2011 2 commits
  28. 27 Sep, 2011 1 commit
  29. 27 May, 2011 1 commit
  30. 21 Mar, 2011 1 commit
  31. 20 Mar, 2011 4 commits
  32. 05 Mar, 2011 3 commits
  33. 25 Feb, 2011 1 commit