1. 30 Jun, 2019 1 commit
  2. 28 Jun, 2019 2 commits
  3. 25 Jun, 2019 1 commit
  4. 24 Jun, 2019 1 commit
  5. 22 Jun, 2019 4 commits
  6. 03 Jun, 2019 1 commit
  7. 02 Jun, 2019 1 commit
  8. 25 May, 2019 1 commit
  9. 24 May, 2019 7 commits
  10. 23 May, 2019 1 commit
    • Tom Moebert's avatar
      Correctly crop embedded thumbs for Canon JPEGs · 6aa7a11b
      Tom Moebert authored and Nate Graham's avatar Nate Graham committed
      Summary:
      JPEGs created by Canon Cameras have an embedded thumbnail. However only a certain area of the thumb is "valid", i.e. there are black bars on top and bottom. This change moves the thumbnail extraction logic to JpegContent and correctly crops the thumb by reading the Canon specific exif tag. The same black bars can be observed in thumbnails by Sony and Nikon. They however don't seem to provide such an exif tag, AFAIK.
      
      Also suggests to let the thumbnailgenerator use the embedded thumbnail even if applyExifOrientation() is disabled. I don't see how the original image and its embedded thumb can be rotated differently, i.e. effectively being two different images. The only purpose of applyExifOrientation() should be to apply any rotation/transformation consistently to both, the original and its thumb, and not preventing to use the embedded thumb at all.
      
      Reviewers: #gwenview, ngraham
      
      Reviewed By: #gwenview, ngraham
      
      Subscribers: ngraham, #gwenview
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D21329
      6aa7a11b
  11. 22 May, 2019 3 commits
  12. 21 May, 2019 2 commits
  13. 15 May, 2019 4 commits
    • Andreas Sturmlechner's avatar
      Merge branch 'Applications/19.04' · 4d6f1139
      Andreas Sturmlechner authored
      4d6f1139
    • Andreas Sturmlechner's avatar
      Fix build with exiv2-0.27.1 · 172560b8
      Andreas Sturmlechner authored and Andreas Sturmlechner's avatar Andreas Sturmlechner committed
      Summary:
      Upstream is moving things around between headers. While they are busy doing that, they recommend including exiv2.hpp.
      
      ```
      lib/imagemetainfomodel.cpp:293:40: error: expected unqualified-id before ‘&’ token
                   } catch (const Exiv2::Error& error) {
                                              ^
      ```
      
      Reviewers: #gwenview, ngraham
      
      Reviewed By: #gwenview, ngraham
      
      Subscribers: ngraham, devurandom
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D21148
      172560b8
    • Tom Moebert's avatar
      Fix incomplete EXIF data for RAW files · a985ad14
      Tom Moebert authored and Nate Graham's avatar Nate Graham committed
      Summary:
      In case of RAW files exiv2 retrieved the EXIF data from the JPEG preview
      image `previewData`. This however contains incomplete EXIF data. Thus
      provide exiv2 with the full raw image and let it find the most suitable
      EXIF data chunk.
      
      BUG: 346510
      
      Reviewers: #gwenview, ngraham
      
      Reviewed By: #gwenview, ngraham
      
      Subscribers: ngraham
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D21161
      a985ad14
    • Tom Moebert's avatar
      Ensure the loading indicator is actually displayed · b5de993a
      Tom Moebert authored and Nate Graham's avatar Nate Graham committed
      Summary:
      Previously the indicator was only displayed if the file's MIME type has
      not been recognized yet. However for local files the MIME type was always
      detected during a synchronous load by the UI thread, thus the indicator
      was never displayed. This can be especially noticed when loading big
      panorama images that take a few seconds before fully decoded. With this
      change the indicator is displayed as soon as a new url is opened.
      
      Reviewers: #gwenview, ngraham
      
      Reviewed By: #gwenview, ngraham
      
      Subscribers: ngraham
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D21163
      b5de993a
  14. 02 May, 2019 1 commit
  15. 24 Apr, 2019 2 commits
  16. 08 Apr, 2019 2 commits
  17. 07 Apr, 2019 2 commits
    • Nate Graham's avatar
      Merge branch 'Applications/19.04' · 8c7e2e48
      Nate Graham authored
      8c7e2e48
    • Alexander Volkov's avatar
      Add HiDPI support for thumbnails · 968c411a
      Alexander Volkov authored and Nate Graham's avatar Nate Graham committed
      Summary:
      The idea is to localize changes in ThumbnailView as much as possible:
      ThumbnailView::thumbnailSize() returns the size in device independent
      pixels, i.e. it seems from the outside that ThumbnailView behaves as
      well as before this change. But, of course, item delegates must take
      into account that ThumbnailView::thumbnailForIndex() will return
      a pixmap with the devicePixelRatio set.
      
      CCBUG: 373178
      
      Reviewers: #gwenview, ngraham
      
      Reviewed By: #gwenview, ngraham
      
      Subscribers: ngraham
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D20267
      968c411a
  18. 04 Apr, 2019 2 commits
    • Nate Graham's avatar
      Merge branch 'Applications/19.04' · 86689ad1
      Nate Graham authored
      86689ad1
    • Alexander Volkov's avatar
      HiDPI Support for Gwenview · 97e7de52
      Alexander Volkov authored
      Summary:
      Initial support for HiDPI-scaling of documents in RasterImageView.
      
      This patch scales up images to display them correctly on HiDPI-enabled screens.
      
      TODO:
      - SVG documents and videos
      - Scaling of thumbnails
      
      BUG: 373178
      
      Reviewers: davidedmundson, rkflx, hetzenecker, ngraham, #gwenview
      
      Reviewed By: ngraham, #gwenview
      
      Subscribers: volkov, asturmlechner, fvogt, abalaji, rkflx, ngraham, anthonyfieroni, cfeck, asn
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D7581
      97e7de52
  19. 31 Mar, 2019 1 commit
  20. 27 Mar, 2019 1 commit