1. 15 Apr, 2021 2 commits
  2. 05 Mar, 2021 1 commit
  3. 17 Nov, 2020 2 commits
  4. 24 May, 2020 1 commit
  5. 06 Apr, 2020 1 commit
  6. 09 Jan, 2020 1 commit
  7. 03 Dec, 2019 1 commit
  8. 18 Sep, 2019 1 commit
  9. 12 Aug, 2019 1 commit
  10. 28 Jun, 2019 1 commit
  11. 07 Apr, 2019 1 commit
    • Alexander Volkov's avatar
      Add HiDPI support for thumbnails · 968c411a
      Alexander Volkov authored and Nate Graham's avatar Nate Graham committed
      Summary:
      The idea is to localize changes in ThumbnailView as much as possible:
      ThumbnailView::thumbnailSize() returns the size in device independent
      pixels, i.e. it seems from the outside that ThumbnailView behaves as
      well as before this change. But, of course, item delegates must take
      into account that ThumbnailView::thumbnailForIndex() will return
      a pixmap with the devicePixelRatio set.
      
      CCBUG: 373178
      
      Reviewers: #gwenview, ngraham
      
      Reviewed By: #gwenview, ngraham
      
      Subscribers: ngraham
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D20267
      968c411a
  12. 16 Mar, 2019 1 commit
    • Steffen Hartleib's avatar
      Touch support for Gwenview · 603fd1e1
      Steffen Hartleib authored and Nate Graham's avatar Nate Graham committed
      Summary:
      Add touch support for Gwenview. At moment one finger scrolling, pinch gesture for zoom and rotate and one finger
      swipe gesture to go to next or previous image is working with some little issue.
      
      It is my first time I am modify the source code, so if I make same mistake please let me now.
      
      CCBUG: 378021
      
      Test Plan:
      Browse mode
      ===========
      * test, if mouse and touchpad working as previously: scrolling, selection and drag and drop
      
      all follow tests with touchscreen:
          * on finger scrolling, test if uwanted drag events or selection events occur
          * two finger scrolling, test if uwanted drag events or selection events occur
          * test drag and drop action (need a TabAndHold gesture before moving the touch point)
          * pinch gesture for zoom, check sensitive and unwanted behavior
          * check double touch, if system setting is set to: open file or directory with a double click
      
      View Mode
      =========
      * test, if mouse and touchpad working as previously: scrolling, selection and drag and drop
      
      all follow tests with touchscreen:
          * one finger panning, check if unwanted drag events or image modifying events (zoom/rotate) occur
          * two finger panning, check if unwanted drag events or image modifying events (zoom/rotate) occur
          * one finger swipe gesture, check if unwanted drag events or image modifying events (zoom/rotate) occur
          * two finger swipe gesture, check if unwanted drag events or image modifying events (zoom/rotate) occur
          * pinch gesture for zoom and rotate, check sensitive and unwanted behavior
          * drag and drop action (need a TabAndHold gesture before moving the touch point)
          * test double touch to toggle between view mode and fullscreen mode.
      
      Thumbnail bar in view Mode:
      ===========================
      * test, if mouse and touchpad working as previously: scrolling, selection and drag and drop
      
      all follow tests with touchscreen:
          * one finger scrolling, check if unwanted drag events or image modifying events (zoom/rotate) occur
          * two finger scrolling, test if uwanted drag events or selection events occur
          * drag and drop action (need a TabAndHold gesture before moving the touch point)
      
      Fullscreen Mode
      ===============
      * test, if mouse and touchpad working as previously: scrolling, selection and drag and drop
      
      all follow tests with touchscreen:
          * one finger panning, check if unwanted drag events or image modifying events (zoom/rotate) occur
          * two finger panning,  check if unwanted drag events or image modifying events (zoom/rotate) occur
          * one finger swipe gesture, check if unwanted drag events or image modifying events (zoom/rotate) occur
          * two finger swipe gesture, check if unwanted drag events or image modifying events (zoom/rotate) occur
          * pinch gesture for zoom and rotate, check sensitive and unwanted behavior
          * drag and drop action (need a TabAndHold gesture before moving the touch point)
          * check if you get access to the fullscreen thumbnail bar on the top screen border
      
      Thumbnail bar in fullscreen Mode:
      ===========================
      * test, if mouse and touchpad working as previously: scrolling, selection and drag and drop
      
      all follow tests with touchscreen:
          * one finger scrolling, check if unwanted drag events or image modifying events (zoom/rotate) occur
          * two finger scrolling, check if unwanted drag events or image modifying events (zoom/rotate) occur
          * drag and drop action (need a TabAndHold gesture before moving the touch point)
      
      Reviewers: #gwenview, ngraham, muhlenpfordt
      
      Reviewed By: #gwenview, ngraham
      
      Subscribers: volkov, asturmlechner, sander, ngraham, rkflx
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D13901
      603fd1e1
  13. 13 Jan, 2019 1 commit
  14. 07 Jan, 2019 1 commit
  15. 17 Dec, 2018 1 commit
  16. 28 Sep, 2018 1 commit
  17. 02 Aug, 2018 1 commit
    • __ __'s avatar
      Disable setImageData for dragging of unmodified images · c61693cc
      __ __ authored
      Summary:
      3bb8beb5 and 984b9737 led to Gwenview adding the raw image data
      to the mimedata used when dragging or copying images. In general that's
      fine and sometimes even needed (e.g. when pasting to GIMP).
      
      However, when dragging to the Plasma desktop to copy the image or set it
      as a wallpaper, the drag cursor would stutter and only change to the
      green accepting cursor when hovering for a while. Furthermore, upon
      dropping the image the context menu presenting the actions would take a
      very long time showing up. This is caused by requesting a deep copy of
      the mimedata in `kdeclarative`, resulting in the conversion of the image
      data to all image formats Qt supports (for details, see D13249#300894).
      
      The same problem can be observed when trying to drop an image to
      Chromium, which does not work at all.
      
      Therefore we change `selectionMimeData` to only set the URL for dragging
      unmodified images, which solves the issue both for Plasma and for
      Chromium. (For modified images the problem persists, but it is
      considered more important to provide the modified image data in this
      case for applications supporting it.)
      
      Test Plan:
      In both {nav Browse} and {nav View} mode, drag images to the desktop.
      The context menu should appear swiftly. Also, the behaviour for copying
      and dragging in all other cases should work as specified in the added
      comment.
      
      Reviewers: #gwenview, muhlenpfordt
      
      Reviewed By: #gwenview, muhlenpfordt
      
      Differential Revision: https://phabricator.kde.org/D14543
      c61693cc
  18. 26 Jul, 2018 1 commit
  19. 08 Jul, 2018 1 commit
    • __ __'s avatar
      Show more appropriate cursor when dragging and enable modifier keys · 1bd31c9e
      __ __ authored
      Summary:
      984b9737 enabled dragging from {nav View} mode, but the cursor
      stayed the same as when panning. This is because by default
      `QGraphicsView` sets the cursor for moving objects, i.e.
      `ClosedHandCursor`. By setting a default action for `QDrag::exec`, we
      get the `DragCopyCursor` which better indicates that the image can be
      dropped, and which is also used when dragging from the `ThumbnailView`.
      
      When drag-and-dropping within Dolphin, you can press {key Shift},
      {key Ctrl} or {key Ctrl Shift} to directly move, copy or link a file
      instead of showing the popup menu asking for the desired action. By
      setting all three actions for the drag object, we can enabled this
      behaviour for dragging from Gwenview to Dolphin too, instead of always
      defaulting to copying.
      
      Test Plan:
      Press {key Shift Ctrl} while dragging an image from either {nav View} or
      {nav Browse} mode to Dolphin. A cursor indicating the linking action
      should be shown instead of the panning cursor.
      
      Reviewers: #gwenview, huoni
      
      Reviewed By: #gwenview, huoni
      
      Subscribers: huoni
      
      Differential Revision: https://phabricator.kde.org/D13725
      1bd31c9e
  20. 02 Jun, 2018 1 commit
    • __ __'s avatar
      Refine behaviour for dragging modified images to external applications · 3bb8beb5
      __ __ authored
      Summary:
      In f365a38f support for copying modified images to external
      applications was added. With the refactoring in D13248, we can extend
      that support for dragging.
      
      Depends on D13248
      
      Test Plan:
      Start dragging in Gwenview and drop onto the target for every
      combination of:
      - Source: {nav Browse} mode, {nav Thumbnail Bar} (normal and fullscreen), {nav Start > Recent Files}
      - Formats: JPG, PNG, NEF, SVG
      - Regular and {nav Cropped} image for every source file format
      - Target: Dolphin, GIMP, LibreOffice, Inkscape
      Only dragging of modified images to Dolphin is known to be broken
      currently, but no regression either.
      
      Reviewers: #gwenview, muhlenpfordt
      
      Reviewed By: #gwenview, muhlenpfordt
      
      Differential Revision: https://phabricator.kde.org/D13249
      3bb8beb5
  21. 07 May, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Fix custom folder icons using an absolute path entry · dd0d608a
      Peter Mühlenpfordt authored
      Summary:
      Gwenview does not display a custom folder icon which is configured
      by an absolute path and the folder does not contain any images.
      This is caused by `KIconLoader::loadMimeTypeIcon()` failing for
      absolute path entries. If the folder contains images the preview
      job corrects the icon later.
      Using `KIconLoader::loadIcon()` loads the correct icon.
      
      BUG: 315983
      FIXED-IN: 18.04.2
      
      Test Plan:
      * Create an empty folder (e.g. /tmp/parent/test-empty)
      * Set a custom icon for `test-empty` using an absolute path
      * Start Gwenview in Browse Mode in the `parent` folder
      * Folder `test-empty` should display the custom icon
      
      | Before:    | After:     |
      | {F5818845} | {F5818847} |
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx, huoni
      
      Differential Revision: https://phabricator.kde.org/D12465
      dd0d608a
  22. 09 Apr, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Fix thumbnail update after undo · f78e5e4b
      Peter Mühlenpfordt authored
      Summary:
      After editing an image multiple times (e.g. rotate) and then undoing,
      the thumbnail displays a previous edit state between the undos.
      This is caused by connecting to `QUndoStack` signal `indexChanged`
      which emits before some undo operations are finished and the new
      thumbnail is created too early.
      This patch emits the `modified`/`saved` signals for a document only
      after the undo image operation is finished. It also solves the problem
      displaying a wrong thumbnail in another mode after undoing all edits.
      
      Depends on D11714
      BUG: 356998
      FIXED-IN: 18.04.0
      
      Test Plan:
      * Open image in Gwenview (View or Browse Mode)
      * Edit image at least 3 times (e.g. rotate with {key Ctrl R})
      * Undo all edits ({key Ctrl Z})
      * Thumbnail should always correspond to undo step
      * Thumbnail should be identical in View, Browse and Fullscreen Mode
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx, huoni
      
      Differential Revision: https://phabricator.kde.org/D11715
      f78e5e4b
  23. 08 Apr, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Fix thumbnail bar update after editing a viewed image · e359ebf1
      Peter Mühlenpfordt authored
      Summary:
      After editing an image (e.g. rotate) a new thumbnail is created but
      it is not repainted in the View Mode thumbnail bar.
      The custom signals `documentChanged` and `busyStateChanged` provide
      a `QModelIndex` for the modified document but this is based on the
      source model and cannot be used in `ThumbnailBarView` where the list
      view is based on a filtered proxy model and the index is wrong or
      does not exist in some cases.
      This patch uses the QUrl as argument for both signals and gets the
      proper index for the current model in the receiver view.
      
      FIXED-IN: 18.04.0
      
      Test Plan:
      * Open image in Gwenview View Mode
      * Enable thumbnail bar ({key Ctrl B})
      * Edit image (e.g. rotate with {key Ctrl R})
      * Edit a second time (same or another image)
      * Thumbnail should always correspond to edited image
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx, huoni
      
      Differential Revision: https://phabricator.kde.org/D11714
      e359ebf1
  24. 26 May, 2016 1 commit
  25. 22 Mar, 2015 1 commit
  26. 23 Oct, 2014 1 commit
  27. 13 Oct, 2014 1 commit
  28. 10 Oct, 2014 2 commits
  29. 05 Oct, 2014 1 commit
  30. 03 Oct, 2014 1 commit
  31. 02 Oct, 2014 1 commit
  32. 13 Aug, 2014 6 commits