1. 29 Jan, 2018 1 commit
    • Nathaniel Graham's avatar
      Add a user-facing control to choose the ICC color rendering intent · 338ffeee
      Nathaniel Graham authored
      Summary:
      FEATURE: 359909
      FIXED-IN: 18.04
      
      Allow the user to choose the ICC color rendering intent, instead of hardcoding INTENT_PERCEPTUAL
      
      Supersedes D8763
      
      Test Plan:
      The GUI control appears and seems to work as intended.
      
      {F5680320}
      
      - Tested that the default value of Perceptual is used when there is no value in ~/.config/gwenviewrc
      - Tested that the value gets set in ~/.config/gwenviewrc
      - Tested that removing the value in ~/.config/gwenviewrc reverts the GUI setting to Perceptual
      - Tested that toggling the setting back and forth actually has an impact when using a display with an active color profile. Here's an example:
      
      Perceptual:
      {F5677933}
      
      Relative Colorimetric:
      {F5677990}
      
      Reviewers: DrSlony, rkflx
      
      Reviewed By: rkflx
      
      Subscribers: muhlenpfordt, rempt, behrmann
      
      Differential Revision: https://phabricator.kde.org/D10076
      338ffeee
  2. 26 Jan, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Fix issues with clicking directories in tree view · 8a6a4ea6
      Peter Mühlenpfordt authored
      Summary:
      Selecting another directory in tree while showing an image in view mode,
      opens the first image from the selected directory in view mode. If the
      folder contains subfolders, gwenview selects the first one and switches
      to browse mode.
      This patch changes selection of first **item** back to first **image**
      (introduced in D8934) to fix this and toggles between browse/view mode
      only after clicking the already selected directory in tree.
      Additionally a trailing slash is stripped from the current dir url in
      context manager to fix a failing compare to initially stored dir url.
      
      BUG: 306835
      
      Test Plan:
      1. Open image in view mode
      2. Click on another directory in tree view
      -> Should view the first image in new directory
      
      1. Open image in view mode
      2. Click multiple times on the same directory in tree view
      -> Should toggle browse/view mode
      
      Reviewers: rkflx
      
      Reviewed By: rkflx
      
      Subscribers: ngraham, rkflx
      
      Differential Revision: https://phabricator.kde.org/D9886
      8a6a4ea6
  3. 22 Jan, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Add browse mode action to action collection again · 5bcb8cc9
      Peter Mühlenpfordt authored
      Summary:
      The browse mode action with default shortcut {nav Esc} is not added to action collection (removed in D5824) and therefore not visible/changeable in {nav Settings > Configure Shortcuts}.
      Using {nav Esc} as shortcut for e.g. Quit does not work.
      This patch re-adds the browse mode action to action collection, but also checks for `ShortcutOverride` events to handle active tool dialogs.
      
      BUG: 385242
      
      Test Plan:
      1. Open gwenview
      2. Set alternate shortcut {nav Esc} in {nav Settings -> Configure Shortcuts} for Quit command
      3. Press {nav Esc}
      -> Should exit gwenview
      
      If tool dialog (crop, red eye reduction) is active, pressing {nav Esc} should not exit gwenview, but the tool dialog first.
      
      Reviewers: cfeck, rkflx, ngraham
      
      Reviewed By: rkflx, ngraham
      
      Subscribers: ngraham
      
      Differential Revision: https://phabricator.kde.org/D9943
      5bcb8cc9
  4. 09 Jan, 2018 1 commit
    • __ __'s avatar
      Rename setTargetUrl to setTargetDirUrl · d371a8e6
      __ __ authored
      This change was initially meant to be part of D8785, but had been backed
      out due to concerns about breaking source compatibility. Meanwhile, in
      D8785#176817 it was determined that SC/BC most likely won't be an issue
      in Gwenview because of no other users of the code.
      
      Therefore we now can rename a couple of methods and variables to better
      reflect what they are about, improving readability.
      d371a8e6
  5. 07 Jan, 2018 3 commits
    • __ __'s avatar
      4a337249
    • __ __'s avatar
      Fix failing PlaceTreeModelTest autotest · e8d799c9
      __ __ authored
      Since Frameworks 5.41, `PlaceTreeModelTest` would fail. Bisecting shows
      this has been caused by 7eb6333bdb48 in KIO ("Added baloo urls into
      places model"), where the model now returns 4 additional entries for
      "Recently Saved" and another 4 entries for "Search For".
      
      While the fix is trivially done by changing the number of expected
      items, in a way the test functioned as a canary for problems deeper in
      the code. In particular it uncovered problems when accessing the newly
      added virtual folders as well as various usability issues. Some of those
      are fixed already (50e6fa3f and 86d75454), but there is still
      some work left to do.
      
      BUG: 387824
      
      Test Plan: `placetreemodeltest` does not fail with KF 5.41 anymore,
      still works with KF 5.40.
      e8d799c9
    • __ __'s avatar
      Respect custom filename for Copy/Move/Link To operations · 119ac418
      __ __ authored
      In `copyMoveOrLink`, 9056aa94 needed to strip the filename from
      `destUrl`. However, this was done before the actual file operation had
      been started, resulting in those being performed using the new target
      directory, but with the old filename instead of a user-provided new
      filename.
      
      This regression can be fixed by moving the stripping after starting the
      KIO job, because setting a new `targetUrl` in `contextManager` will only
      be needed at a later point, i.e. when persisting this path to the
      config.
      
      BUG: 388144
      FIXED-IN: 17.12.1
      
      Test Plan: {nav File > Copy To}, enter custom filename, verify image is
      copied to new path with new filename. Operations on multiple images
      still work, as well as remembering the last used target directory in
      both cases.
      119ac418
  6. 05 Jan, 2018 1 commit
  7. 04 Jan, 2018 1 commit
  8. 03 Jan, 2018 2 commits
  9. 21 Dec, 2017 1 commit
  10. 20 Dec, 2017 3 commits
  11. 19 Dec, 2017 2 commits
  12. 17 Dec, 2017 2 commits
    • __ __'s avatar
      a8e44bf4
    • Peter Mühlenpfordt's avatar
      Update titlebar after image modification · 5a7d105a
      Peter Mühlenpfordt authored
      Summary:
      In some cases the titlebar information (filename, size, zoom) is lost after an image has been modified.
      This patch fixes the caption update and thereby also the missing `*` on modified images.
      
      BUG: 345980
      
      Test Plan:
      Case 1:
      1. Open image in view mode, which fits in window (100% zoom)
      2. Scale (Shift-R) or crop (Shift-C) image
      -> Titlebar info is lost
      
      Case 2:
      1. Open big image in view mode, which is zoomed to fit in window
      2. Scale image with Shift-R (do not save)
      3. Go to another big image (zoomed to fit)
      3. Scale image with Shift-R
      -> Titlebar info is lost
      
      Reviewers: rkflx
      
      Reviewed By: rkflx
      
      Subscribers: ngraham
      
      Differential Revision: https://phabricator.kde.org/D9293
      5a7d105a
  13. 16 Dec, 2017 2 commits
  14. 06 Dec, 2017 3 commits
  15. 05 Dec, 2017 2 commits
  16. 04 Dec, 2017 3 commits
  17. 30 Nov, 2017 1 commit
  18. 28 Nov, 2017 4 commits
  19. 27 Nov, 2017 1 commit
  20. 20 Nov, 2017 1 commit
  21. 17 Nov, 2017 2 commits
  22. 13 Nov, 2017 2 commits