1. 29 Apr, 2021 1 commit
    • Arjen Hiemstra's avatar
      Prefer mime type from content over file name when loading · 6a79391a
      Arjen Hiemstra authored
      QMimeDatabase::mimeTypeForFileNameAndData() will prefer using the
      filename for mime type determination. This allow it to be fooled when
      the filename is something different than the contents. To avoid this,
      reverse the logic and first try to determine the mimetype from the
      file's contents and only use filename if that fails.
      
      BUG: 329140
      6a79391a
  2. 17 Nov, 2020 1 commit
  3. 09 Jan, 2020 1 commit
  4. 07 Jul, 2019 1 commit
    • Tom Moebert's avatar
      Fix MIME type not determined for small files · d89a2e91
      Tom Moebert authored and Nate Graham's avatar Nate Graham committed
      Summary: Previously, LoadingDocumentImplPrivate::determineKind() was never called for files < HEADER_SIZE when transferred via KIO, which prevented to load them correctly.
      
      Test Plan: Modify LoadingDocumentImpl::init() to make it always load files via KIO. Compile and execute `documenttest`. Before the fix it will be stuck in an endless loop. Afterwards it completes normally.
      
      Reviewers: #gwenview, ngraham
      
      Reviewed By: #gwenview, ngraham
      
      Subscribers: ngraham, #gwenview
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D22305
      d89a2e91
  5. 24 May, 2019 1 commit
    • Tom Moebert's avatar
      Remove redundant QImage::loadFromData() · 53105ea9
      Tom Moebert authored and Nate Graham's avatar Nate Graham committed
      Summary: The only purpose of this call is to check whether an embedded preview image of a RAW file is smaller than an (arbitrarily chosen) threshold. If this were true, it would be pointless to ask for an image that is only half as big as the one already retrieved.
      
      Reviewers: #gwenview, ngraham
      
      Reviewed By: #gwenview, ngraham
      
      Subscribers: ngraham, #gwenview
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D21285
      53105ea9
  6. 15 May, 2019 1 commit
    • Tom Moebert's avatar
      Fix incomplete EXIF data for RAW files · a985ad14
      Tom Moebert authored and Nate Graham's avatar Nate Graham committed
      Summary:
      In case of RAW files exiv2 retrieved the EXIF data from the JPEG preview
      image `previewData`. This however contains incomplete EXIF data. Thus
      provide exiv2 with the full raw image and let it find the most suitable
      EXIF data chunk.
      
      BUG: 346510
      
      Reviewers: #gwenview, ngraham
      
      Reviewed By: #gwenview, ngraham
      
      Subscribers: ngraham
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D21161
      a985ad14
  7. 13 Jan, 2019 1 commit
  8. 01 Jan, 2019 1 commit
    • Stefan Brüns's avatar
      Use forward declaration for Exiv2::Image, port to std::unique_ptr · 61543b42
      Stefan Brüns authored
      Summary:
      Instead of the Exiv2::Image::AutoPtr typedef just use a forward declaration
      for Exiv2::Image, and use std::unique_ptr instead of std::auto_ptr.
      
      The forward declaration avoids pulling in Exiv2 declarations everywhere,
      e.g. via document.h.
      
      Although it would be possible to use std::auto_ptr, unique_ptr is
      preferable for two reasons:
      - ownership transfer is explicit (std::move, release()/reset())
      - Exiv2 0.28 will use std::unique_ptr as well, i.e. the code is forward
      compatible.
      
      Reviewers: #gwenview, cfeck, ngraham
      
      Reviewed By: #gwenview, ngraham
      
      Subscribers: lbeltrame, ngraham, asturmlechner, shubham
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D17872
      61543b42
  9. 04 Sep, 2018 1 commit
  10. 26 Jul, 2018 1 commit
  11. 22 Jan, 2017 2 commits
  12. 26 May, 2016 1 commit
  13. 31 Mar, 2015 1 commit
  14. 22 Mar, 2015 1 commit
  15. 21 Nov, 2014 1 commit
  16. 13 Oct, 2014 1 commit
  17. 10 Oct, 2014 2 commits
  18. 05 Oct, 2014 1 commit
  19. 03 Oct, 2014 1 commit
  20. 13 Aug, 2014 2 commits
  21. 19 Nov, 2013 1 commit
    • Aurélien Gâteau's avatar
      RAW preview in gwenview · 97d250f3
      Aurélien Gâteau authored
      It uses KDcraw to extract the embedded jpeg preview (most of the raw formats
      contain it for the purposes of quick viewing the photos on the camera display)
      or loads half-scaled preview (otherwise) so it is fast, implementing was quite
      easy and theoretically it enables gwenview to support everything dcraw supports
      (I haven't found a raw file that gwenview doesn't show with this patch). The
      patch does not perform full demosaicing nor any tweaks (set white balance or so)
      and I don't think it shall - digikam, darktable or rawtherapee are much more
      suited for developing the 'digital negatives'.
      
      The patch enables support for Nikon NEF and NRW formats, Canon's CR2 and CRW,
      Pentax PEF, Sony ARW, Fuji RAF, Olympus ORF, Minolta MRW, Panasonic RW2, Samsung
      SRW and Adobe DNG. If you want to try another format, just adding its MIME type
      to the list in lib/mimetypeutils.cpp shall be enough.
      
      The patch is feature-complete (generating proper thumbnails and viewing the raw
      images incl. EXIF metadata) and well usable.
      
      BUG: 158788
      REVIEW: 113397
      97d250f3
  22. 16 May, 2013 1 commit
  23. 25 Jan, 2013 1 commit
  24. 24 Jan, 2013 1 commit
  25. 22 Jan, 2013 2 commits
  26. 18 Jan, 2013 1 commit
  27. 21 Nov, 2012 1 commit
  28. 11 Sep, 2012 2 commits
  29. 06 Sep, 2012 1 commit
  30. 15 Jul, 2012 1 commit
  31. 04 Jul, 2012 1 commit
  32. 22 Jun, 2012 1 commit
  33. 09 Jun, 2012 1 commit
  34. 26 Mar, 2012 1 commit
  35. 16 Dec, 2011 1 commit