1. 09 Apr, 2018 1 commit
    • Huon Imberger's avatar
      Add support for configurable transparent background to SVGs · 836ec0e4
      Huon Imberger authored
      Summary:
      SVGs do not honor the "Transparent background" config option, and simply have no
      background at all. This patch ensures this option is applied to SVGs as well as
      raster images.
      
      Unlike `RasterImageView` that uses a `QPixmap` buffer (`mCurrentBuffer`) for drawing
      the background and the image, SVGs are rendered directly on top of `SvgImageView`
      (`QGraphicsWidget`). Therefore we just paint the background in `SvgImageView::paint`
      which happens before the SVG is rendered.
      
      We move the checkboard texture code to `AbstractImageView` now that it's used by
      both subclasses `RasterImageView` and `SvgImageView`.
      
      This patch also configures kconf_update due to the moving of the above enum.
      Since I didn't want to litter `/app` with files, I've moved the update files to
      `/kconf_update`.
      
      Fixes T8125
      
      Before:
      {F5764298}
      
      After:
      {F5764299}
      {F5764300}
      
      Test Plan:
        - Open an SVG with solid color config option
        - Open and SVG with checkboard background config. At a high enough zoom (where the
          birdseye view shows up), panning/scrolling should have the checkboard pattern
          fixed to the image, like raster images
        - Ensure raster images with transparent backgrounds are unaffected
      
      ## kconf_update
      The script `gwenview-imageview-alphabackgroundmode-update.pl` must be in
      `/usr/share/kconf_update` in order for `/usr/lib/kf5/kconf_update` to find it.
      If successfull, instances of `RasterImageView::AlphaBackground*` should change to
      `AbstractImageView::AlphaBackground*`.
      
      Reviewers: #gwenview, rkflx, ngraham
      
      Reviewed By: #gwenview, rkflx, ngraham
      
      Tags: #gwenview
      
      Maniphest Tasks: T8125
      
      Differential Revision: https://phabricator.kde.org/D11629
      836ec0e4
  2. 14 Feb, 2018 1 commit
  3. 29 Jan, 2018 1 commit
    • Nathaniel Graham's avatar
      Add a user-facing control to choose the ICC color rendering intent · 338ffeee
      Nathaniel Graham authored
      Summary:
      FEATURE: 359909
      FIXED-IN: 18.04
      
      Allow the user to choose the ICC color rendering intent, instead of hardcoding INTENT_PERCEPTUAL
      
      Supersedes D8763
      
      Test Plan:
      The GUI control appears and seems to work as intended.
      
      {F5680320}
      
      - Tested that the default value of Perceptual is used when there is no value in ~/.config/gwenviewrc
      - Tested that the value gets set in ~/.config/gwenviewrc
      - Tested that removing the value in ~/.config/gwenviewrc reverts the GUI setting to Perceptual
      - Tested that toggling the setting back and forth actually has an impact when using a display with an active color profile. Here's an example:
      
      Perceptual:
      {F5677933}
      
      Relative Colorimetric:
      {F5677990}
      
      Reviewers: DrSlony, rkflx
      
      Reviewed By: rkflx
      
      Subscribers: muhlenpfordt, rempt, behrmann
      
      Differential Revision: https://phabricator.kde.org/D10076
      338ffeee
  4. 08 Oct, 2016 1 commit
    • Frederik Gladhorn's avatar
      Remove ConfigDialogPrivate · 562cc26f
      Frederik Gladhorn authored
      Gwenview is an app, there is no reason to allocate a private object for
      the data members of the config dialog. Simplify the whole thing.
      562cc26f
  5. 05 Mar, 2015 2 commits
  6. 13 Aug, 2014 3 commits
  7. 07 Aug, 2014 1 commit
    • John Zaitseff's avatar
      Allow different ways to handle zoom and position between images · 5572aded
      John Zaitseff authored
      (Taken from bug #337262 )
      
      Over the years, there has been much discussion about whether the zoom and position should be kept the same between images (see, for example, bug 293103, which I submitted, or bugs 291759, 294915, 321122, 327889, 331412, 334530, 337037 --- there may be more!).  I have even submitted a patch (with bug 293103) which was applied in modified form---thanks!  However, it has been subsequently broken...
      
      I have come to realise that there are THREE main ways people like to have the zoom and position settings applied to successive images:
      
      1. Each image should be opened in Zoom to Fit mode, even if the previous image was zoomed in or out and was panned to a different position.  This is Aurélien Gâteau's preferred mode of operation: call it Autofit zoom mode.
      
      2. The zoom and position settings should be shared across all images.  New images should be opened with the previous image's settings.  If you go back to a previous image (from image B to image A, previously opened), image A's settings should be updated to be those of image B.  This allows you to set zoom and position on an image, then go back and forward to the previous and next image while retaining the settings.  This is MY preferred mode of operation: call it Shared mode.
      
      3. Each image should remember its own zoom and position settings.  New images should be opened with the previous image's position and zoom, but if you then change image B's zoom/position, this is NOT passed back to image A, if you go back to that image.  This is Abhinav Gangwar's preferred mode of operation, and is what LockZoom implements in Gwenview: call it Individual mode.
      
      I think people don't mind Autofit being the default, as long as it can be changed.  At the moment, doing so is very non-obvious, and the Shared mode of operation simply does not exist (as of 12th February 2014).
      
      I am submitting a patch that does the following:
      
      1. Create a config file option "ZoomMode" with ZoomMode::Autofit, ZoomMode::Shared and ZoomMode::Individual being the choices (Autofit is the default, per Aurélien's preferences).
      
      2. Remove the now-obsolete ShowLockZoomButton and LockZoom config options.
      
      3. Remove the Lock Zoom button: it is not visible in Autofit mode anyway, and when a user wants the other modes, they want it on ALL the time, not just some of the time!  Besides, it clutters up the interface :-)
      
      4. Set the zoom and position settings for each image depending on the ZoomMode selected.
      
      5. Add a group of three Zoom Mode radio buttons to the Image Settings configuration dialog page: "Autofit each image", "Shared zoom and position" and "Individual (per-image) zoom and position".  I think adding these radio buttons is the most elegant way for users to change this setting, given how non-obvious the current method is (as can be seen by the continual stream of bug reports!).
      
      REVIEW: 119549
      BUG: 337262
      5572aded
  8. 16 Dec, 2011 1 commit
  9. 07 Dec, 2011 1 commit
  10. 04 Dec, 2011 1 commit
  11. 20 Nov, 2011 1 commit
  12. 18 Nov, 2011 1 commit
  13. 28 Oct, 2011 1 commit
  14. 15 Oct, 2011 1 commit
  15. 22 May, 2011 1 commit
  16. 22 Sep, 2010 1 commit
  17. 09 May, 2009 1 commit
  18. 26 Apr, 2009 2 commits
  19. 28 Mar, 2009 1 commit
  20. 01 Oct, 2008 2 commits
  21. 24 Jun, 2008 1 commit
  22. 23 Feb, 2008 1 commit
  23. 15 Feb, 2008 1 commit
  24. 02 Feb, 2008 1 commit
  25. 13 Jan, 2008 1 commit
  26. 12 Jan, 2008 1 commit
  27. 09 Jan, 2008 1 commit
  28. 23 Dec, 2007 1 commit
    • Laurent Montel's avatar
      Fix include · aa1861d2
      Laurent Montel authored
      svn path=/trunk/KDE/kdegraphics/gwenview/; revision=752121
      aa1861d2
  29. 28 Nov, 2007 1 commit
  30. 08 Nov, 2007 1 commit
  31. 26 Sep, 2007 1 commit
  32. 18 Sep, 2007 2 commits
  33. 30 Jun, 2007 1 commit
  34. 08 Jun, 2007 1 commit
    • Stephan Kulow's avatar
      fix linking · 58954174
      Stephan Kulow authored
      svn path=/trunk/KDE/kdegraphics/gwenview/; revision=672826
      58954174