1. 01 Jul, 2021 1 commit
  2. 11 Jun, 2021 1 commit
  3. 30 Dec, 2020 1 commit
  4. 09 Dec, 2020 1 commit
  5. 17 Nov, 2020 2 commits
  6. 16 Jul, 2020 1 commit
  7. 07 Jun, 2020 1 commit
  8. 03 Jun, 2020 1 commit
  9. 27 May, 2020 1 commit
  10. 16 Mar, 2020 1 commit
  11. 12 Aug, 2019 1 commit
  12. 20 Jan, 2019 2 commits
  13. 13 Jan, 2019 1 commit
  14. 28 Sep, 2018 1 commit
  15. 18 Aug, 2018 1 commit
  16. 02 Aug, 2018 1 commit
    • __ __'s avatar
      Disable setImageData for dragging of unmodified images · c61693cc
      __ __ authored
      Summary:
      3bb8beb5 and 984b9737 led to Gwenview adding the raw image data
      to the mimedata used when dragging or copying images. In general that's
      fine and sometimes even needed (e.g. when pasting to GIMP).
      
      However, when dragging to the Plasma desktop to copy the image or set it
      as a wallpaper, the drag cursor would stutter and only change to the
      green accepting cursor when hovering for a while. Furthermore, upon
      dropping the image the context menu presenting the actions would take a
      very long time showing up. This is caused by requesting a deep copy of
      the mimedata in `kdeclarative`, resulting in the conversion of the image
      data to all image formats Qt supports (for details, see D13249#300894).
      
      The same problem can be observed when trying to drop an image to
      Chromium, which does not work at all.
      
      Therefore we change `selectionMimeData` to only set the URL for dragging
      unmodified images, which solves the issue both for Plasma and for
      Chromium. (For modified images the problem persists, but it is
      considered more important to provide the modified image data in this
      case for applications supporting it.)
      
      Test Plan:
      In both {nav Browse} and {nav View} mode, drag images to the desktop.
      The context menu should appear swiftly. Also, the behaviour for copying
      and dragging in all other cases should work as specified in the added
      comment.
      
      Reviewers: #gwenview, muhlenpfordt
      
      Reviewed By: #gwenview, muhlenpfordt
      
      Differential Revision: https://phabricator.kde.org/D14543
      c61693cc
  17. 02 Jun, 2018 1 commit
    • __ __'s avatar
      Refactor determining mime data for selection · 7c43f583
      __ __ authored
      Summary:
      Both copying and drag-and-drop of images requires adding appropriate
      mime data to the clipboard and drag handler respectively.
      
      f365a38f implemented support for copying modified images. To be able
      to also support drag-and-drop of modified images without having to
      duplicate code, we extract the relevant bits into a standalone helper
      function.
      
      As in different places the selection is determined either by Qt's
      internal models, `contextManager` or a single document, and we don't
      have access to the global selection in `contextManager` everywhere, we
      standardize on a `KFileItemList` to pass the selection.
      
      While at it, we slightly improve some comments.
      
      Test Plan:
      Make sure that copying both unmodified and modified images of various
      filetypes works as before and in all modes, in particular {nav Browse},
      {nav View} and {nav Compare} (for details, see test plan of
      f365a38f).
      
      Reviewers: #gwenview, muhlenpfordt
      
      Reviewed By: #gwenview, muhlenpfordt
      
      Differential Revision: https://phabricator.kde.org/D13248
      7c43f583
  18. 25 May, 2018 1 commit
    • __ __'s avatar
      Refine behaviour for copying modified images to external applications · f365a38f
      __ __ authored
      Summary:
      In b94861f2 copying images for pasting into other applications was
      added for cases where only adding the URL to the clipboard was not
      enough, e.g. for GIMP. This was done by adding a raster based
      representation to the mime data.
      
      However, for modified (e.g. cropped) images, the pasted result would
      depend on whether the external application used the original URL
      containing the unmodified image, or the updated raster data. This was
      confusing for the user, and for example for Dolphin pasting the modified
      image was not possible at all.
      
      This patch modifies the mime handling so that pasting the modified image
      - works in Dolphin
      - does not require extra steps in LibreOffice
      - is disabled for applications only supporting handling of the unmodified URL (i.e. users have to save the image first)
      
      Test Plan:
      Press {key Ctrl C} in Gwenview and paste to the target for every combination of:
      - Source: JPG, PNG, NEF, SVG
      - Regular and {nav Cropped} copy for every source file format
      - Target: Dolphin, GIMP, LibreOffice, Inkscape, Firefox, Kate
      Copying and pasting non-image files and multiple images should work as before and produce no warnings.
      
      Reviewers: #gwenview, muhlenpfordt
      
      Reviewed By: #gwenview, muhlenpfordt
      
      Subscribers: muhlenpfordt
      
      Differential Revision: https://phabricator.kde.org/D13028
      f365a38f
  19. 21 May, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Copy raster image and SVG content to clipboard · b94861f2
      Peter Mühlenpfordt authored
      Summary:
      The normal `Copy`/`Cut` options ({key Ctrl C}/{key Ctrl X}) copy the
      url(s) of the selected file(s)/folder(s) to the clipboard.
      This patch additionally copies raster image and SVG content of the
      current document to the clipboard. In Browse Mode the content is
      copied only if a single file is selected.
      
      FEATURE: 290294
      
      Test Plan:
      # Open raster image or SVG in Gwenview
      # {nav Edit > Copy} or {key Ctrl C} to copy image to clipboard
      # Paste image to different applications (e.g. gimp, office writer,
        facebook chat in web browser, inkscape, etc.)
      # Cut&Paste should only move the file if pasted to file manager
        applications (e.g. dolphin)
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: huoni, rkflx, ngraham
      
      Differential Revision: https://phabricator.kde.org/D12871
      b94861f2
  20. 20 May, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Update paste action on current directory and selection changes · 358ff25a
      Peter Mühlenpfordt authored
      Summary:
      The paste action is disabled on Gwenview start. This is caused by
      initializing the action state before setting the current directory
      url in `ContextManager`. The state updates only on clipboard changes
      and does not reflect the current permissions to paste into a folder.
      This patch updates the paste action state on changing the directory
      and the selection, which both affect the paste destination.
      
      BUG: 276255
      FIXED-IN: 18.04.2
      
      Test Plan:
      # Copy url(s) to clipboard (e.g. from `Dolphin`)
      # Open Gwenview in Browse Mode
      # Check if {nav Edit > Paste...} is enabled on startup
      # Check if {nav Edit > Paste...} is disabled in non-writable folders
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx, huoni
      
      Differential Revision: https://phabricator.kde.org/D12902
      358ff25a
  21. 27 Feb, 2018 1 commit
    • Andrew Crouthamel's avatar
      Remove symbolic icons in favor of standard icons · a4b8511d
      Andrew Crouthamel authored and __ __'s avatar __ __ committed
      Summary:
      This removes -symbolic icons in favor of theme-neutral standard icon names to ensure compatibility.
      
      Follow-up to efaebe29 as discussed in D10770.
      
      Before:
      {F5729929}
      After:
      {F5729928}
      
      Test Plan: Test Open Containing Folder and Trash menu options to ensure functionality.
      
      Reviewers: #gwenview, rkflx, ngraham
      
      Reviewed By: #gwenview, rkflx, ngraham
      
      Subscribers: rkflx, ngraham
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D10843
      a4b8511d
  22. 25 Feb, 2018 1 commit
    • Silas Lenz's avatar
      Update filename in fullscreen view on rename · 00ee923e
      Silas Lenz authored
      Summary:
      When a file was renamed in fullscreen view the filename displayed in InformationLabel was not updated until you navigated to another image and back. This was  caused by the current url not being updated, which also resulted in edits and saves affecting the wrong image. This patch fixes the missing url update. Also makes full screen thumbnailBar scroll to the new file similar to other thumbnailviews.
      
      BUG: 390332
      Closes T8071
      
      Test Plan:
      Case 1:
      1. Open image in fullscreen view.
      2. Rename image using F2 or right click menu.
      3. Verify that all visible filenames are updated, and that navigation between images still work.
      
      Case 2:
      1. Open image in normal view.
      2. Rename image using F2 or Operations sidebar.
      3. Verify that all visible filenames are updated, and that navigation between images still work.
      
      Case 3:
      1. Select image thumbnail in browse view.
      2. Rename image using F2 or right click menu.
      3. Verify that all visible filenames are updated, and that the image is still selected.
      
      Reviewers: #gwenview, muhlenpfordt
      
      Reviewed By: #gwenview, muhlenpfordt
      
      Subscribers: rkflx, muhlenpfordt
      
      Tags: #gwenview
      
      Maniphest Tasks: T8071
      
      Differential Revision: https://phabricator.kde.org/D10745
      00ee923e
  23. 22 Feb, 2018 1 commit
    • Andrew Crouthamel's avatar
      Add icons for context and sidebar menu · efaebe29
      Andrew Crouthamel authored and Nate Graham's avatar Nate Graham committed
      Summary:
      [[ https://phabricator.kde.org/D10718#210970 | As requested ]] by @rkflx, menu icons have been added for the context and sidebar menus, continuing the work completed in D10503.
      
      Operations Sidebar Before:
      {F5725605}
      Operations Sidebar After:
      {F5725888}
      Context Before:
      {F5725571}
      Context After:
      {F5725928}
      Trash Context Before:
      {F5725573}
      Trash Context After:
      {F5725574}
      
      Test Plan: Execute Gwenview, perform moves/copies/links/redeye actions. Verify icon resolution and appropriateness.
      
      Reviewers: #gwenview, ngraham, rkflx
      
      Reviewed By: #gwenview, ngraham, rkflx
      
      Subscribers: muhlenpfordt, ngraham, rkflx
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D10726
      efaebe29
  24. 30 Jan, 2018 1 commit
  25. 06 Dec, 2017 1 commit
    • Peter Mühlenpfordt's avatar
      Update selection after renaming a file · afbad38a
      Peter Mühlenpfordt authored and __ __'s avatar __ __ committed
      Summary:
      After a file is renamed, update selection in `ContextManager` to reference new filename.
      Without this patch the window title is not updated after rename an a reload with F5 fails.
      
      BUG: 249001
      
      Test Plan:
      1. Open a picture in Gwenview (single image view mode)
      2. Press F2 and rename the picture -> window title should be updated to new name
      3. Press F5 to reload picture -> image should still be viewed
      
      Reviewers: ngraham, rkflx
      
      Reviewed By: ngraham, rkflx
      
      Differential Revision: https://phabricator.kde.org/D9161
      afbad38a
  26. 09 Nov, 2017 1 commit
    • Valeriy Malov's avatar
      Try to keep ContextManager in sync with viewed files in MainWindow · b55420b2
      Valeriy Malov authored
      Summary:
      ContextManager now is responsible for switching to the directory
      containing requested URL and selecting it. However, if it is not
      possible, URL is still kept (in case of remote URLs), while selection is
      cleared (to avoid dragging in local files)
      
      MainWindow now relies on ContextManager's selection and/or
      selectedFileItemList instead of ThumbnailView selection. If selection &
      currentUrl are empty, refuse to open View tab, otherwise display
      selected items.
      
      This should prevent (reduce?) the amount of mismatches between which
      files user sees, and which files are being operated upon
      (e.g. by FileOpsContextManagerItem)
      
      BUG: 355493
      BUG: 275807
      BUG: 326190
      BUG: 306835
      
      Test Plan:
      Tried playing around to make sure it doesn't break any old behaviour
      Tried deleting all image files while in View mode, to make sure we back out when we run out of images
      Tried opening an http url and check that operations apply to it unless we select something in browse tab
      And then remote image should be unloaded from the View tab since our actions will now affect user-selected items
      
      Tests pass but they don't seem to cover this?
      
      Reviewers: #kde_applications, gateau, rkflx
      
      Reviewed By: gateau, rkflx
      
      Subscribers: ngraham, rkflx, gateau
      
      Differential Revision: https://phabricator.kde.org/D8196
      b55420b2
  27. 14 Oct, 2017 1 commit
    • Rodrigo Pelorosso's avatar
      Add option to show file in File Manager · 1db8e895
      Rodrigo Pelorosso authored and Nate Graham's avatar Nate Graham committed
      Summary:
      This patch adds an option to show the selected file(s), or the file currently being viewed in the file browser. It opens the default file browser and highlights the files.
      
      {F5428928}
      {F5428927}
      
      Test Plan:
        - Select a file and right click on it, opening the contextual menu. Select the "Show in File Manager" option. The default file manager should open and highlight the file.
        - While viewing a file, right click on it, opening the contextual menu. Select the "Show in File Manager" option. The default file manager should open and highlight the file.
      
      It also shows the option under the File menu.
      
      Reviewers: ngraham, #kde_applications, rkflx
      
      Reviewed By: ngraham, rkflx
      
      Subscribers: rkflx, ngraham
      
      Differential Revision: https://phabricator.kde.org/D8282
      1db8e895
  28. 18 Aug, 2017 1 commit
  29. 14 May, 2017 1 commit
    • __ __'s avatar
      Port more deprecated functions and fix warnings · c8ee79a7
      __ __ authored and Luigi Toscano's avatar Luigi Toscano committed
      Summary:
      KFileItem(mode, permissions, ...) is deprecated.
      Port deprecated KRun::run to KRun:runService.
      Replace deprecated std::auto_ptr with std::unique_ptr.
      Add Q_DECL_OVERRIDE to MainWindow::eventFilter.
      
      Depends on D5750
      Depends on D5751
      
      Test Plan: Tests pass.
      
      Reviewers: ltoscano, sandsmark, gateau
      
      Reviewed By: gateau
      
      Differential Revision: https://phabricator.kde.org/D5752
      c8ee79a7
  30. 10 Feb, 2017 1 commit
  31. 29 Dec, 2016 2 commits
  32. 08 Oct, 2016 1 commit
  33. 31 Oct, 2014 1 commit
  34. 23 Oct, 2014 1 commit
  35. 21 Oct, 2014 1 commit
  36. 20 Oct, 2014 1 commit
  37. 19 Oct, 2014 1 commit