1. 06 Apr, 2020 1 commit
    • Martin Tobias Holmedahl Sandsmark's avatar
      Don't fill disk with thumbnails if thumbnail saving is turned off · a585df06
      Martin Tobias Holmedahl Sandsmark authored
      Even if "low resource usage mode" is turned on, which says it avoids
      storing thumbnails to disk to save space, it still stores thumbnails to
      disk. It just deletes _all_ thumbnails afterwards (even those not from
      gwenview itself).
      
      This was also kind of racy, because thumbnailwriter could still be
      running, but the folders would be deleted, so it spammed a ton of error
      messages.
      
      Test Plan:
      Doesn't store thumbnails when it shouldn't anymore, doesn't
      delete thumbnails from other applications nor the thumbnail folders,
      thumbnailwriter doesn't spaz out during exit, stores thumbnails when it
      should.
      
      Differential Revision: https://phabricator.kde.org/D28375
      a585df06
  2. 27 Mar, 2020 1 commit
  3. 17 Mar, 2020 1 commit
    • Nate Graham's avatar
      Give Exit Full Screen and Configure buttons text and adjust wording · 435d2ad1
      Nate Graham authored
      Summary:
      Unlike Kate, Gwenview's {nav Exit Full Screen} button is icons-only, impeding
      discoverability. This patch shows its action's text, and adjusts that text to be more
      consistent with the typical wording.
      
      In the process, the button below it is also given visible text to avoid making it look
      odd in its layout.
      
      To accomplish this technically, the `FullScreenToolBar` class's `addAction()` function
      is given a new optional parameter for specifying if and where the button's text should
      appear, which is then used to give the aforementioned buttons visible text according to
      the user's toolbutton text display preferences. The actions are also no longer marked
      with the Low Priority status, which forces them to be always icons-only and was
      previously redundant since icons-only status was forced in a different way. Fixed now.
      
      BUG: 385314
      FIXED-IN: 20.04.0
      
      Test Plan: {F8176526}
      
      Reviewers: #gwenview, #vdg, broulik
      
      Reviewed By: broulik
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D28052
      435d2ad1
  4. 16 Mar, 2020 1 commit
  5. 20 Feb, 2020 1 commit
  6. 03 Feb, 2020 2 commits
  7. 09 Jan, 2020 2 commits
  8. 06 Jan, 2020 1 commit
  9. 28 Dec, 2019 1 commit
  10. 26 Dec, 2019 1 commit
    • Madhav Kanbur's avatar
      Add button to toggle sidebar in fullscreen mode · db6ca614
      Madhav Kanbur authored
      Summary:
      Previously, there was no way to toggle the sidebar in
      fullscreen view mode except for the keyboard shortcut F4. This patch
      adds a button to toggle the sidebar from the fullscreen toolbar.
      BUG: 414694
      
      Test Plan:
      Tested the button in fullscreen (view) mode. Button works
      as expected, and preserves existing behavior of all other sidebar
      toggle mechanisms as well.
      
      Reviewers: #vdg, #gwenview, ngraham
      
      Subscribers: #gwenview
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D26230
      db6ca614
  11. 07 Dec, 2019 1 commit
  12. 05 Dec, 2019 1 commit
  13. 03 Dec, 2019 1 commit
  14. 23 Nov, 2019 1 commit
  15. 11 Nov, 2019 1 commit
  16. 10 Nov, 2019 1 commit
  17. 20 Oct, 2019 1 commit
  18. 13 Oct, 2019 1 commit
  19. 02 Oct, 2019 1 commit
    • Felipe Peter's avatar
      Change UI for setting jpeg quality to slider · 1a2623d9
      Felipe Peter authored
      Summary:
      [[ https://phabricator.kde.org/D23106 | D23106 ]] added a spinner box to set a save quality for JPEG images. I changed it to a slider to be consistent with the same functionality in Spectacle, but I didn't use the ticks because it makes the slider me misaligned with the respective label. Also, I used % as the label unit. I think it is more clear and will therefore propose the same for Spectacle.
      
      I did not really understand how in the [[ https://phabricator.kde.org/D23106 | original commit ]] the value from the spinner box was saved to the config, so I set it explicitly when the slider value changes.
      
      Test Plan:
      Set high quality in settings, don't change in save dialog -> Output image has high quality
      Set high quality in settings, override in save dialog with low quality -> Output image has low quality
      Set low quality in settings, don't change in save dialog -> Output image has low quality
      Set low quality in settings, override in save dialog with high quality -> Output image has high quality
      
      Reviewers: ngraham, #vdg, #gwenview
      
      Reviewed By: ngraham, #vdg, #gwenview
      
      Subscribers: #spectacle
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D24309
      1a2623d9
  20. 18 Sep, 2019 1 commit
  21. 10 Sep, 2019 2 commits
  22. 06 Sep, 2019 1 commit
  23. 27 Aug, 2019 1 commit
  24. 24 Aug, 2019 1 commit
    • Nate Graham's avatar
      Allow the user to select the JPEG save/compression quality · 24cd548e
      Nate Graham authored
      Summary:
      Currently, anytime Gwenview is used to save a non-JPEG file as a JPEG, or anytime JPEG file is saved or re-saved after performing a lossy edit (e.g. crop or red eye, but not rotation), the new file is saved with 75% quality level, resulting in a noticeable degradation in appearance.
      
      This patch implements a user-selectable JPEG save/compression quality setting, which can be temporarily overridden in the {nav Save As} dialog when saving a file as a JPEG. The new default quality level is 90% -- same as Spectacle. This should prevent people from accdientally destroying their JPEGs.
      
      As before, when saving an existing JPEG file with a new name or after performing a non-lossy edit (e.g. rotation, which only changes the EXIF rotation tag), the appearance of the file is not changed because no actual image manipulation is done.
      
      FEATURE: 277996
      FIXED-IN: 19.12.0
      
      Test Plan:
      {F7205336}
      
      {F7208763}
      
      Set JPEG quality to 5% in the config file and test the following use cases:
      - Non-JPEG image: do {nav Save} or {nav Save As} in non-JPEG formats -> No changes or regressions.
      - JPEG image: do {nav Save} or {nav Save As} without changing the image format or the image's pixels at all -> No changes; quality level not taken into consideration because these are lossless operations that do not re-compress the image (which is good)
      - JPEG image: do {nav Save} or {nav Save As} after changing the image's pixels in some way (e.g. a crop operation) -> Image is saved with the user-specified 5% quality level and looks terrible
      - JPEG image: do {nav Save As} into a non-JPEG file format after changing the image image's pixels in some way, or not -> No changes or regressions (in particular, lossless images like PNG are not hugely ballooned in file size)
      
      Set JPEG quality to 90% in the config file and test the following use cases:
      - Non-JPEG image: do {nav Save As} in non-JPEG formats -> No changes or regressions; dialog box does not show quality spinbox
      - Non-JPEG image: do {nav Save As} into a JPEG and in the {nav Save As] dialog, change the quality from 90% to 5%-> Image is saved with the user-specified 5% quality level and looks terrible
      - JPEG image: do {nav Save As} into a non-JPEG file format -> No changes or regressions; dialog box does not show quality spinbox
      - JPEG image: do {nav Save As} after changing the image's pixels in some way (e.g. a crop operation), and in the {nav Save As] dialog, change the quality from 90% to 5%-> Image is saved with the user-specified 5% quality level and looks terrible
      
      Reviewers: #gwenview, #vdg
      
      Subscribers: filipf, pino
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D23106
      24cd548e
  25. 12 Aug, 2019 1 commit
  26. 07 Aug, 2019 1 commit
  27. 31 Jul, 2019 2 commits
  28. 20 Jul, 2019 1 commit
  29. 18 Jul, 2019 1 commit
  30. 16 Jul, 2019 1 commit
  31. 06 Jul, 2019 1 commit
    • Christoph Feck's avatar
      Make KF5Purpose dependency optional · 8284074a
      Christoph Feck authored
      Purpose dependency drags in glib packages, such as libaccounts and libsignon.
      
      Purpose is also optional in Plasma, Okular, and Spectacle.
      
      Test Plan:
      Tested with both purpose-devel dependency installed and not installed
      (only Share > Sent via Email... was tested).
      
      Reviewers: #gwenview, ngraham
      
      Reviewed By: ngraham
      
      Differential Revision: https://phabricator.kde.org/D22251
      8284074a
  32. 01 Jul, 2019 1 commit
  33. 30 Jun, 2019 1 commit
  34. 28 Jun, 2019 1 commit
  35. 25 Jun, 2019 1 commit
  36. 24 Jun, 2019 1 commit