1. 27 Sep, 2017 3 commits
  2. 25 Sep, 2017 2 commits
  3. 22 Sep, 2017 1 commit
  4. 20 Sep, 2017 1 commit
  5. 15 Sep, 2017 1 commit
  6. 10 Sep, 2017 6 commits
    • Alexey Min's avatar
      Merge branch 'Applications/17.08' · 1eaf088d
      Alexey Min authored
      1eaf088d
    • Vangelis Tasoulas's avatar
      Gwenview: suppressed unused interface variables compiler warnings. · 62f9183f
      Vangelis Tasoulas authored
      Summary: Just added a couple of Q_UNUSED and a (void)var in order to suppress some compiler warning due to unused interface variables.
      
      Reviewers: broulik, gateau, lukas, #kde_applications, ngraham, aacid
      
      Reviewed By: #kde_applications, ngraham
      
      Differential Revision: https://phabricator.kde.org/D7731
      62f9183f
    • Albert Astals Cid's avatar
    • Vangelis Tasoulas's avatar
      Fix Gwenview Importer doesn't use date/time from EXIF · 0d5915a1
      Vangelis Tasoulas authored
      Summary:
      Gwenview Importer only uses date/time from the filesystem metadata when renaming imported photos.
      Not the EXIF information that holds the correct date/time that the picture has been taken.
      
      After looking into the code, I found out that the datetime is determined by calling the function 'TimeUtils::dateTimeForFileItem'.
      
      Consequently, the function 'TimeUtils::dateTimeForFileItem' is calling the function 'updateFromExif()' which in turn calls the function 'Exiv2ImageLoader::load' that returns 'false'. Then it falls back at reading the datetime from the filesystem metadata.
      
      After printing out the error messages that cause the function 'Exiv2ImageLoader::load' to return 'false', I found that the Exiv2 error message is 'Failed to read image data' (doesn't help much). However, after I started playing with the size of the 'QByteArray header' (at the line where the file is read) that is passed as an argument to the 'Exiv2ImageLoader::load' function, I observed different errors until I managed to read the exif info from the file properly.
      
      Some example sizes and different reported errors by Exiv2:
      
      65536: Failed to read image data
      66000: JPEG format error, rc = 5
      131072 It reads fine. No error.
      
      Didn't check numbers between 66000 and 131072 in order to find the exact threshold where I don't get a problem/error reading the exif information, but why should gwenview even bother about this number since exiv2 can do the job if we only provide the url (filepath) of the file to the Exiv2::ImageFactory::open() function? I guess exiv2 probably does the image reading in an even more efficient way according to the JPEG (or other) standard specifications (other than passing it a fixed number of bytes from an image as gwenview currently does).
      
      So attached you can find a proposed patch that does exactly that: Adds a second instance of the function "Exiv2ImageLoader::load()" that acceps a "QString filePath" parameter and lets the Exiv2 library to handle the rest based on the given filePath.
      
      BUGS: 383520
      
      Reviewers: gateau, lukas, ngraham, #kde_applications, aacid, broulik
      
      Reviewed By: gateau, ngraham
      
      Subscribers: alexeymin, cfeck
      
      Differential Revision: https://phabricator.kde.org/D7317
      0d5915a1
    • Alexey Min's avatar
      Fix CMake CMP0048 warning about project() without VERSION · 5845112e
      Alexey Min authored
      Raise CMake minimum requirement to 3.0
      5845112e
    • Alexey Min's avatar
      Add .arcconfig · 13626a9f
      Alexey Min authored
      13626a9f
  7. 09 Sep, 2017 4 commits
  8. 05 Sep, 2017 1 commit
  9. 02 Sep, 2017 1 commit
  10. 30 Aug, 2017 1 commit
  11. 18 Aug, 2017 2 commits
  12. 09 Aug, 2017 2 commits
  13. 08 Aug, 2017 1 commit
  14. 30 Jul, 2017 3 commits
  15. 20 Jul, 2017 2 commits
  16. 17 Jul, 2017 2 commits
  17. 15 Jul, 2017 1 commit
  18. 09 Jul, 2017 1 commit
  19. 14 Jun, 2017 2 commits
  20. 09 Jun, 2017 2 commits
  21. 05 Jun, 2017 1 commit