1. 15 Apr, 2021 1 commit
  2. 17 Nov, 2020 1 commit
  3. 23 Oct, 2020 1 commit
  4. 09 Jan, 2020 1 commit
  5. 12 Aug, 2019 1 commit
  6. 26 Jul, 2018 1 commit
  7. 28 Jun, 2018 2 commits
    • __ __'s avatar
      Separate directories and archives when sorting by date · a4c37358
      __ __ authored
      Summary:
      In general, Gwenview sorts directories first, then groups all archives
      behind those and finally displays images. While the separation of images
      worked fine when sorting by {nav Date}, directories and archives were
      mistakenly mixed within a single group for that sorting order.
      
      This is because the special handling for `KDirModel::ModifiedTime` in
      `SortedDirModel::lessThan` does not take into account
      `KDirSortFilterProxyModel::sortFoldersFirst()`. As directories cannot
      come with a shooting date, we can delegate sorting to
      `KDirSortFilterProxyModel::lessThan` which handles the separation of
      directories just fine.
      
      For `SemanticInfoDirModel::RatingRole` the problem could not be
      observed, because  Gwenview did not pass on the rating of directories,
      so both directories being compared had a zero rating and we fell back to
      KDirSortFilterProxyModel::lessThan. Nevertheless, for clarity we make
      the fallback for sorting by rating explicit too.
      
      Depends on D13727
      
      Test Plan:
      In {nav Browse} mode, sort a directory containing directories, archives
      and images by {nav Date} and check the correct grouping (also for
      {nav Descending}).
      
      Reviewers: #gwenview, muhlenpfordt
      
      Reviewed By: #gwenview, muhlenpfordt
      
      Subscribers: muhlenpfordt, faridb
      
      Differential Revision: https://phabricator.kde.org/D13728
      a4c37358
    • __ __'s avatar
      Fix sorting by date in some situations · dfcbaa30
      __ __ authored
      Summary:
      There are two problems when sorting images by {nav Date}:
      
      Since 05f7e069 Gwenview sorts images by shooting date. However, in
      case two images have the same date or when there is no shooting date
      available for a file, no appropriate secondary sorting criterion is
      provided, leading to unexpected sorting results.
      
      8f128306 enabled sorting in {nav Descending} order, but toggling the
      option does not invert the sorting order for images with the same
      shooting date.
      
      Both problems can be fixed by falling back to a secondary sorting
      criterion in case of equal shooting dates. For
      `KDirSortFilterProxyModel::lessThan`, this means sorting by
      `KDirModel::ModifiedTime` and finally by `KDirModel::Name`.
      
      Test Plan:
      Prepare files containing the same shooting date in their metadata, but
      having different filesystem timestamps. {nav View > Sort By > Date}
      should work correctly and toggling {nav Descending} should invert the
      sorting order.
      
      Reviewers: #gwenview, muhlenpfordt
      
      Reviewed By: #gwenview, muhlenpfordt
      
      Subscribers: muhlenpfordt, faridb
      
      Differential Revision: https://phabricator.kde.org/D13727
      dfcbaa30
  8. 23 Jun, 2018 1 commit
    • Farid Boudedja's avatar
      Add possibility to sort by rating · faa19b06
      Farid Boudedja authored and __ __'s avatar __ __ committed
      Summary:
      Gwenview allows to rate images but there is no option to sort images by rating.
      
      Add 'Rating' as a sorting option to Gwenview's SortedDirModel.
      Add 'Rating' to Gwenview's 'Sort By' menu.
      Add 'Rating' to Gwenview's 'Sorting' configuration entry.
      
      Depends on: D13669
      
      FEATURE: 340667
      
      Test Plan:
      - Give specific ratings to some images in Gwenview.
      - Click {nav View > Sort By > Rating}.
      - The images should be sorted according to their ratings.
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: muhlenpfordt, rkflx, broulik
      
      Differential Revision: https://phabricator.kde.org/D13344
      faa19b06
  9. 04 Jun, 2018 1 commit
    • Farid Boudedja's avatar
      Add possibility to sort by descending order · 8f128306
      Farid Boudedja authored and __ __'s avatar __ __ committed
      Summary:
      Gwenview only allows sorting by ascending order. This patch adds the possibility to switch the sorting order to descending.
      It is implemented similarly to the sorting menu in Dolphin.
      The sorting order is also saved into the Gwenview configuration file.
      
      Before:
      {F5878226}
      
      After:
      {F5878227}
      
      FEATURE: 293333
      
      Test Plan:
        - Open a folder which contains images in Gwenview
        - Check 'Descending' in View > Sort By
        - The sorting order will be switched to descending
        - Uncheck 'Descending' in View > Sort By
        - The sorting order will be reverted to ascending
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: muhlenpfordt, rkflx, xyquadrat
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D13213
      8f128306
  10. 06 Dec, 2014 1 commit
  11. 10 Oct, 2014 1 commit
  12. 05 Oct, 2014 1 commit
  13. 03 Oct, 2014 1 commit
  14. 02 Oct, 2014 1 commit
  15. 13 Aug, 2014 4 commits
  16. 18 Sep, 2013 1 commit
  17. 16 Dec, 2011 1 commit
  18. 07 Dec, 2011 1 commit
  19. 18 Nov, 2011 1 commit
  20. 10 Jun, 2011 1 commit
  21. 03 Sep, 2010 1 commit
  22. 30 Mar, 2010 1 commit
  23. 04 Sep, 2009 1 commit
  24. 03 Aug, 2009 1 commit
  25. 02 Jul, 2009 1 commit
  26. 11 Jun, 2009 1 commit
  27. 09 May, 2009 1 commit
  28. 12 Apr, 2009 1 commit
  29. 11 Apr, 2009 1 commit
  30. 17 Nov, 2008 1 commit
  31. 16 Nov, 2008 4 commits
  32. 29 Oct, 2008 2 commits