1. 28 Jun, 2019 1 commit
  2. 22 Jun, 2019 1 commit
    • Nicolas Fella's avatar
      [WIP/RFC] Use Purpose for sharing · d20a1533
      Nicolas Fella authored
      Summary:
      Use Purpose for the sharing menu.
      
      The question is what to do with the old KIPI sharing infrastructure. It covers some services that Purpose doesn't. Getting rid of them without a replacement would probably upset some users. Ideally all KIPI plugins should be ported to Purpose, but that's a huge task.
      
      Test Plan: Open an image, Share it
      
      Reviewers: #gwenview, ngraham
      
      Reviewed By: #gwenview, ngraham
      
      Subscribers: ngraham
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D21468
      d20a1533
  3. 02 May, 2019 1 commit
  4. 08 Apr, 2019 1 commit
  5. 31 Mar, 2019 1 commit
  6. 16 Mar, 2019 2 commits
  7. 19 Feb, 2019 1 commit
    • Nate Graham's avatar
      Allow Gwenview to be able to open .kra (Krita) files · 5ae28dad
      Nate Graham authored
      Summary:
      Add support for opening Krita files.
      
      FEATURE: 337272
      FIXED-IN: 19.04.0
      
      Depends on D19120
      
      Test Plan:
      - Apply the patch and then this one for Krita: D19120
      - Rebuild and install both apps
      - Run `sudo update-desktop-database`
      - Right-click on a .kra file in Dolphin. Krita shows up as the top app to open it, with Gwenview showing up in the "Open With" menu
      
      Reviewers: #gwenview, sitter, cfeck
      
      Reviewed By: sitter
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D19121
      5ae28dad
  8. 18 Feb, 2019 1 commit
  9. 26 Nov, 2018 1 commit
  10. 10 Nov, 2018 1 commit
  11. 09 Nov, 2018 2 commits
  12. 31 Aug, 2018 1 commit
  13. 19 Aug, 2018 1 commit
  14. 13 Aug, 2018 1 commit
    • __ __'s avatar
      Bump QT_MIN_VERSION and KF5_MIN_VERSION · cdd75b6c
      __ __ authored
      Summary:
      28754fa2 broke compiling Gwenview with Qt 5.6:
      ```
      lib/historymodel.cpp: In member function ‘void Gwenview::HistoryModelPrivate::load()’:
      lib/historymodel.cpp:170:72: error: lambda-expression in unevaluated context
               Q_FOREACH(const QString & name, dir.entryList(QStringList() << QStringLiteral("*rc"))) {
      ```
      
      Given that at some point we had to move on to a newer Qt anyway, we
      might as well do that now. Since Qt 5.9 is an LTS release and available
      in the stable versions of major distros [1], it seems like a good fit.
      Okular and Dolphin are already asking for Qt 5.8 too (but Qt 5.8 is
      neither supported nor widely used anymore).
      
      While at it, we also bump the KF5 version, to make testing the oldest
      supported baseline easier and allow for some `#ifdef` cleanup later on.
      Here 5.43 seems like a good choice [2] (Dolphin uses the same version).
      
      [1] https://repology.org/metapackage/qt5-base/versions
      [2] https://repology.org/metapackage/kwidgetsaddons/versions
      
      Test Plan: Should still compile on openSUSE Leap 15.0 and Ubuntu 18.04.
      
      Reviewers: #gwenview, ngraham
      
      Reviewed By: #gwenview, ngraham
      
      Subscribers: ngraham
      
      Differential Revision: https://phabricator.kde.org/D14700
      cdd75b6c
  15. 08 Aug, 2018 1 commit
    • __ __'s avatar
      Undo custom support for ccache · b883cb89
      __ __ authored
      de7b8dd2 added custom CMake code to support compiling with `ccache`,
      however with current CMake versions (since 3.4, which even Ubuntu 16.04
      ships) one can simply use `-DCMAKE_CXX_COMPILER_LAUNCHER=ccache`.
      
      Let's simplify Gwenview's CMake code. If at all, such a feature should
      end up in ECM, but even in the discussions in D7288 and de7b8dd2
      there were doubts about the general usefulness.
      b883cb89
  16. 07 Aug, 2018 1 commit
  17. 06 Aug, 2018 3 commits
  18. 30 Jul, 2018 1 commit
  19. 16 Jul, 2018 2 commits
  20. 07 Jul, 2018 1 commit
  21. 01 Jun, 2018 1 commit
  22. 03 May, 2018 1 commit
    • Huon Imberger's avatar
      Fix dark HUD icons when using light system theme · 3f540441
      Huon Imberger authored
      Summary:
      The HUD widgets are custom and always dark themed. When using a light
      system theme like Breeze, the icons were rendered with a dark color,
      which was bad because it didn't contrast with the dark HUD. This was
      not an issue in full screen mode, because we force the whole of
      Gwenview to use a dark theme, and therefore the icons rendered a light
      color.
      
      This affects:
        # Compare / Light table mode
        # Video controls popup
        # The "You are now viewing the new document" message after Save As
      
      (Other places the HUD is used do not use icons)
      
      So, when setting an icon using `HudButton::setIcon`, this patch now
      re-loads the icon using the `KIconLoader` global instance, setting a
      custom palette with a white foreground color, so the loader loads a
      light icon. `KIconLoader`'s palette is then reset as to not interfere
      with other icons.
      
      BUG: 380257
      FIXED-IN: 18.08.0
      
      Note: we bump KF5 version to 5.39 for `KIconLoader::setCustomPalette`
      and `KIconLoader::resetPalette`.
      
      Compare/Lighttable Before:
      {F5826780, size=full}
      
      Compare/Lighttable After:
      {F5826781, size=full}
      
      Video Controls Before:
      {F5826782, size=full}
      
      Video Controls After:
      {F5826783, size=full}
      
      Save As message Before:
      {F5826784, size=full}
      
      Save As message After:
      {F5826809, size=full}
      
      Test Plan:
      The following have HUD widgets with icons:
        # Compare / Light table mode
        # Video controls popup
        # The "You are now viewing the new document" message after Save As
      
      Note for 3), the HUD only appears for a split second, due to a bug. See
      D9342.
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: muhlenpfordt
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D12595
      3f540441
  23. 02 May, 2018 1 commit
  24. 09 Apr, 2018 2 commits
    • Christoph Feck's avatar
      49ae27e8
    • Huon Imberger's avatar
      Add support for configurable transparent background to SVGs · 836ec0e4
      Huon Imberger authored
      Summary:
      SVGs do not honor the "Transparent background" config option, and simply have no
      background at all. This patch ensures this option is applied to SVGs as well as
      raster images.
      
      Unlike `RasterImageView` that uses a `QPixmap` buffer (`mCurrentBuffer`) for drawing
      the background and the image, SVGs are rendered directly on top of `SvgImageView`
      (`QGraphicsWidget`). Therefore we just paint the background in `SvgImageView::paint`
      which happens before the SVG is rendered.
      
      We move the checkboard texture code to `AbstractImageView` now that it's used by
      both subclasses `RasterImageView` and `SvgImageView`.
      
      This patch also configures kconf_update due to the moving of the above enum.
      Since I didn't want to litter `/app` with files, I've moved the update files to
      `/kconf_update`.
      
      Fixes T8125
      
      Before:
      {F5764298}
      
      After:
      {F5764299}
      {F5764300}
      
      Test Plan:
        - Open an SVG with solid color config option
        - Open and SVG with checkboard background config. At a high enough zoom (where the
          birdseye view shows up), panning/scrolling should have the checkboard pattern
          fixed to the image, like raster images
        - Ensure raster images with transparent backgrounds are unaffected
      
      ## kconf_update
      The script `gwenview-imageview-alphabackgroundmode-update.pl` must be in
      `/usr/share/kconf_update` in order for `/usr/lib/kf5/kconf_update` to find it.
      If successfull, instances of `RasterImageView::AlphaBackground*` should change to
      `AbstractImageView::AlphaBackground*`.
      
      Reviewers: #gwenview, rkflx, ngraham
      
      Reviewed By: #gwenview, rkflx, ngraham
      
      Tags: #gwenview
      
      Maniphest Tasks: T8125
      
      Differential Revision: https://phabricator.kde.org/D11629
      836ec0e4
  25. 02 Apr, 2018 1 commit
  26. 19 Mar, 2018 2 commits
  27. 15 Mar, 2018 1 commit
    • Friedrich W. H. Kossebau's avatar
      Expose slideshow to MPRIS controllers · 9631043c
      Friedrich W. H. Kossebau authored
      Summary:
      Taking the abstraction "Media" in "Media Player Remote Interfacing
      Specification" (MPRIS) into use, a plain slide in a slideshow can be seen
      to be the same as e.g. a still picture in a movie without any sound.
      Following that, a slideshow with pictures and videos as in the UI model
      of Gwenview can be roughly mapped onto the concept of a list of tracks as
      with in the data model of MPRIS.
      
      This patch exposes the list of images/movies in the current folder and
      the related slideshow feature as MPRIS D-Bus object, implementing for a
      start the interfaces
      * "org.mpris.MediaPlayer2"
      * "org.mpris.MediaPlayer2.Player"
      trying to map those to the Gwenview UX closely.
      
      This allows the slideshow and some other navigation to be controlled
      by any MPRIS controllers, which includes e.g.
      * keyboard mediakeys (Play/Pause, Stop, Next, Previous),
        as handled by Plasma MPRIS dataengine
      * KDE Connect media player controller plugin
      
      Additionally the MRPIS D-Bus object is unregistered while the workspace
      lockscreen is activated. Because at least the Plasma lockscreen has
      the feature to show controls for any currently running MPRIS players,
      which for one does not make sense currently for an image player as all
      displays are locked, and then also can be surprising for some users and
      result in data leaks via the image metadata used.
      
      Future:
      The great plan is to enhance the MPRIS spec to also work well for
      presentation-like media shows. So there can and will be cross-app
      rich (remote) controllers also for classical presentation application
      instead of only per-app ones.
      Supporting the existing MPRIS interfaces, even if slightly bending the
      semantics, is a first step into that direction and already adds value
      as it allows reuse of existing MPRIS controllers e.g. for remote control.
      
      So follow-up work will be to also implement the other MPRIS interfaces
      like org.mpris.MediaPlayer2.TrackList, for exposing the whole set of
      "slides". This will enable MPRIS controllers to show the user a complete
      visual list and e.g. navigate directly to a given slide or give a preview
      for the next/previous slides.
      
      CCBUG: 359381
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: mtijink, ngraham, nicolasfella, #kde_connect, rkflx, broulik
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D10972
      9631043c
  28. 01 Mar, 2018 1 commit
  29. 02 Feb, 2018 1 commit
  30. 04 Jan, 2018 1 commit
  31. 19 Dec, 2017 2 commits
  32. 04 Dec, 2017 1 commit