1. 28 Jun, 2019 1 commit
  2. 25 Jun, 2019 1 commit
  3. 22 Jun, 2019 3 commits
  4. 27 Feb, 2019 1 commit
  5. 22 Feb, 2019 1 commit
  6. 04 Feb, 2019 1 commit
  7. 13 Jan, 2019 1 commit
  8. 26 Sep, 2018 1 commit
  9. 10 Sep, 2018 2 commits
  10. 06 Aug, 2018 1 commit
    • __ __'s avatar
      Remove no-ops when adjusting URLs · b630e152
      __ __ authored
      When d760ced7 introduced `dirUrl.adjusted(QUrl::RemoveFilename)` in
      some places, the original code was adapted too, although it should have
      been removed due to not having any effect anymore.
      b630e152
  11. 05 Aug, 2018 1 commit
    • __ __'s avatar
      Remove extra break statements · 4655089f
      __ __ authored
      After a `return`, writing (and reading) `break` is not really needed.
      Let's remove it everywhere (continuing work done in 28754fa2).
      4655089f
  12. 09 Jul, 2018 2 commits
    • __ __'s avatar
      Fix external application menu occasionally slowing down startup · 07a2e7f9
      __ __ authored
      Summary:
      If moving the menubar entries to a button in the window decoration is
      enabled, the bug reporter experiences delays of up to 25 seconds in the
      startup of Gwenview.
      
      Bisecting points to 9631043c, which added MPRIS support through
      providing a D-Bus interface.
      
      While the exact nature of the problem remains unclear due to not being
      reproducible outside of the bug reporter's environment, moving the
      initialization of the MPRIS support after `createGUI` is reported to
      correct the issue. This may be due to avoiding conflicts or races with
      the D-Bus connection, which is used for the MPRIS service, the
      ScreenSaver service and the application menu integration.
      
      Thanks to Duncan for reporting the bug and coming up with a fix.
      
      BUG: 395925
      FIXED-IN: 18.04.3
      
      Test Plan:
      `dbus-send --session --dest=org.mpris.MediaPlayer2.Gwenview --type=method_call /org/mpris/MediaPlayer2 org.mpris.MediaPlayer2.Player.Next` still moves to the next image in Gwenview.
      The external application menu is still working fine.
      
      Reviewers: #gwenview, kossebau
      
      Subscribers: broulik
      
      Differential Revision: https://phabricator.kde.org/D13995
      07a2e7f9
    • Peter Mühlenpfordt's avatar
      Fix QFileDialog::selectUrl() setting initial directory · 49a52e74
      Peter Mühlenpfordt authored
      Summary:
      In D4193 setting the initial directory to the given URL when using
      `QFileDialog::selectUrl()` was removed.
      * This causes {nav File > Open} to not start in the current directory
        but in Gwenviews initial or last set path. In addition, due to
        adding `StripTrailingSlash`, D9886 caused the file dialog to select
        the last subfolder as a file instead of entering it. Both problems
        can be fixed by using `QFileDialog::setDirectoryUrl()` instead of
        `QFileDialog::selectUrl()`.
      * The first problem also occurs in {nav File > Save As}. Until this
        issue is fixed in the libraries an additional
        `QFileDialog::setDirectoryUrl()` is added as workaround.
      
      FIXED-IN: 18.04.3
      
      Test Plan:
      # Open Gwenview
      # Use {nav File > Open} or {nav File > Save As}
      # The file dialog should start in the current directory
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx
      
      Differential Revision: https://phabricator.kde.org/D13795
      49a52e74
  13. 28 Jun, 2018 1 commit
  14. 26 Jun, 2018 1 commit
  15. 02 Jun, 2018 1 commit
    • Huon Imberger's avatar
      Allow dragging files/folders to View mode · 131d2585
      Huon Imberger authored
      Summary:
      Specifically accepts drop events within the viewport of {nav View} mode.
      If a folder that contains images is dropped, it will open that folder
      and remain in {nav View} mode with the first image selected. If the
      folder doesn't contain images, it switches to {nav Browse} mode.
      Dragging multiple items is supported but only the first item is opened.
      
      BUG: 169408
      FIXED-IN: 18.08.0
      
      {F5781556}
      
      Test Plan:
      Test with different image formats, as well as unsupported format (Gwenview
      should display a nice error).
      Test with folder (with and without images within).
      {nav Browse} mode and the {nav Thumbnail Bar} drag drop should work as before.
      Drop operations should not be accepted anywhere else in the GUI where they aren't
      already supported. In other words, this should only add drop functionality to the
      {nav View} viewport.
      
      Ensure drops are only accepted for URL mimetypes (e.g. ignore text).
      
      Reviewers: #gwenview, rkflx, ngraham
      
      Reviewed By: #gwenview, rkflx
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D11879
      131d2585
  16. 29 May, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Add system "Home" shortcuts as default for opening Start Page · cec36220
      Peter Mühlenpfordt authored
      Summary:
      There's no default shortcut for opening the Start Page.
      This patch adds the system shortcuts from {nav System Settings >
      Shortcuts > Standard Shortcuts > Home} to Gwenviews `Start Page`
      action, which defaults to {key Alt Home} and special {key Home_Page}.
      
      Test Plan:
      # Open Gwenview
      # {nav Settings > Configure Shortcuts > Defaults}
      # Check `Start Page` to show system settings shortcuts
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx
      
      Differential Revision: https://phabricator.kde.org/D13166
      cec36220
  17. 19 May, 2018 1 commit
  18. 30 Apr, 2018 2 commits
    • Peter Mühlenpfordt's avatar
      Remember width of sidebar · c7b70617
      Peter Mühlenpfordt authored
      Summary:
      If a user moves the central splitter to change the width of the
      sidebar Gwenview does not remember this for the next restart.
      This patch adds a config entry to store the splitter sizes
      analogous to the thumbnailbar config in View Mode.
      
      BUG: 238682
      FIXED-IN: 18.08.0
      Depends on D12561
      
      Test Plan:
      * Open Gwenview in Browse or View Mode
      * Show sidebar if hidden ({key F4})
      * Move splitter to resize sidebar
      * Quit and restart Gwenview
      * Sidebar should have same width as before
      * Check default with a clean config file
      
      Reviewers: #gwenview, huoni
      
      Reviewed By: #gwenview, huoni
      
      Subscribers: rkflx, huoni
      
      Differential Revision: https://phabricator.kde.org/D12489
      c7b70617
    • Peter Mühlenpfordt's avatar
      Set central splitter to non collapsible · 1ba6572d
      Peter Mühlenpfordt authored
      Summary:
      The sidebar can be toggled by {key F4}, {nav View > Sidebar} or
      a button in the status bar. Hiding the sidebar by dragging the
      central splitter to a collapsed state may confuse users if they
      can't toggle the sidebar anymore using the normal ways.
      This gets even more awkward saving the splitter state in D12489.
      This patch simply disables collapsing for the central splitter.
      
      FIXED-IN: 18.08.0
      
      Test Plan:
      * Open Gwenview with visible sidebar
      * Move the horizontal splitter left and right
      * It should not be possible to collapse one side
      
      Reviewers: #gwenview, huoni
      
      Reviewed By: #gwenview, huoni
      
      Differential Revision: https://phabricator.kde.org/D12561
      1ba6572d
  19. 19 Apr, 2018 2 commits
    • Peter Mühlenpfordt's avatar
      Remove duplicate setting of CurrentMainPageId variable · 9b443ddf
      Peter Mühlenpfordt authored
      Setting of `mCurrentMainPageId` to `StartMainPageId` is not needed
      in `MainWindow::readProperties` since this is done in the called
      `MainWindow::showStartMainPage`.
      9b443ddf
    • Peter Mühlenpfordt's avatar
      Fix View Mode session restore · cd18339f
      Peter Mühlenpfordt authored
      Summary:
      While restoring a saved session the last URL is selected but
      View Mode is not triggered. This is caused by wrong order of
      switching mode and setting the current URL.
      
      BUG: 393176
      FIXED-IN: 18.04.1
      
      Test Plan:
      * Open one or more instances of Gwenview in different states
      * Logout with session restore enabled
      * Login
      * All Gwenview windows should restore in Browse or View Mode
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx
      
      Differential Revision: https://phabricator.kde.org/D12246
      cd18339f
  20. 09 Apr, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Fix shortcut config changes sometimes not updating until restart · 936e30ac
      Peter Mühlenpfordt authored
      Summary:
      After setting or resetting custom shortcuts for actions in Browse or
      Start Page Mode and then switching to View Mode these changes are not
      active until next Gwenview restart.
      This patch adds a `refreshActionProperties()` call after the shortcut
      config dialog is closed to fix this.
      
      BUG: 389331
      FIXED-IN: 18.04.0
      
      Test Plan:
      * Start Gwenview in Browse Mode or Start Page Mode
      * {nav Settings > Configure Shortcuts...}
      * Set custom shortcut for {nav Quit} to e.g. {key Esc}
      * Switch to View Mode displaying any image
      * {key Esc} should quit Gwenview
      * Restart Gwenview in Browse Mode or Start Page Mode
      * {nav Settings > Configure Shortcuts...}
      * Reset shortcuts with {nav Defaults}
      * Switch to View Mode displaying any image
      * {key Ctrl Q} should quit Gwenview
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx, huoni
      
      Differential Revision: https://phabricator.kde.org/D12023
      936e30ac
  21. 21 Mar, 2018 2 commits
    • __ __'s avatar
      Align slideshow terminology to MPRIS behaviour · beef8f3b
      __ __ authored
      Summary:
      9631043c introduced MPRIS support to Gwenview. Common MPRIS
      controllers often only provide "Pause" in the main interface, with
      "Stop" being non-existent or hidden. Therefore "holding" the slideshow
      was mapped to "Pause". "Play" either "Resumes" automatically advancing
      to the next image, or in non-fullscreen mode switches to fullscreen and
      starts playback. Conversely, "Stop" ends playback and exits from
      fullscreen.
      
      To keep consistency, we change the tooltip text of the fullscreen button
      controlling the playback to "Pause". In addition, the internal `enum` is
      adapted accordingly to avoid confusing developers.
      
      Note that the icon on the button still shows a "Pause" symbol as before
      the patch.
      
      Ref T8222
      
      Test Plan:
      Start Gwenview normally, with `-f` and with `-s`, and observe the
      tooltip of the playback button in the top fullscreen toolbar as well as
      the button text in non-fullscreen mode (use {nav Configure Toolbars} to
      add it) make sense in every situation.
      
      Reviewers: #gwenview, kossebau, muhlenpfordt
      
      Reviewed By: #gwenview, muhlenpfordt
      
      Subscribers: ltoscano, muhlenpfordt, huoni, kde-doc-english
      
      Maniphest Tasks: T8222
      
      Differential Revision: https://phabricator.kde.org/D11495
      beef8f3b
    • Peter Mühlenpfordt's avatar
      Fix context menus for Recent Files / Folders on Start Page · 3a02df6e
      Peter Mühlenpfordt authored
      Summary:
      On {nav Start Page > Recent Files} the context menu is missing and
      right clicking on an item switches to View Mode.
      This patch adds the context menu to {nav Recent Files} tab items
      with the entries {nav Add Containing Folder to Places},
      {nav Forget This File} and {nav Forget All Files}. The entries on
      the {nav Recent Folders} tab are renamed accordingly.
      
      Ref T8194
      FIXED-IN: 18.04.0
      
      Test Plan:
      * Open some images to populate the recent files/folders lists
      * Go to {nav Start Page}
      * Right click on file / folder items to show context menu
      * Check actions to execute correctly
      * Check if clear actions for recent files sync with {nav File > Open Recent}
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx
      
      Maniphest Tasks: T8194
      
      Differential Revision: https://phabricator.kde.org/D11479
      3a02df6e
  22. 20 Mar, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Extend action "Clear Recent List" to clear model and recent folders · d2afcfe2
      Peter Mühlenpfordt authored
      Summary:
      {nav File > Open Recent > Clear List} clears the displayed list of
      recent files, but the same list in the {nav Start Page > Recent Files}
      tab is not cleared (only after restarting Gwenview).
      This patch extends and renames the menu entry to clear the internal
      models and both tabs {nav Start Page > Recent Files / Folders}.
      
      Ref T8194
      FIXED-IN: 18.04.0
      
      Test Plan:
      * Open some images to populate the recent files/folders lists
      * Click {nav File > Open Recent > Forget All Files & Folders}
      * Check if {nav File > Open Recent} is empty
      * Check if {nav Start Page > Recent Files / Folders} are empty
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx
      
      Maniphest Tasks: T8194
      
      Differential Revision: https://phabricator.kde.org/D11477
      d2afcfe2
  23. 15 Mar, 2018 1 commit
    • Friedrich W. H. Kossebau's avatar
      Expose slideshow to MPRIS controllers · 9631043c
      Friedrich W. H. Kossebau authored
      Summary:
      Taking the abstraction "Media" in "Media Player Remote Interfacing
      Specification" (MPRIS) into use, a plain slide in a slideshow can be seen
      to be the same as e.g. a still picture in a movie without any sound.
      Following that, a slideshow with pictures and videos as in the UI model
      of Gwenview can be roughly mapped onto the concept of a list of tracks as
      with in the data model of MPRIS.
      
      This patch exposes the list of images/movies in the current folder and
      the related slideshow feature as MPRIS D-Bus object, implementing for a
      start the interfaces
      * "org.mpris.MediaPlayer2"
      * "org.mpris.MediaPlayer2.Player"
      trying to map those to the Gwenview UX closely.
      
      This allows the slideshow and some other navigation to be controlled
      by any MPRIS controllers, which includes e.g.
      * keyboard mediakeys (Play/Pause, Stop, Next, Previous),
        as handled by Plasma MPRIS dataengine
      * KDE Connect media player controller plugin
      
      Additionally the MRPIS D-Bus object is unregistered while the workspace
      lockscreen is activated. Because at least the Plasma lockscreen has
      the feature to show controls for any currently running MPRIS players,
      which for one does not make sense currently for an image player as all
      displays are locked, and then also can be surprising for some users and
      result in data leaks via the image metadata used.
      
      Future:
      The great plan is to enhance the MPRIS spec to also work well for
      presentation-like media shows. So there can and will be cross-app
      rich (remote) controllers also for classical presentation application
      instead of only per-app ones.
      Supporting the existing MPRIS interfaces, even if slightly bending the
      semantics, is a first step into that direction and already adds value
      as it allows reuse of existing MPRIS controllers e.g. for remote control.
      
      So follow-up work will be to also implement the other MPRIS interfaces
      like org.mpris.MediaPlayer2.TrackList, for exposing the whole set of
      "slides". This will enable MPRIS controllers to show the user a complete
      visual list and e.g. navigate directly to a given slide or give a preview
      for the next/previous slides.
      
      CCBUG: 359381
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: mtijink, ngraham, nicolasfella, #kde_connect, rkflx, broulik
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D10972
      9631043c
  24. 14 Mar, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Prevent saving Recent Files and LastTargetDir if history is disabled · 8bd2f625
      Peter Mühlenpfordt authored
      Summary:
      Disabling history in {nav Settings > Configure > Advanced > History}
      does not prevent showing and populating {nav File > Open Recent}.
      The last target directory for Copy/Move/Link To dialog does not check
      for history option too.
      This patch only saves/restores file history if the option is enabled
      and hides the menu entry if disabled.
      
      BUG: 332853
      BUG: 391527
      
      Depends on D11280
      
      Test Plan:
      * Enable/disable history option
      * Open some images/folders in Gwenview
      * Copy/Move/Link To some images
      * Check if history is (not) saved/restored according to option value
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx
      
      Differential Revision: https://phabricator.kde.org/D11263
      8bd2f625
  25. 01 Mar, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Remember fullscreen mode and restore on next start · 59dd364b
      Peter Mühlenpfordt authored
      Summary:
      Currently Gwenview always starts in normal (non-fullscreen) mode
      independent of its state on previous quit.
      This patch saves the fullscreen mode and restores it on next start.
      
      BUG: 383093
      
      Test Plan:
      Quit Gwenview in normal/fullscreen mode and check if it restarts in
      previous mode.
      Commandline option --fullscreen overrides the saved state.
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx, ngraham
      
      Differential Revision: https://phabricator.kde.org/D10853
      59dd364b
  26. 26 Feb, 2018 1 commit
    • Andrew Crouthamel's avatar
      Change icons to more appropriate versions · 9660ef50
      Andrew Crouthamel authored and __ __'s avatar __ __ committed
      Summary:
      This change changes the media-skip icons to go- icons, more suitable paging back and forth through images.
      This also adds First and Last icons, as well as an icon for the save dialog when closing the application.
      
      Main Menu Before:
      {F5730237}
      Main Menu After:
      {F5730238}
      Save Dialog Before:
      {F5730239}
      Save Dialog After:
      {F5730240}
      
      Test Plan: Page back and forth with the navigation buttons. Make changes to images, attempt to close the application to trigger the save dialog, and attempt discarding changes.
      
      Reviewers: #gwenview, ngraham, rkflx
      
      Reviewed By: #gwenview, ngraham, rkflx
      
      Subscribers: rkflx, ngraham
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D10847
      9660ef50
  27. 25 Feb, 2018 1 commit
    • Silas Lenz's avatar
      Update filename in fullscreen view on rename · 00ee923e
      Silas Lenz authored
      Summary:
      When a file was renamed in fullscreen view the filename displayed in InformationLabel was not updated until you navigated to another image and back. This was  caused by the current url not being updated, which also resulted in edits and saves affecting the wrong image. This patch fixes the missing url update. Also makes full screen thumbnailBar scroll to the new file similar to other thumbnailviews.
      
      BUG: 390332
      Closes T8071
      
      Test Plan:
      Case 1:
      1. Open image in fullscreen view.
      2. Rename image using F2 or right click menu.
      3. Verify that all visible filenames are updated, and that navigation between images still work.
      
      Case 2:
      1. Open image in normal view.
      2. Rename image using F2 or Operations sidebar.
      3. Verify that all visible filenames are updated, and that navigation between images still work.
      
      Case 3:
      1. Select image thumbnail in browse view.
      2. Rename image using F2 or right click menu.
      3. Verify that all visible filenames are updated, and that the image is still selected.
      
      Reviewers: #gwenview, muhlenpfordt
      
      Reviewed By: #gwenview, muhlenpfordt
      
      Subscribers: rkflx, muhlenpfordt
      
      Tags: #gwenview
      
      Maniphest Tasks: T8071
      
      Differential Revision: https://phabricator.kde.org/D10745
      00ee923e
  28. 22 Feb, 2018 2 commits
    • Peter Mühlenpfordt's avatar
      Rename setStatusBarVisibility to saveStatusBarVisibility · f3b1807f
      Peter Mühlenpfordt authored
      This change should actually be made in D10577 but got lost.
      After changing sidebar code in D10687 this name is adjusted
      for statusbar too.
      f3b1807f
    • Peter Mühlenpfordt's avatar
      Adjust sidebar code and config entries to statusbar · 602db1bc
      Peter Mühlenpfordt authored
      Summary:
      Setup config entries and default values of sidebar states in
      `gwenview.kcfg` and use the generated access functions like it
      is done for statusbar in D10577.
      From a user's sight the sidebar behaviour and state saving is
      not changed.
      
      Test Plan:
      Switch browse/view, normal/fullscreen modes.
      The sidebar state should always restore to previous setting and
      button on statusbar should correspond to this state.
      Three different states are (re)stored:
      * Browse mode (always equal in normal/fullscreen mode)
      * View mode normal (windowed) mode
      * View mode fullscreen mode
      
      Switch the different tabs on sidebar and check if the last
      activated is restored on next restart.
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx
      
      Differential Revision: https://phabricator.kde.org/D10687
      602db1bc
  29. 19 Feb, 2018 3 commits
    • Peter Mühlenpfordt's avatar
      Fix thumbnail hover icon show-in-fullscreen action · 4c33978b
      Peter Mühlenpfordt authored
      Summary:
      In non-fullscreen browse mode the thumbnails display four hover icons.
      Clicking on the "view in fullscreen" icon switches to fullscreen mode
      but not to view mode as expected.
      This patch switches to fullscreen view mode.
      
      Test Plan:
      Open Gwenview in normal browse mode and hover over thumbnail icons
      to see the icons. Click on second icon to view this image
      in fullscreen mode.
      
      {F5712905}
      
      Reviewers: #gwenview, ngraham
      
      Reviewed By: #gwenview, ngraham
      
      Subscribers: ngraham, rkflx
      
      Differential Revision: https://phabricator.kde.org/D10651
      4c33978b
    • Peter Mühlenpfordt's avatar
      Keep statusbar visibility in sync with KToggleAction and persist states · c2e8c892
      Peter Mühlenpfordt authored
      Summary:
      When switching to fullscreen view mode the statusbar is hidden but the
      `KToggleAction` is not updated. This leads to unhiding the statusbar
      after applying config dialog and forcing the user to press {key F3}
      twice to show the statusbar.
      This patch keeps visibility and action state in sync by using persistent
      `GwenviewConfig` values for browse mode and normal/fullscreen view
      modes like sidebar.
      
      Test Plan:
      Switch browse/view, normal/fullscreen modes.
      The statusbar state should always restore to previous setting.
      Three different states are (re)stored:
      * Browse mode (always equal in normal/fullscreen mode)
      * View mode normal (windowed) mode
      * View mode fullscreen mode
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx
      
      Differential Revision: https://phabricator.kde.org/D10577
      c2e8c892
    • Huon Imberger's avatar
      Improve selection and hover colors in the thumbnail bars · 543f0b9c
      Huon Imberger authored and __ __'s avatar __ __ committed
      Summary:
      The visual feedback when hovering, especially in the fullscreen thumbnail bar,
      was too weak. I've fixed this by improving the hover background color, and
      applying a stylesheet to the fullscreen thumbnail bar.
      
      Before:
      {F5713490, loop, autoplay}
      {F5713491, loop, autoplay}
      
      After:
      {F5717013, loop, autoplay}
      {F5717011, loop, autoplay}
      
      Test Plan:
      Thumbnail bar colors in both `View` mode and fullscreen `View` should provide
      good visual feedback (hover and select).
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx, ngraham
      
      Differential Revision: https://phabricator.kde.org/D10564
      543f0b9c
  30. 18 Feb, 2018 1 commit
    • Huon Imberger's avatar
      Save config when opening the config dialog · e913496b
      Huon Imberger authored and __ __'s avatar __ __ committed
      Summary:
      Some settings can be changed outside of the config dialog. We don't
      want these changes to be lost when changing the config, which
      triggers reloading of the config.
      
      BUG: 390331
      
      Test Plan:
      Settings changed outside the config dialog, e.g. thumbnail zoom level in Browse view,
      should not reset if you change a setting in the config dialog.
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Differential Revision: https://phabricator.kde.org/D10626
      e913496b