1. 15 Feb, 2021 1 commit
  2. 17 Nov, 2020 1 commit
  3. 23 Oct, 2020 1 commit
  4. 16 Jul, 2020 1 commit
  5. 27 May, 2020 1 commit
  6. 19 Feb, 2020 1 commit
  7. 08 Nov, 2019 1 commit
    • Robert Hoffmann's avatar
      Fix image loading performance · 80719d13
      Robert Hoffmann authored
      Summary: Start the dirlister after loading an image whose url is passed on the command line to make sure that this image is shown before the possibly long running dirlister on a potentially slow device is started.
      
      Test Plan:
      Mount some slow network filesystem (e.g. cifs) and open an image file
      from a directory containing a few hundred files using the command line:
      $ gwenview imagefile
      
      It will take several seconds/minutes until the image is shown (until all
      preview images are loaded).
      
      After applying this patch the image will be shown immediately and the
      preview images after that.
      
      Reviewers: #gwenview, ngraham
      
      Reviewed By: #gwenview, ngraham
      
      Subscribers: ngraham, tommo
      
      Tags: #gwenview
      
      Differential Revision: https://phabricator.kde.org/D25005
      80719d13
  8. 12 Aug, 2019 1 commit
  9. 12 Oct, 2018 1 commit
  10. 28 Sep, 2018 1 commit
  11. 10 Sep, 2018 1 commit
  12. 18 Aug, 2018 1 commit
  13. 02 Aug, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Make sure, a newly saved image is selected in ContextManager · b19e0229
      Peter Mühlenpfordt authored
      Summary:
      After an image is {nav Saved As...} in View Mode, the current image
      and selection in thumbnail bar are not updated. As a side effect the
      view jumps to the first item in directory instead of showing the newly
      saved image. This is caused by D8934.
      This patch makes sure, the new image is selected in `ContextManager`
      and the window title is updated correctly.
      
      Test Plan:
      # Open an image in View Mode
      # Use {nav File > Save As} and save image as e.g. "filename2.jpg"
      # Image "filename2.jpg" should be viewed and window title updated
      
      * Check that {nav File > Save As} also works correctly after image
        modifications (resize, crop, etc.)
      * Check with option {nav Keep same zoom and position} and 100% or
        a custom zoom factor active
      * Check current selection while toggling between View/Browse Mode
        after {nav File > Save As}
      * Check that {nav Go back to the original} works
      * (Some more special tests in D9342)
      
      Reviewers: rkflx, #gwenview
      
      Reviewed By: rkflx, #gwenview
      
      Subscribers: bschiffner, ngraham
      
      Differential Revision: https://phabricator.kde.org/D9342
      b19e0229
  14. 14 Mar, 2018 2 commits
    • Peter Mühlenpfordt's avatar
      Prevent saving Recent Files and LastTargetDir if history is disabled · 8bd2f625
      Peter Mühlenpfordt authored
      Summary:
      Disabling history in {nav Settings > Configure > Advanced > History}
      does not prevent showing and populating {nav File > Open Recent}.
      The last target directory for Copy/Move/Link To dialog does not check
      for history option too.
      This patch only saves/restores file history if the option is enabled
      and hides the menu entry if disabled.
      
      BUG: 332853
      BUG: 391527
      
      Depends on D11280
      
      Test Plan:
      * Enable/disable history option
      * Open some images/folders in Gwenview
      * Copy/Move/Link To some images
      * Check if history is (not) saved/restored according to option value
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Subscribers: rkflx
      
      Differential Revision: https://phabricator.kde.org/D11263
      8bd2f625
    • Peter Mühlenpfordt's avatar
      Set default path of "Copy/Move/Link To" dialog to current folder · fee29422
      Peter Mühlenpfordt authored
      Summary:
      D8785 introduced `QStandardPaths::PicturesLocation` as default
      location for Copy/Move/Link To dialog.
      This patch sets the starting folder to the current folder (where
      the source image(s) resist). It also provides an easier handling
      of switching off the history option in D11263.
      
      CCBUG: 391527
      
      Test Plan:
      * Clear `LastTargetDir` config entry (e.g. remove `~/.config/gwenviewrc`)
      * Start Gwenview
      * Select one or more images and press {key F7} to copy
      * Dialog should start in current folder
      
      Reviewers: #gwenview, rkflx
      
      Reviewed By: #gwenview, rkflx
      
      Differential Revision: https://phabricator.kde.org/D11280
      fee29422
  15. 26 Jan, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Fix issues with clicking directories in tree view · 8a6a4ea6
      Peter Mühlenpfordt authored
      Summary:
      Selecting another directory in tree while showing an image in view mode,
      opens the first image from the selected directory in view mode. If the
      folder contains subfolders, gwenview selects the first one and switches
      to browse mode.
      This patch changes selection of first **item** back to first **image**
      (introduced in D8934) to fix this and toggles between browse/view mode
      only after clicking the already selected directory in tree.
      Additionally a trailing slash is stripped from the current dir url in
      context manager to fix a failing compare to initially stored dir url.
      
      BUG: 306835
      
      Test Plan:
      1. Open image in view mode
      2. Click on another directory in tree view
      -> Should view the first image in new directory
      
      1. Open image in view mode
      2. Click multiple times on the same directory in tree view
      -> Should toggle browse/view mode
      
      Reviewers: rkflx
      
      Reviewed By: rkflx
      
      Subscribers: ngraham, rkflx
      
      Differential Revision: https://phabricator.kde.org/D9886
      8a6a4ea6
  16. 09 Jan, 2018 1 commit
    • rkflx's avatar
      Rename setTargetUrl to setTargetDirUrl · d371a8e6
      rkflx authored
      This change was initially meant to be part of D8785, but had been backed
      out due to concerns about breaking source compatibility. Meanwhile, in
      D8785#176817 it was determined that SC/BC most likely won't be an issue
      in Gwenview because of no other users of the code.
      
      Therefore we now can rename a couple of methods and variables to better
      reflect what they are about, improving readability.
      d371a8e6
  17. 20 Nov, 2017 1 commit
  18. 09 Nov, 2017 1 commit
    • Valeriy Malov's avatar
      Try to keep ContextManager in sync with viewed files in MainWindow · b55420b2
      Valeriy Malov authored
      Summary:
      ContextManager now is responsible for switching to the directory
      containing requested URL and selecting it. However, if it is not
      possible, URL is still kept (in case of remote URLs), while selection is
      cleared (to avoid dragging in local files)
      
      MainWindow now relies on ContextManager's selection and/or
      selectedFileItemList instead of ThumbnailView selection. If selection &
      currentUrl are empty, refuse to open View tab, otherwise display
      selected items.
      
      This should prevent (reduce?) the amount of mismatches between which
      files user sees, and which files are being operated upon
      (e.g. by FileOpsContextManagerItem)
      
      BUG: 355493
      BUG: 275807
      BUG: 326190
      BUG: 306835
      
      Test Plan:
      Tried playing around to make sure it doesn't break any old behaviour
      Tried deleting all image files while in View mode, to make sure we back out when we run out of images
      Tried opening an http url and check that operations apply to it unless we select something in browse tab
      And then remote image should be unloaded from the View tab since our actions will now affect user-selected items
      
      Tests pass but they don't seem to cover this?
      
      Reviewers: #kde_applications, gateau, rkflx
      
      Reviewed By: gateau, rkflx
      
      Subscribers: ngraham, rkflx, gateau
      
      Differential Revision: https://phabricator.kde.org/D8196
      b55420b2
  19. 18 Aug, 2017 1 commit
  20. 02 Dec, 2016 1 commit
  21. 31 Oct, 2014 1 commit
  22. 10 Oct, 2014 1 commit
  23. 03 Oct, 2014 1 commit
  24. 02 Oct, 2014 1 commit
  25. 13 Aug, 2014 5 commits
  26. 18 Sep, 2013 1 commit
  27. 17 Sep, 2013 3 commits
  28. 11 Sep, 2013 1 commit
  29. 09 Sep, 2013 3 commits
  30. 06 Sep, 2013 2 commits