Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit 312ab20c authored by Huon Imberger's avatar Huon Imberger

Fix crop tool not saving config when navigating away

Summary:
Tool settings are saved in `toolDeactivated`, which is only triggered
when the tool is exited gracefully (e.g. when clicking Crop or Cancel).
This patch calls `toolDeactivated` when the parent `RasterImageView`
object is destroyed, ensuring settings are saved even when navigating
away, e.g. to another image, or back to {nav Browse}.

BUG: 392036

Test Plan:
{nav Crop} tool > activate/deactivate {nav Advanced} > navigate to next
image > open {nav Crop} tool > ensure the {nav Advanced} state is saved.
Also navigate away by clicking {nav Browse}.
Ensure navigating without {nav Crop} active is unaffected.

Reviewers: #gwenview, rkflx

Reviewed By: #gwenview, rkflx

Differential Revision: https://phabricator.kde.org/D11535
parent b4e9e0fc
......@@ -214,6 +214,9 @@ RasterImageView::RasterImageView(QGraphicsItem* parent)
RasterImageView::~RasterImageView()
{
if (d->mTool) {
d->mTool.data()->toolDeactivated();
}
if (d->mDisplayTransform) {
cmsDeleteTransform(d->mDisplayTransform);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment