1. 01 Oct, 2014 6 commits
  2. 03 May, 2014 1 commit
  3. 27 Apr, 2014 1 commit
  4. 22 Sep, 2011 1 commit
  5. 02 Sep, 2011 1 commit
  6. 30 Aug, 2011 1 commit
  7. 22 Apr, 2011 1 commit
  8. 25 Mar, 2011 1 commit
  9. 05 Mar, 2011 1 commit
  10. 24 Feb, 2011 1 commit
  11. 07 Feb, 2011 1 commit
  12. 22 Sep, 2010 1 commit
  13. 19 Oct, 2008 1 commit
  14. 09 Feb, 2008 1 commit
  15. 16 Oct, 2007 1 commit
    • Clarence Dang's avatar
      Polish Print and Print Preview code: · 971fa266
      Clarence Dang authored
      * Add missing copyright (there are too many lawyers in the world :))
      
      * Rename kpMainWindow::sendFilenameToPrinter() to sendDocumentNameToPrinter()
        and give up on sending the filename (it's a minor feature and
        QPrinter::setOutputFileName() was conflicting with other code too much and even
        overwriting the image file for Print Preview!)
      
      * Don't leak kpPrintDialogPage or KdePrint::createPrintDialog()
      
      * Save print-centered option to config (per mainwindow setting)
        (use the same name as when this was a hidden configuration option)
      
      * Give print dialog a caption
      
      * Change option tab accel
      
      Printing appears to work.  My build is in such a state that I can't test Print Preview.
      
      
      svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=725855
      971fa266
  16. 11 Oct, 2007 2 commits
  17. 08 Oct, 2007 2 commits
  18. 07 Oct, 2007 1 commit
  19. 30 Sep, 2007 1 commit
  20. 29 Sep, 2007 2 commits
    • Clarence Dang's avatar
      Proper way of renaming from "kolourpaint" to "kolourpaint4": change internal KAboutData name. · 3921f837
      Clarence Dang authored
      This reverts the "KolourPaint4" config group prefixing of the previous commit and we no longer insanely share config files between KDE3 and KDE4.
      
      Changing the internal name to "kolourpaint4" meant that we also had to:
      
      1. Rename the install directories to "kolourpaint4" (including docs)
      
      2. Rename the app icons to "kolourpaint4"
      
      3. Call KAboutData::setProductName() with the bugs.kde.org product name of "kolourpaint" (no '4')
      
      Other changes:
      
      * Various source files no longer have to explicity point to "kolourpaint4ui.rc"
      
      Other changes that seemed to have no effect:
      
      * Change kdegraphics/kolourpaint/CMakeLists.txt's "project" to "kolourpaint4"
      
      * Rename "name" attribute of "gui" tag of kolourpaint4ui.rc to "kolourpaint4"
      
      svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=718694
      3921f837
    • Clarence Dang's avatar
      Allow KolourPaint/KDE4 and KolourPaint/KDE3 to run side-by-side. · e69634d7
      Clarence Dang authored
      It's especially important to allow KolourPaint/KDE3 to run under KDE 4.0
      since it's far better tested than KolourPaint/KDE4 will be.
      
      * Rename kolourpaint executable -> kolourpaint4
        [so that the user doesn't have to dig up the full path]
      
      * Rename libkolourpaint_lgpl -> libkolourpaint4_lgpl
        [not needed but done just for future-proofing]
      
      * Rename kolourpaint.desktop -> kolourpaint4.desktop
        [not really required but done for consistency with executable name]
        - Also update.desktop to point to the renamed executable
      
      * Rename kolourpaintui.rc > kolourpaint4ui.rc
        [so that neither version of KolourPaint picks up the wrong toolbar/menus]
      
      * Share $KDEHOME/share/config/kolourpaintrc between KDE4 and KDE3:
        - Changes:
          - Prefix all config groups with "KolourPaint4"
          - Prefix toolbar names with "KolourPaint4" for config-autosaving
          - Point to kolourpaint4ui.rc
        - Problems:
          - We can't prefix "KFileDialog Settings"
          - Sharing a config file between 2 generations of KDE is insane and error-prone
        - Due to complexity of this, I'm going to revert this part of the patch
          and use a far easier method: change the KAboutData name of the app
      
      * Directories are unchanged
      
      
      svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=718651
      e69634d7
  21. 27 Sep, 2007 2 commits
    • Clarence Dang's avatar
      Given that the Tool Box and Color Box are now QDockWidget's and out of the · eb652084
      Clarence Dang authored
      reach of XMLGUI, we can now remove the KEditToolBar hacks (which were broken
      by the KDE4 porting anyway).
      
      Editing toolbars works now, except for frequent crashes that also happen
      in Okular (looks like a kdelibs bug, probably fixed by now, given that
      I haven't updated kdelibs for a while).  Changes also happen straight away,
      unlike in KolourPaint/KDE3, due to the removal of those hacks.
      
      
      svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=717700
      eb652084
    • Clarence Dang's avatar
      Finish code review and light testing for the configurable color palette feature: · 062494e3
      Clarence Dang authored
      * slotColorsKDE(): ensure the action is checked, in all cases, if open succeeds
      
      * Extract logic from kpMainWindow.cpp:init() to kpMainWindow_Colors.cpp:createColorBox(), to be consistent with kpMainWindow_Tools.cpp:createToolBox()
      
      * Push call to deselectActionColorsKDE() out of openColors() and into slotColorsOpen(), to be consistent with other methods
      
      * +TODO, comments
      
      svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=717564
      062494e3
  22. 26 Sep, 2007 1 commit
    • Clarence Dang's avatar
      * Replace the Color Box's "Reload Colors" button with a label stating the name... · 82d79722
      Clarence Dang authored
      * Replace the Color Box's "Reload Colors" button with a label stating the name and modified state of the color collection for these reasons:
      
        1. It takes less precious vertical room.
      
        2. Reloading is not that frequent an operation (undoing a color collection mutation would be more useful but is not supported yet anyway).
      
      * Eat color drops (which are usually accidental drags from one of our
        child widgets) to prevent them from being pasted as text in the
        main window (by kpMainWindow::dropEvent())
      
      * Remove kpColorPalette::colorCellsIsModifiedChanged() signal to reduce duplication
      
      * Clear up comments about hiding the windowTitle() in both the Color and Tool toolbars
      
      svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=717092
      82d79722
  23. 25 Sep, 2007 2 commits
    • Clarence Dang's avatar
      SVN_SILENT comments · 7cdcc5b2
      Clarence Dang authored
      svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=716743
      7cdcc5b2
    • Clarence Dang's avatar
      * Move Tool Box and Color Box title bar handling from kpMainWindow.cpp into · 259eacdb
      Clarence Dang authored
        their classes, where this handling belongs
        - Add "Reload Color" button (Color Box's title bar widget) that appears when
          the Color Cells are modified (this is more useful as a modified indicator)
          - TODO: It takes too much vertical room
          - Added some disabled code that uses an unclickable label instead
      
      * Make reloading the KolourPaint default colors work
      
      * Add slotUpdateColorsDeleteRowActionEnabled()
      
      
      svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=716621
      259eacdb
  24. 23 Sep, 2007 1 commit
    • Clarence Dang's avatar
      Commit rough color palette and toolbar work: · 4ca41031
      Clarence Dang authored
      * Toolbar work: Tool Box & Color Tool Bar
        - Change from KToolBar to QDockWidget base
          - Nice side-effect: kpColorToolBar gets a QDockWidget resize grip
          - Lets us use QMainWindow::setCorner() so that Tool Box can take all the vertical space, since it can be quite tall with all its tool option widgets
          - Prevents KMainWindow from managing tool bar position so that we can force toolbars to be in a default and fixed place - this works around all the current quirks (due to the effects of QToolBar::setOrientation() no longer being virtual -- though, I actually saw an orientationChanged() signal now -- and probably other reasons):
            1. Toolbars staying on top of even non-KolourPaint windows when KolourPaint is not the foreground window
            2. Not being dockable when undocked
        - kpColorToolBar: use proper QSpacerItem instead of a fake widget (this looks better on e.g. Keramik style)
        - For component widgets, make them all do the following to avoid Qt layout oddities:
          1. setSizePolicy() themselves, rather than nobody doing it or leaving it up to the users
          2. Use setMinimumSize() instead of setFixedSize() and also don't use QSizePolicy::Fixed (don't know why this is required)
      
      * Color editing work
        - Split queryClose() into queryCloseDocument() and new queryCloseColors()
        - Start fix reloading and modified-state to work (regarding modified state, what is missing is drag-and-drop affecting it and a lot of testing)
        - kpColorCollection
          - Introduce openKDE() method to replace ctor functionality and allow error-handling
          - Add "showOverwritePrompt" argument to saveAs()
          - Rename save() to saveKDE()
        - kpColorCells
          - Add colorCollection() and saveColorCollection()
          - Tweak ::Palette{Column,Rows}()
          - When there are >= 3 rows, reduce the heights of each cell only -- not the width -- and only to 17, not to 13 (so you can fit 3 larger rows, not 4 smaller ones; height of all the cells is 52)
          - Clicking no longer takes tab focus away from main view
            Testcase: When a text box is active, clicking to change the background color
                      should not move the keyboard focus away from the text box.
      
      * kpColorPalette
        - Add buttons to resize the color palette (TODO: revert this straight away since kpColorToolBar being  QDockWidget already gives us a resize grip, that is more intuitive)
        - Make sure kpColorCells are horizontally centered inside the scrollarea
      
      * Documentation
        - Set target freeze date as Oct 21
        - Mark clearly as BETA
        - Document toolbar regressions
      
      * Style, +/- debug
      
      
      
      svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=715735
      4ca41031
  25. 17 Aug, 2007 1 commit
  26. 16 Aug, 2007 1 commit
  27. 02 Aug, 2007 1 commit
  28. 30 Jul, 2007 2 commits
    • Clarence Dang's avatar
      svn merge... · e3d00580
      Clarence Dang authored
      svn merge https://svn.kde.org/home/kde/branches/work/~dang/kdegraphics/kolourpaint/ -r692068:693565 to have both branches (~dang and us) sync'ed:
      
      * Reorder kpDocument::setSelection() so that code is executed strictly in this order:
      
        1. Document mutations
        2. Environment mutations
        3. Signals
      
        to ensure consistency.
      
      * Fix code duplication in kpMainWindow*.cpp:
      
          -    if (toolHasBegunShape ())
          -        tool ()->endShapeInternal ();
          +    toolEndShape ();
      
        and audit places where we're missing toolEndShape()
      
      * Minor changes
      
      svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=694319
      e3d00580
    • Clarence Dang's avatar
      Move fields and DEBUG_KP_MAIN_WINDOW into kpMainWindowPrivate.h (d-ptr struct). · 110737da
      Clarence Dang authored
      Merge field initialization in kpMainWindowPrivate.h into kpMainWindow::init(), to be consistent with other classes and to not have "logic" inside .h files.
      
      svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=694163
      110737da
  29. 25 Jul, 2007 1 commit
    • Clarence Dang's avatar
      +LOTODO · eac5fab4
      Clarence Dang authored
      svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=692268
      eac5fab4