GitLab

This fixes finding the tools menu, as well as undo/redo popups

This is a global search/replace, the needed manual changes
will be committed separately

This is a global search/replace, the needed manual changes
will be committed separately

Fix things a coverity scan found (mainly member vars init)

registerView before setting the view into the scroll area to avoid
a mouse event being handled before the view manager knows about
this new view (leading to assert)

BUG: 329234
FIXED-IN: 4.13.1

BUG: 278628

kolourpaint now also already checks beforehand if the data in
the clipboard is a valid image, otherwise it disables the paste
actions.

BUG: 173142

Handle settings save/restore from the scale/resize dialog only
inside the dialog itself.
Code cleanup (the names of the config entries need not be QStrings
as KConfigGroup converts them then to UTF-8)

FEATURE: 179658
GUI:

instead QPixmap.

BUG: 94607
BUG: 85280
BUG: 94445
BUG: 171762
BUG: 255278
BUG: 259994

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=1219290

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=1178207

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=873614

const & for foreach

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=772795

* Add missing copyright (there are too many lawyers in the world :))

* Rename kpMainWindow::sendFilenameToPrinter() to sendDocumentNameToPrinter()
  and give up on sending the filename (it's a minor feature and
  QPrinter::setOutputFileName() was conflicting with other code too much and even
  overwriting the image file for Print Preview!)

* Don't leak kpPrintDialogPage or KdePrint::createPrintDialog()

* Save print-centered option to config (per mainwindow setting)
  (use the same name as when this was a hidden configuration option)

* Give print dialog a caption

* Change option tab accel

Printing appears to work.  My build is in such a state that I can't test Print Preview.


svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=725855

1. Zoom In
2. Scroll
2. Close the document using CTRL+W

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=724089

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=724032

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=722779

Port kpSelectionDrag away from Q3ImageDrag -- which was buggy beyond repair
and deprecated anyway -- to QMimeData.  By removing unused functionality
and by making use of the simplicty of QMimeData, kpSelectionDrag's implementation
is significantly simpler.

In kpMainWindow_Edit.cpp, I've added a TODO about kpPixmapFX::pixmapWithDefinedTransparentPixmaps(), that refers to a future commit :(

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=722750

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=722470

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=718947

This reverts the "KolourPaint4" config group prefixing of the previous commit and we no longer insanely share config files between KDE3 and KDE4.

Changing the internal name to "kolourpaint4" meant that we also had to:

1. Rename the install directories to "kolourpaint4" (including docs)

2. Rename the app icons to "kolourpaint4"

3. Call KAboutData::setProductName() with the bugs.kde.org product name of "kolourpaint" (no '4')

Other changes:

* Various source files no longer have to explicity point to "kolourpaint4ui.rc"

Other changes that seemed to have no effect:

* Change kdegraphics/kolourpaint/CMakeLists.txt's "project" to "kolourpaint4"

* Rename "name" attribute of "gui" tag of kolourpaint4ui.rc to "kolourpaint4"

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=718694

It's especially important to allow KolourPaint/KDE3 to run under KDE 4.0
since it's far better tested than KolourPaint/KDE4 will be.

* Rename kolourpaint executable -> kolourpaint4
  [so that the user doesn't have to dig up the full path]

* Rename libkolourpaint_lgpl -> libkolourpaint4_lgpl
  [not needed but done just for future-proofing]

* Rename kolourpaint.desktop -> kolourpaint4.desktop
  [not really required but done for consistency with executable name]
  - Also update.desktop to point to the renamed executable

* Rename kolourpaintui.rc > kolourpaint4ui.rc
  [so that neither version of KolourPaint picks up the wrong toolbar/menus]

* Share $KDEHOME/share/config/kolourpaintrc between KDE4 and KDE3:
  - Changes:
    - Prefix all config groups with "KolourPaint4"
    - Prefix toolbar names with "KolourPaint4" for config-autosaving
    - Point to kolourpaint4ui.rc
  - Problems:
    - We can't prefix "KFileDialog Settings"
    - Sharing a config file between 2 generations of KDE is insane and error-prone
  - Due to complexity of this, I'm going to revert this part of the patch
    and use a far easier method: change the KAboutData name of the app

* Directories are unchanged


svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=718651

reach of XMLGUI, we can now remove the KEditToolBar hacks (which were broken
by the KDE4 porting anyway).

Editing toolbars works now, except for frequent crashes that also happen
in Okular (looks like a kdelibs bug, probably fixed by now, given that
I haven't updated kdelibs for a while).  Changes also happen straight away,
unlike in KolourPaint/KDE3, due to the removal of those hacks.


svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=717700

* slotColorsKDE(): ensure the action is checked, in all cases, if open succeeds

* Extract logic from kpMainWindow.cpp:init() to kpMainWindow_Colors.cpp:createColorBox(), to be consistent with kpMainWindow_Tools.cpp:createToolBox()

* Push call to deselectActionColorsKDE() out of openColors() and into slotColorsOpen(), to be consistent with other methods

* +TODO, comments

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=717564

* Replace the Color Box's "Reload Colors" button with a label stating the name and modified state of the color collection for these reasons:

  1. It takes less precious vertical room.

  2. Reloading is not that frequent an operation (undoing a color collection mutation would be more useful but is not supported yet anyway).

* Eat color drops (which are usually accidental drags from one of our
  child widgets) to prevent them from being pasted as text in the
  main window (by kpMainWindow::dropEvent())

* Remove kpColorPalette::colorCellsIsModifiedChanged() signal to reduce duplication

* Clear up comments about hiding the windowTitle() in both the Color and Tool toolbars

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=717092

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=716743

  their classes, where this handling belongs
  - Add "Reload Color" button (Color Box's title bar widget) that appears when
    the Color Cells are modified (this is more useful as a modified indicator)
    - TODO: It takes too much vertical room
    - Added some disabled code that uses an unclickable label instead

* Make reloading the KolourPaint default colors work

* Add slotUpdateColorsDeleteRowActionEnabled()


svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=716621

* Toolbar work: Tool Box & Color Tool Bar
  - Change from KToolBar to QDockWidget base
    - Nice side-effect: kpColorToolBar gets a QDockWidget resize grip
    - Lets us use QMainWindow::setCorner() so that Tool Box can take all the vertical space, since it can be quite tall with all its tool option widgets
    - Prevents KMainWindow from managing tool bar position so that we can force toolbars to be in a default and fixed place - this works around all the current quirks (due to the effects of QToolBar::setOrientation() no longer being virtual -- though, I actually saw an orientationChanged() signal now -- and probably other reasons):
      1. Toolbars staying on top of even non-KolourPaint windows when KolourPaint is not the foreground window
      2. Not being dockable when undocked
  - kpColorToolBar: use proper QSpacerItem instead of a fake widget (this looks better on e.g. Keramik style)
  - For component widgets, make them all do the following to avoid Qt layout oddities:
    1. setSizePolicy() themselves, rather than nobody doing it or leaving it up to the users
    2. Use setMinimumSize() instead of setFixedSize() and also don't use QSizePolicy::Fixed (don't know why this is required)

* Color editing work
  - Split queryClose() into queryCloseDocument() and new queryCloseColors()
  - Start fix reloading and modified-state to work (regarding modified state, what is missing is drag-and-drop affecting it and a lot of testing)
  - kpColorCollection
    - Introduce openKDE() method to replace ctor functionality and allow error-handling
    - Add "showOverwritePrompt" argument to saveAs()
    - Rename save() to saveKDE()
  - kpColorCells
    - Add colorCollection() and saveColorCollection()
    - Tweak ::Palette{Column,Rows}()
    - When there are >= 3 rows, reduce the heights of each cell only -- not the width -- and only to 17, not to 13 (so you can fit 3 larger rows, not 4 smaller ones; height of all the cells is 52)
    - Clicking no longer takes tab focus away from main view
      Testcase: When a text box is active, clicking to change the background color
                should not move the keyboard focus away from the text box.

* kpColorPalette
  - Add buttons to resize the color palette (TODO: revert this straight away since kpColorToolBar being  QDockWidget already gives us a resize grip, that is more intuitive)
  - Make sure kpColorCells are horizontally centered inside the scrollarea

* Documentation
  - Set target freeze date as Oct 21
  - Mark clearly as BETA
  - Document toolbar regressions

* Style, +/- debug



svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=715735

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=701202

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=700833

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=695802

svn merge https://svn.kde.org/home/kde/branches/work/~dang/kdegraphics/kolourpaint/ -r692068:693565 to have both branches (~dang and us) sync'ed:

* Reorder kpDocument::setSelection() so that code is executed strictly in this order:

  1. Document mutations
  2. Environment mutations
  3. Signals

  to ensure consistency.

* Fix code duplication in kpMainWindow*.cpp:

    -    if (toolHasBegunShape ())
    -        tool ()->endShapeInternal ();
    +    toolEndShape ();

  and audit places where we're missing toolEndShape()

* Minor changes

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=694319

Merge field initialization in kpMainWindowPrivate.h into kpMainWindow::init(), to be consistent with other classes and to not have "logic" inside .h files.

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=694163

svn path=/trunk/KDE/kdegraphics/kolourpaint/; revision=692268