1. 28 Mar, 2020 1 commit
  2. 21 Mar, 2020 1 commit
  3. 15 Mar, 2020 1 commit
  4. 01 Mar, 2020 3 commits
  5. 29 Feb, 2020 1 commit
  6. 17 Feb, 2020 1 commit
  7. 03 Feb, 2020 1 commit
  8. 02 Feb, 2020 1 commit
  9. 06 Jan, 2020 1 commit
  10. 05 Jan, 2020 3 commits
  11. 01 Jan, 2020 1 commit
  12. 10 Dec, 2019 1 commit
  13. 07 Dec, 2019 2 commits
  14. 06 Dec, 2019 2 commits
    • David Faure's avatar
      Port kolourpaint away from Kdeprint::createPrintDialog · f906beb0
      David Faure authored
      Summary: This was the final step to port away from kdelibs4support.
      
      Test Plan: The print dialog still has the 3rd widget with 2 radiobuttons like before.
      
      Reviewers: broulik, andreagenor, tcanabrava, vkrause
      
      Reviewed By: vkrause
      
      Maniphest Tasks: T11576
      
      Differential Revision: https://phabricator.kde.org/D25601
      f906beb0
    • David Faure's avatar
      Port from KFileDialog to QFileDialog. · ea2d7440
      David Faure authored
      Summary:
      Tricky because of the embedded widget for save options.
      Reused the solution found in kuickshow.
      
      Since QFileDialog implements overwrite checking, kill all
      the custom code for doing the same.
      
      Test Plan: Save as (new file), save as (existing file)
      
      Reviewers: broulik, andreagenor, tcanabrava
      
      Reviewed By: tcanabrava
      
      Maniphest Tasks: T11576
      
      Differential Revision: https://phabricator.kde.org/D25482
      ea2d7440
  15. 05 Dec, 2019 2 commits
  16. 28 Nov, 2019 1 commit
    • David Faure's avatar
      Port away from KImageIO. · bed17657
      David Faure authored
      Summary:
      Same solution (for finding the format string for QImage from the
      mimetype) as the one used by Spectacle.
      
      Test Plan:
      Saving still works as PNG, JPG (to test multiple extensions),
      and WEBP (to test a 4-letter extension).
      
      Reviewers: broulik, andreagenor, tcanabrava, vkrause
      
      Reviewed By: vkrause
      
      Differential Revision: https://phabricator.kde.org/D25600
      bed17657
  17. 27 Nov, 2019 5 commits
    • David Faure's avatar
      Port kpColorCollection away from KIO::NetAccess · 007dd8f6
      David Faure authored
      Summary:
      While testing "save as" over an existing color file, I noticed
      a double confirmation message box. This is because QFileDialog
      already takes care of it ==> simplify the code.
      
      Test Plan: Loading colors from submenu, saving as, saving as existing file, loading from file.
      
      Reviewers: broulik, andreagenor, tcanabrava, vkrause
      
      Reviewed By: vkrause
      
      Maniphest Tasks: T11576
      
      Differential Revision: https://phabricator.kde.org/D25480
      007dd8f6
    • David Faure's avatar
      Port the saving code away from NetAccess · 17c51793
      David Faure authored
      Test Plan:
      Saving works. Saving as another existing file brings up the
      overwrite prompt. Confusingly, "Save as" and chosing the current filename
      doesn't, unlike in other apps, but it's on purpose (and actually makes sense).
      
      Reviewers: broulik, andreagenor, tcanabrava
      
      Reviewed By: broulik
      
      Maniphest Tasks: T11576
      
      Differential Revision: https://phabricator.kde.org/D25479
      17c51793
    • David Faure's avatar
      Port urlExists() from NetAccess to KIO::NetAccess::exists · af59baf6
      David Faure authored
      Reviewers: broulik, andreagenor, tcanabrava, vkrause
      
      Reviewed By: vkrause
      
      Subscribers: vkrause
      
      Maniphest Tasks: T11576
      
      Differential Revision: https://phabricator.kde.org/D25478
      af59baf6
    • David Faure's avatar
      Port the Open code away from NetAccess. · 2147b5c1
      David Faure authored
      Summary:
      NetAccess::download used a temp file, to then load that with
      QImageReader.
      
      I'm using an in-memory buffer instead, mostly because it's
      less code. It should also be faster, at the expense of more
      memory usage of course (the PNG data should be less than the
      image data anyway).
      
      Test Plan: Opening files still works
      
      Reviewers: broulik, andreagenor, tcanabrava, vkrause
      
      Reviewed By: vkrause
      
      Maniphest Tasks: T11576
      
      Differential Revision: https://phabricator.kde.org/D25477
      2147b5c1
    • David Faure's avatar
      Porting away from NetAccess, step 1: code refactoring · d6ef2fb8
      David Faure authored
      Summary:
      * Split out the NetAccess::exists call from isFromExistingURL(bool),
      only one caller was passing true (the default value). Simpler to
      remove that bool and call both methods in that one location.
      
      * Provide a urlExists() method to wrap the calls to NetAccess::exists
      and call it from as many places as possible.
      
      Test Plan:
      Builds, I can open and save a file, but it would take time to figure
      out how to trigger all the changed code paths.
      
      Reviewers: broulik, vkrause
      
      Reviewed By: vkrause
      
      Maniphest Tasks: T11576
      
      Differential Revision: https://phabricator.kde.org/D25468
      d6ef2fb8
  18. 26 Nov, 2019 1 commit
  19. 23 Nov, 2019 1 commit
  20. 22 Nov, 2019 6 commits
  21. 11 Nov, 2019 1 commit
  22. 10 Nov, 2019 3 commits