1. 06 Dec, 2019 2 commits
    • David Faure's avatar
      Port kolourpaint away from Kdeprint::createPrintDialog · f906beb0
      David Faure authored
      Summary: This was the final step to port away from kdelibs4support.
      
      Test Plan: The print dialog still has the 3rd widget with 2 radiobuttons like before.
      
      Reviewers: broulik, andreagenor, tcanabrava, vkrause
      
      Reviewed By: vkrause
      
      Maniphest Tasks: T11576
      
      Differential Revision: https://phabricator.kde.org/D25601
      f906beb0
    • David Faure's avatar
      Port from KFileDialog to QFileDialog. · ea2d7440
      David Faure authored
      Summary:
      Tricky because of the embedded widget for save options.
      Reused the solution found in kuickshow.
      
      Since QFileDialog implements overwrite checking, kill all
      the custom code for doing the same.
      
      Test Plan: Save as (new file), save as (existing file)
      
      Reviewers: broulik, andreagenor, tcanabrava
      
      Reviewed By: tcanabrava
      
      Maniphest Tasks: T11576
      
      Differential Revision: https://phabricator.kde.org/D25482
      ea2d7440
  2. 27 Nov, 2019 1 commit
    • David Faure's avatar
      Porting away from NetAccess, step 1: code refactoring · d6ef2fb8
      David Faure authored
      Summary:
      * Split out the NetAccess::exists call from isFromExistingURL(bool),
      only one caller was passing true (the default value). Simpler to
      remove that bool and call both methods in that one location.
      
      * Provide a urlExists() method to wrap the calls to NetAccess::exists
      and call it from as many places as possible.
      
      Test Plan:
      Builds, I can open and save a file, but it would take time to figure
      out how to trigger all the changed code paths.
      
      Reviewers: broulik, vkrause
      
      Reviewed By: vkrause
      
      Maniphest Tasks: T11576
      
      Differential Revision: https://phabricator.kde.org/D25468
      d6ef2fb8
  3. 22 Nov, 2019 3 commits
  4. 28 Aug, 2019 1 commit
  5. 21 Aug, 2019 1 commit
    • Albert Astals Cid's avatar
      Fix crash when doing open recent · 326969aa
      Albert Astals Cid authored
      Summary:
      ==6212== Invalid read of size 8
      ==6212==    at 0x6B0FFB0: QUrl::QUrl(QUrl const&) (in /usr/lib/libQt5Core.so.5.13.0)
      ==6212==    by 0x53461BB: KRecentFilesAction::addUrl(QUrl const&, QString const&) (krecentfilesaction.cpp:159)
      ==6212==    by 0x1B53C7: kpMainWindow::addRecentURL(QUrl const&) (kpMainWindow_File.cpp:221)
      ==6212==    by 0x1B5BC3: kpMainWindow::open(QUrl const&, bool) (kpMainWindow_File.cpp:426)
      ==6212==    by 0x1B629D: kpMainWindow::slotOpenRecent(QUrl const&) (kpMainWindow_File.cpp:507)
      ==6212==    by 0x1BBEAA: QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QUrl const&>, void, void (kpMainWindow::*)(QUrl const&)>::call(void (kpMainWindow::*)(QUrl const&), kpMainWindow*, void**) (qobjectdefs_impl.h:152)
      ==6212==    by 0x1BBA10: void QtPrivate::FunctionPointer<void (kpMainWindow::*)(QUrl const&)>::call<QtPrivate::List<QUrl const&>, void>(void (kpMainWindow::*)(QUrl const&), kpMainWindow*, void**) (qobjectdefs_impl.h:185)
      ==6212==    by 0x1BB717: QtPrivate::QSlotObject<void (kpMainWindow::*)(QUrl const&), QtPrivate::List<QUrl const&>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (qobjectdefs_impl.h:414)
      ==6212==    by 0x6BEEB6F: QMetaObject::activate(QObject*, int, int, void**) (in /usr/lib/libQt5Core.so.5.13.0)
      ==6212==    by 0x5347959: KRecentFilesAction::urlSelected(QUrl const&) (moc_krecentfilesaction.cpp:210)
      ==6212==    by 0x5345B08: KRecentFilesActionPrivate::_k_urlSelected(QAction*) (krecentfilesaction.cpp:98)
      ==6212==    by 0x53475B7: KRecentFilesAction::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (moc_krecentfilesaction.cpp:96)
      ==6212==  Address 0x10be2b50 is 32 bytes inside a block of size 40 free'd
      ==6212==    at 0x48399AB: free (vg_replace_malloc.c:530)
      ==6212==    by 0x6A5D3D7: QMapDataBase::freeNodeAndRebalance(QMapNodeBase*) (in /usr/lib/libQt5Core.so.5.13.0)
      ==6212==    by 0x5348F66: QMapData<QAction*, QUrl>::deleteNode(QMapNode<QAction*, QUrl>*) (qmap.h:280)
      ==6212==    by 0x5348453: QMap<QAction*, QUrl>::remove(QAction* const&) (qmap.h:948)
      ==6212==    by 0x5346786: KRecentFilesAction::removeAction(QAction*) (krecentfilesaction.cpp:219)
      ==6212==    by 0x54F1DA9: KSelectAction::clear() (in /usr/lib/libKF5WidgetsAddons.so.5.61.0)
      ==6212==    by 0x534693B: KRecentFilesAction::clearEntries() (krecentfilesaction.cpp:249)
      ==6212==    by 0x5346AB8: KRecentFilesAction::loadEntries(KConfigGroup const&) (krecentfilesaction.cpp:261)
      ==6212==    by 0x1B538D: kpMainWindow::addRecentURL(QUrl const&) (kpMainWindow_File.cpp:216)
      ==6212==    by 0x1B5BC3: kpMainWindow::open(QUrl const&, bool) (kpMainWindow_File.cpp:426)
      ==6212==    by 0x1B629D: kpMainWindow::slotOpenRecent(QUrl const&) (kpMainWindow_File.cpp:507)
      ==6212==    by 0x1BBEAA: QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QUrl const&>, void, void (kpMainWindow::*)(QUrl const&)>::call(void (kpMainWindow::*)(QUrl const&), kpMainWindow*, void**) (qobjectdefs_impl.h:152)
      ==6212==  Block was alloc'd at
      ==6212==    at 0x483877F: malloc (vg_replace_malloc.c:299)
      ==6212==    by 0x6A5D798: QMapDataBase::createNode(int, int, QMapNodeBase*, bool) (in /usr/lib/libQt5Core.so.5.13.0)
      ==6212==    by 0x5348E0D: QMapData<QAction*, QUrl>::createNode(QAction* const&, QUrl const&, QMapNode<QAction*, QUrl>*, bool) (qmap.h:225)
      ==6212==    by 0x5348362: QMap<QAction*, QUrl>::insert(QAction* const&, QUrl const&) (qmap.h:726)
      ==6212==    by 0x5346707: KRecentFilesAction::addAction(QAction*, QUrl const&, QString const&) (krecentfilesaction.cpp:210)
      ==6212==    by 0x5346F26: KRecentFilesAction::loadEntries(KConfigGroup const&) (krecentfilesaction.cpp:307)
      ==6212==    by 0x1B48BF: kpMainWindow::setupFileMenuActions() (kpMainWindow_File.cpp:99)
      ==6212==    by 0x1ACA61: kpMainWindow::setupActions() (kpMainWindow.cpp:505)
      ==6212==    by 0x1ABD19: kpMainWindow::init() (kpMainWindow.cpp:218)
      ==6212==    by 0x1AB253: kpMainWindow::kpMainWindow() (kpMainWindow.cpp:67)
      ==6212==    by 0x196C6F: main (kolourpaint.cpp:118)
      
      Subscribers: tcanabrava
      
      Differential Revision: https://phabricator.kde.org/D23329
      326969aa
  6. 26 Apr, 2019 1 commit
  7. 25 Apr, 2019 1 commit
  8. 18 Mar, 2019 1 commit
  9. 14 Mar, 2019 1 commit
  10. 14 Feb, 2019 1 commit
  11. 05 Feb, 2019 1 commit
  12. 04 Feb, 2019 1 commit
  13. 02 Sep, 2018 1 commit
  14. 18 Jul, 2018 1 commit
  15. 19 Nov, 2017 1 commit
  16. 05 Feb, 2017 1 commit
  17. 28 Jan, 2017 1 commit
  18. 12 Nov, 2016 1 commit
  19. 07 Aug, 2016 1 commit
  20. 30 Apr, 2016 2 commits
  21. 25 Sep, 2015 2 commits
  22. 01 Aug, 2015 1 commit
    • Martin Koller's avatar
      Use KDE::icon() to find icons installed by kolourpaint · 92a96dda
      Martin Koller authored
      When run without the frameworks-integration plugin (e.g. in a non-
      KDE desktop environment), no tool icons are loaded, because
      QIcon::fromTheme() does not automatically search per-application
      icons. KDE::icon() finds these icons
      92a96dda
  23. 09 May, 2015 1 commit
  24. 08 Feb, 2015 2 commits
  25. 05 Oct, 2014 1 commit
  26. 04 Oct, 2014 1 commit
  27. 02 Oct, 2014 1 commit
  28. 01 Oct, 2014 7 commits