Commit 33bde19d authored by Johannes Zarl-Zierl's avatar Johannes Zarl-Zierl

HTML export: don't show theme entries without name.

On my installation I got some empty entries because I had some stale
empty directories within my theme directory. This commit changes the
behaviour to ignore unnamed themes entirely - having them show up as
empty entries in a drop down menu would be bad UX anyways.
parent e2902b77
......@@ -6,6 +6,8 @@
Even with the warning message it might give somebody a false sense of
security.
* Change: Don't display HTML export themes missing a name.
* Bugfix: Make sure tag groups are always added to tag list as well (Fixes #423334)
* Bugfix: Fix crash when changing the toolbar.
......
......@@ -536,6 +536,9 @@ void HTMLDialog::populateThemesCombo()
KConfig themeconfig(QString::fromLatin1("%1/kphotoalbum.theme").arg(themePath), KConfig::SimpleConfig);
KConfigGroup config = themeconfig.group("theme");
QString themeName = config.readEntry("Name");
// without the name, we can't show anything useful for the user to choose
if (themeName.trimmed().isEmpty())
continue;
QString themeAuthor = config.readEntry("Author");
m_themeAuthors << themeAuthor; // save author to display later
QString themeDefault = config.readEntry("Default");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment