Commit 45970cfa authored by Johannes Zarl-Zierl's avatar Johannes Zarl-Zierl

Review TODO/FIXME comments

MainWindow: before deleting the annotation dialog, make sure to close
it. A quick test showed no crash when deleting it right away, but better
be save than sorry (in case this ever changes).
parent 33bde19d
......@@ -284,7 +284,6 @@ AnnotationDialog::Dialog::Dialog(QWidget *parent)
setupActions();
shortCutManager.setupShortCuts();
// WARNING layout->addWidget(buttonBox) must be last item in layout
layout->addWidget(buttonBox);
}
......
......@@ -1044,7 +1044,12 @@ void MainWindow::Window::showBrowser()
void MainWindow::Window::slotOptionGroupChanged()
{
// FIXME: What if annotation dialog is open? (if that's possible)
// deleting the dialog would close it anyways, but I feel that we should not
// depend on this behaviour lest we want it to crash:
if (m_annotationDialog) {
m_annotationDialog->close();
}
delete m_annotationDialog;
m_annotationDialog = nullptr;
DirtyIndicator::markDirty();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment