Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit 6ab2d913 authored by Eoin O'Neill's avatar Eoin O'Neill 🍀

Fix Rendering Fail on First Render After Switching to video/ogg Container Type.

Quick fix to rendering changes not registering properly after changing container
formats. Comment is added for the time being since the solution is not immediately
clear.

NOTE: Rendering window still needs simplification, too much state is leading to a
fickle codebase.

BUG:421658
parent 24f5bf41
......@@ -321,6 +321,18 @@ void KisDlgAnimationRenderer::selectRenderType(int index)
m_page->videoFilename->setFileName(videoFileName);
m_wantsRenderWithHDR = (mimeType == "video/mp4") ? m_wantsRenderWithHDR : false;
{ // We've got to reload the render settings to account for the user changing render type without configuration.
// If this is removed from the configuration, ogg vorbis can fail to render on first attempt. BUG:421658
// This should be revisited at some point, too much configuration juggling in this class makes it error-prone...
KisConfig cfg(true);
KisPropertiesConfigurationSP settings = cfg.exportConfiguration("VIDEO_ENCODER");
getDefaultVideoEncoderOptions(mimeType, settings,
&m_customFFMpegOptionsString,
&m_wantsRenderWithHDR);
}
}
void KisDlgAnimationRenderer::selectRenderOptions()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment