CCBUG:404742

This patch has two parts:

1) KisShapeLayer should block the updates of the shape-canvas.
   When shapes are added to the layer, they initiate shape
   manager updates. That is not what we want, because all the
   rendered pixel data has already been copied in initShapeLayer()
   call.

2) Add a sanity check in KisDocument::initiateSavingInBackground().
   Theoretically, there should be no pending updates after cloning
   operation. But if they still appear somehow (which is a bug),
   just force them wait until they complete their execution.

BUG:404976
CCBUG:404742

This built for me, on my test vm...

This automatically adds the Needs Review label to new merge requests,
and also gives a basic formalities and required info list.

cc: @rempt, @dkazakov

[2019-04-22T08:29:04.736Z] Scanning dependencies of target KisCompositionBenchmark
[2019-04-22T08:29:04.993Z] [ 43%] Building CXX object benchmarks/CMakeFiles/KisCompositionBenchmark.dir/kis_composition_benchmark.cpp.o
[2019-04-22T08:29:07.539Z] In file included from /usr/include/boost/random/detail/integer_log2.hpp:19,
[2019-04-22T08:29:07.539Z]                  from /usr/include/boost/random/detail/large_arithmetic.hpp:19,
[2019-04-22T08:29:07.539Z]                  from /usr/include/boost/random/detail/const_mod.hpp:23,
[2019-04-22T08:29:07.539Z]                  from /usr/include/boost/random/detail/seed_impl.hpp:26,
[2019-04-22T08:29:07.539Z]                  from /usr/include/boost/random/mersenne_twister.hpp:30,
[2019-04-22T08:29:07.539Z]                  from /home/jenkins/workspace/Extragear/krita/kf5-qt5 SUSEQt5.10/benchmarks/kis_composition_benchmark.cpp:92:
[2019-04-22T08:29:07.539Z] /usr/include/boost/pending/integer_log2.hpp:7:59: note: #pragma message: This ...

When creating a selection we should initialize default
bounds for the pixel selection correctly.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Maybe this'll inspire people to check Jenkins more often...

In some places we static_cast our event into QEnterEvent, so
we should prepare a correct object for that.

BUG:405732

Enable fractional DPI scaling on Windows

See merge request kde/krita!2

While trying to fix this, I noticed some of the cause of the "color fighting" was because of the large amount of signals that were being emitted and processed with the stroke and fill widgets for vector controls.

I tried to help limit all these signals with a couple compressors on the fill and stroke config widgets.

After adding those compressors, the state of the widgets were not updating right when changing selection. I then spent some time modifying the logic to get the tool options for the stroke and fill to update correctly.

One thing to point out that I changed was how a "None" fill is calculated. Previously "None" was only calculated if a stroke object didn't exist (see the wrapper.type() ).

I also modified the UI to select "none" type if the border size is set to 0. You cannot select a "0" border width if you have a solid border selected on the UI now. It will only go down to 1px now. The UI seemed to get in an odd state if you made a border 0px, then de-selected the object, then re-select it.

BUG:404975
Differential Revision: https://phabricator.kde.org/D20500
See merge request kde/krita!10

Tusooa Zhu authored Apr 20, 2019 and Dmitry Kazakov committed Apr 20, 2019

1) Add two paint layers. Assume they are "Layer 1" and "Layer 2," from bottom to top.
2) Add a clone layer copying from "Layer 1." Assume the clone is called "Layer 3."
3) Move "Layer 3" below "Layer 1."
4) In the layer docker, click on "Layer 1."
5) Hold Ctrl, click on "Layer 2."
6) Right click, then select "Remove Layer."

Expected: Layer 1 and Layer 2 are removed. Layer 3 turns into a Paint Layer.

7) Undo.

Expected: Layer 1 and Layer 2 are restored. Layer 3 goes back into a Clone Layer.

BUG:397836
Reviewers: #krita, dkazakov
Reviewed By: #krita, dkazakov
Subscribers: dkazakov
Tags: #krita
Differential Revision: https://phabricator.kde.org/D20314

This gives a better UI (not overly large) for screens with scale factor
set to *.5x.

This option is enabled by default. It is currently only available on
Windows.

This adds a series of patches related to QTBUG-53022 [1] for Windows to
allow enabling support for fractional DPI scaling.

These series of patches adds the option
`QGuiApplication::setHighDpiScaleFactorRoundingPolicy` to control how
the DPI scale factor is rounded (or not), which can also be overridden
by the environment variable `QT_SCALE_FACTOR_ROUNDING_POLICY`. The
options include:

- Round: Round up for .5 and above.
- Ceil: Always round up.
- Floor: Always round down.
- RoundPreferFloor: Round up for .75 and above.
- PassThrough: Don't round.

Currently the default option is explicitly set to `Round` to obtain the
old behaviour (where 1.5x is rounded to 2x).

Ref:
- https://bugreports.qt.io/browse/QTBUG-53022
- https://codereview.qt-project.org/157173
- https://codereview.qt-project.org/157174
- https://codereview.qt-project.org/161334
- https://codereview.qt-project.org/163219
- https://codereview.qt-project.org/176381
- https://coderev...

This adds a patch for Windows to fix moving windows between screens with
different DPI scaling.

Ref: https://codereview.qt-project.org/248822

Genius tablet tested, works fine without the function referenced from this lines.

This kinds of proves that nobody actually use the Touch Docker.

BUG:406666

QColorDialog is translated as part of Qt, so it's likely the rest
of the dialog won't be translated either. We can't do anything about
that.

BUG:406664

Update original repository link to our gitlab instance, yay

See merge request kde/krita!1

This fixes up e83e8779.

Summary:
This commit introduces the behaviour of Clone Brush
that allows for always starting a new stroke
as if the offset wasn't set yet, which means it always
starts from the same source/origin point.
Usecases: painting multiple leaves, flowers, crosses etc.
in less regular way than what could be created with regular
Clone Brush.

BUG:402559

Test Plan:
- save and load brush with and without the new option enabled
- use the same brush with and without the new option enabled
- use both versions without setting the origin
- switch between enabled and disabled option after setting the origin
- check whether the tooltip works

Reviewers: #krita, dkazakov

Reviewed By: #krita, dkazakov

Subscribers: dkazakov

Tags: #krita

Differential Revision: https://phabricator.kde.org/D20653

Some tablet devices don't pass barrel-button clicks via tablet API.
If you have such a device, you can try activate this workaround.
Krita will try to read right- and middle-button clicks from the
mouse events stream. It may or may not work on your device
(depends on the tablet driver implementation).

BUG:399585
CC:kimageshop@kde.org

The user can switch pressure sensitivity level in the driver,
which will make our saved values invalid (this option is
provided by Wacom drivers for compatibility reasons, and
it can be adjusted on the fly)

BUG:391054

Upstream bug: https://bugreports.qt.io/browse/QTBUG-62103

A previous attempt was made in D1977 [1] but it didn't work properly.
The patch `0003-Hack-for-fullscreen-workaround.patch` only partly hid
the issue and the issue has resurfaced since this patch was removed.

This commit actually enables Qt's workaround with an additional patch
from Qt 5.13 [2]. The workaround adds a 1px border around the window. An
additional hack is added to hide three of the borders, though we can't
hide all four borders since the bug will return. This currently leaves
the bottom border visible as a compromise.

This workaround is not active when ANGLE is being used. If anyone is
annoyed by the 1px border, they may consider switching to ANGLE.

[1]: https://phabricator.kde.org/D1977
[2]: https://codereview.qt-project.org/246155

Differential Revision: https://phabricator.kde.org/D20657

When we have no input focus, we cannot track keyboard key press/release
events (for security reasons). But at the same time, the user can easily
hover Krita canvas, and we should show him somewhat correct cursor.

So here we just try to fetch at least basic modifiers state from mouse/
tablet events. It is perfectly allowed by OS.

Yes, this workaround will not fetch custom modifiers like V-key switch
for straight lines. But I don't think anyone will worry about it.

BUG:369305