CCBUG:404742

This patch has two parts:

1) KisShapeLayer should block the updates of the shape-canvas.
   When shapes are added to the layer, they initiate shape
   manager updates. That is not what we want, because all the
   rendered pixel data has already been copied in initShapeLayer()
   call.

2) Add a sanity check in KisDocument::initiateSavingInBackground().
   Theoretically, there should be no pending updates after cloning
   operation. But if they still appear somehow (which is a bug),
   just force them wait until they complete their execution.

BUG:404976
CCBUG:404742

Because of typo files were added to Recent Documents
every time it wasn't needed and not added when it was
needed. This commit makes adding files to Recent Documents
consistent with the intent.

BUG:405364

Summary:
Before this patch, when you forced Krita to load file in
unknown format, it showed uncancelled progress bar and
showed the file in Recent Documents.
It happened when you dragged and dropped file to the
welcome screen or import animation frames or use Open->File
or Open -> Recent Files.
Progress bars were visible only when some image was opened.
This commit cancels progress bars and make sure unloadable
files are not added to Recent Documents.

CCBUG:402625

Test Plan:
1. Create an unloadable file. Can be "touch a".
2. Load it using one of the ways mentioned above
3. After loading, there is an error message. Click ok.
4. If you used Import Animation Frames, look at the bottom
of Krita window.
- before: progress bar still "loading"
- now: no progress bar visible
5. If you used other option, create a new file or open
something else, and you'll see the same effect.
6. Look at Recent Documents.
- before: unloadable file added to list
- now: no unloadable file added to list
(beside the ones that were aleady there after testing)

Reviewers: #krita, rempt

Reviewed By: #krita, rempt

Tags: #krita

Differential Revision: https://phabricator.kde.org/D19611

Summary:
Saving Mirror Tool state to KRA file, wished for in bug 339515.

BUG:339515

Test Plan:
  - Set up mirror lines. Save, close and reopen. Expected result: the mirror lines and options should be automatically set and activated.
  - Open multiple files, with and without mirror lines. Expected result: Every open document should have separate configuration. Toolbar actions should affect only the currently active view.

Reviewers: #krita, rempt

Reviewed By: #krita, rempt

Subscribers: rempt

Tags: #krita

Differential Revision: https://phabricator.kde.org/D18254

Autosaves of unnamed files can now be made visible (the dot
is omitted).

The number of backups kept can be set, the default is 1 again.
The location of backups can be chosen: same folder as the file,
$HOME or the tempdir.
The suffix used for the backup file can be chosen. There is
a validator to weed out potentially hazardous characters.

CCMAIL:kimageshop@kde.org
BUG:404395
Differential Revision: https://phabricator.kde.org/D19115

We can now log important events to a krita.log file. It is completely
independent of qDebug, and only meant for those actions that we know
users often get wrong or have problems with. Right now, it logs
creating, loading, exporting and saving a file, and switching between
the smoothing options.

The krita.log file is NOT automatically uploaded or shared or anything
like that. The header that explains this is translated so users can
see that for themselves.

We rotate 10 sessions in the log file, so even if the user starts Krita
a few times after having a problem, we should still be able to review
the problematical session.

The logging api is pretty simple: a static KisUsageLogger::log method
that writes a timestamp, and a KisUsageLogger::write method that writes
an informational line without a timestamp.

Note that the logger is created and torn down in the main function:
this means that the location is GenericDataLocation, not AppDataLocation.

CCMAIL:kimageshop@kde.org

This patch also changes a few things about how new images are created by
making use of enums in the newImage interface. I think I've also
addressed the background opacity in a way that makes more sense and also
allows for users to tweak background opacity settings after creating a
new image. Lastly, while using RASTER or FILL backgrounds, if you create
more than one layer the background layer will start locked. This helps
to prevent accidental painting on initial starting background layers.

Differential Revision: https://phabricator.kde.org/D15540

Differential Revision: https://phabricator.kde.org/D15522

We should always initialize KisDocumentUndoAdapter in the
image :)

BUG:398730

KUndo2Stack doesn't emit any signals if it is empty, so
we should take care about that separately.

1) When we recover some file, then discard it by closing
   without saving, then this file should be removed.

2) When saving a file with a different name, the autosave
   files for the old name should be removed.

3) KisMainWindow should not touch url text and recovered
   state of the file, it is correctly set by the document
   itself now

T8646

A KoShapeControllerBase (formerly known as KoShapeBasedDocumentBase)
is necessary otherwise KoShapeController::resourceManager might return
0, which causes asserts and crashes. So, pass the KoShapeControllerBase
down all the way from KisShapeLayer and KisShapeSelection.

This fixes the KisKraSaverTest

T8646

T8646

T8646

T8646

This also adds a safe assert that fires whenever we create a
read/write KisConfig object in a non-gui thread.

There were two problems:

1) modifiedAfterAutosave should be reset false every time
   we mark the image as clean. Otherwise it may keep the
   old value

2) modifiedAfterAutosave value should be used **only** for
   the autosave slot entry. For restarting the time we should
   ask the timer itself

BUG:393266

1) KisDocument is a 'model' of global color
2) KisPaintingAssistantsDecoration is a 'controller' of global color
3) KisPaintingAssistant is a 'view' of global color

Decoration is responsible for updating the global color cache
of global color in all the assistants.

Summary:
This is a patch on top of my custom colors patch.

The shared/global assistant color for painting assistants is stored outside of the assistant data model. Because of this I had to add a new property to save to in the KRA saver and loader.

I also had to fix up a few initialization areas in the UI so the loaded values didn't get wiped out.

I also removed a couple "legacy" comments in the KRA saver that got me confused. boud confirmed that those notes were in the calligra days

Test Plan:
Have multiple assistants. A couple with a shared color and one with a custom color.

Saved and loaded the file and made sure it kept the same value.

Reviewers: #krita, dkazakov

Subscribers: dkazakov

Tags: #krita

Differential Revision: https://phabricator.kde.org/D13437

1) KisDocument is a 'model' of global color
2) KisPaintingAssistantsDecoration is a 'controller' of global color
3) KisPaintingAssistant is a 'view' of global color

Decoration is responsible for updating the global color cache
of global color in all the assistants.

Summary:
This is a patch on top of my custom colors patch.

The shared/global assistant color for painting assistants is stored outside of the assistant data model. Because of this I had to add a new property to save to in the KRA saver and loader.

I also had to fix up a few initialization areas in the UI so the loaded values didn't get wiped out.

I also removed a couple "legacy" comments in the KRA saver that got me confused. boud confirmed that those notes were in the calligra days

Test Plan:
Have multiple assistants. A couple with a shared color and one with a custom color.

Saved and loaded the file and made sure it kept the same value.

Reviewers: #krita, dkazakov

Subscribers: dkazakov

Tags: #krita

Differential Revision: https://phabricator.kde.org/D13437

(cherry picked from commit 68b57f8b)

Now the strategy is the following:

1) Wait default time period for autosave
2) Check if the image is busy
3) If the image is not busy, just save :)
4) If the image is busy, do three tries with emergency
   interval (10 ms each). If all the tries are failed,
   post a background stroke which will run after the current
   stroke and initiate the autosave.

Now the strategy is the following:

1) Wait default time period for autosave
2) Check if the image is busy
3) If the image is not busy, just save :)
4) If the image is busy, do three tries with emergency
   interval (10 ms each). If all the tries are failed,
   post a background stroke which will run after the current
   stroke and initiate the autosave.

The user might work with the current filters or something. We
shouldn't disturb his actions right in the middle of the oparation.

We shouldn't regenerate the projection of the image, when cloning
we clone all the projections as well.

WARNING: this patch is extremely dangerous! If you happen to see some
         loss while saving, please first try to revert this patch!

CCBUG:392229

We should ensure all the time-based nodes finished updating before
the image gets saved.

BUG:392229

Setting it to OK unconditionally is wrong...

BUG:392413

This reverts commit 40b98a4e.