1. 23 Aug, 2019 2 commits
  2. 22 Aug, 2019 4 commits
  3. 21 Aug, 2019 4 commits
  4. 20 Aug, 2019 3 commits
    • Dmitry Kazakov's avatar
      Fix random crash when swap-file location has not got enough disk space · ac020c6c
      Dmitry Kazakov authored
      Lockfree hash table iterators have a requirement of no-concurrent-inserts,
      so we must ensure that the swapper and pooler do *not* insert any tiles,
      why iteration is in progress. KisTileDataStore::trySwapTileData() is called
      exactly from inside of the swapper iteration loop.
      If we break this requirement, the insert operation may request a table
      migration, and the iterator will continue iterating the old, invalid,
      The actual crash happened after line 'item = iter->next()' in
      KisTileDataSwapper::pass(), which actually returned value '1', meaning
      "Redirect". Address 0x0000000000000029 is a fetch of
      KisTileData::m_mementoFlag (offset 0x28) with 'this' set to 0x01 :)
    • Dmitry Kazakov's avatar
      Fix ConcurrentMap::migrationInProcess() to handle initialization value (0) properly · 2ffdc5b0
      Dmitry Kazakov authored
      Job coordinator of the table may have three states:
      1) jobCoordinator == 0: the table was initialized, but no migration
         has ever been started for this table
      2) jobCoordinator > 1: a table migration is in progress right now. The
         caller should join *jobCoordinator to help finishing the migration.
      3) jobCoordinator == 1: the table migration has been finished. It means
         that the table doesn't have any values in it anymore.
      The patch actually fixes the map to consider case 1 as a situation, when
      there is no migration.
    • Script Kiddy's avatar
      GIT_SILENT made messages (after extraction) · 5e125565
      Script Kiddy authored
  5. 19 Aug, 2019 2 commits
  6. 18 Aug, 2019 1 commit
  7. 17 Aug, 2019 4 commits
    • Karl Ove Hufthammer's avatar
      Change relative widths of the tablet tester and status messages widgets · da7f6598
      Karl Ove Hufthammer authored
      The status message textedit field was too narrow to show a status
      message without breaking it over several lines. The relative widths of
      the tablet tester painting area and the textedit field have therefore
      been changed to make the latter wider, so that there’s enough horizontal
      space for the status messages. The sizeHint for the tablet tester area
      also had to be changed to make the dialogue wide enough.
    • Karl Ove Hufthammer's avatar
      Set minimum size for the tablet tester area · 1706af33
      Karl Ove Hufthammer authored
      When the dialogue was resized to be very small, so that there were
      hardly any space for the tablet tester painting area, Krita would
      freeze. Now, a minumum size of 150 × 150 pixels ensures that this
      never happens.
    • Karl Ove Hufthammer's avatar
      Add size hints to tablet tester widget (for better dialogue size) · 8b418f1a
      Karl Ove Hufthammer authored
      The tablet tester dialogue’s ‘preferred’ size is being overridden
      by KoDialog, resulting in a very small dialogue box, with a tiny
      painting area for testing the tablet. Now we add a sizeHint for this
      area, so that the dialogue automatically gets a reasonable size.
      The width and height values for the sizeHint was chosen so that
      they correspond to the size the widget would have had if KoDialog
      didn’t override the preferred window size.
    • Boudewijn Rempt's avatar
  8. 16 Aug, 2019 3 commits
  9. 15 Aug, 2019 9 commits
  10. 14 Aug, 2019 7 commits
    • Agata Cacko's avatar
      Fix transform worker tests failing because of NN · f54b48bb
      Agata Cacko authored
      Tests for transform worker were failing because the result files
      contained results from the old version of NN/Box filter.
      Since I changed it a bit in 57c3194c
      the old result files were no longer valid.
      This commit updates the result files.
      Also since the execution of the filter on one of the images
      resulted in a transparent pixel in the location that the previous filter
      had a non-transparent pixel, it changed the size of the resulting image
      so it didn't pass the test partially because of the change in size.
      Since other tests don't check the size, I removed the checks in this
      test, too. (Because of the transparency in the test image, it is possible
      that the resulting image will have a different size even though it is
      not scaled in this dimension.)
    • Agata Cacko's avatar
      Fix curve change despite 'Use same curve' checked · 47a57162
      Agata Cacko authored
      Before this commit, if you have a preset like Fill_circle
      that has "Use the same curve" checkbox checked and you were
      clicking on other sensors, the curve would be back to the default
      curve (the one that other sensors had) if you switch back and forth
      between some sensors (like Pressure -> X-Tilt-> Pressure).
      Also before this commit if you have the default uprising curve
      and you switched Rotation -> Tilt elevation, the curve would change.
      This commit fixes both behaviours (first by adding transferCurve(),
      second by switching the line in kis_curve_widget).
      This commit also includes two slot functions instead of one function
      that were used as a slot for two different signals. It helps with
      debugging signals and keeping stuff clear and ordered.
      There is one problem left: if you switch Tilt elevation -> Distance
      (using the 'hill' curve), the preset is set to modified even though
      the curve doesn't change.
    • Karl Ove Hufthammer's avatar
    • Dmitry Kazakov's avatar
      Fix crash when creating a bezier curve · 1e5db24a
      Dmitry Kazakov authored
      The patch basically makes KoShapeManager thread safe by adding
      a simple mutex. The problem is that both,
      KoCreatePathTool::Private::endPointAtPosition() and
      KisRepaintShapeLayerLayerJob access the shape manager in different
      threads concurrently, which obviously causes a crash.
    • Dmitry Kazakov's avatar
      Remove update compressor in KoShapeManager · a5ef0656
      Dmitry Kazakov authored
      Anyway we always recalculate tree before any access to the shapes
    • Karl Ove Hufthammer's avatar
      Remove double space in opacity, flow and size sliders on main toolbar · 4790c612
      Karl Ove Hufthammer authored
      The sliders had two spaces (e.g. ‘Opacity:  75%’) instead of one
      (‘Opacity: 75%’). The extra space seems to be added by accident.
      They were at least not present in the original review board request
      (https://git.reviewboard.kde.org/r/122946/), only in the actual commit
    • Dmitry Kazakov's avatar
      Fix Shift and Alt modifiers in OUtline Selection Tool · bd06296f
      Dmitry Kazakov authored
      We should pass the keys to the tool, even when it is not active
      to make sure its keyPress/keyRelease methods work fine. To make
      it works we need to initialize the environment correctly in
  11. 13 Aug, 2019 1 commit
    • Pino Toscano's avatar
      i18n fixes · c5f53ebd
      Pino Toscano authored
      - translate UI strings
      - fix passing arguments to i18n