1. 13 Jan, 2021 1 commit
  2. 28 Aug, 2020 1 commit
    • Dmitry Kazakov's avatar
      Fix Divide, Vivid Light and Parallel blending modes handle negative layer colors · e488caa3
      Dmitry Kazakov authored
      Sometimes, when converting RGBAF32<->LabAF32 colorspaces, LCMS may
      generate pixels with "slightly negative" values, like -1e-7. The
      mentioned blending modes couldn't handle that correclty, because
      they only checked for zero'ness.
      
      Now before doing a division operation we:
      
      1) check if the value isn't too small
      2) check it the value is positive
      
      NOTE: there are still a lot of blendign modes from "Binary" section
            that still don't handle that correctly. But, speaking truly, I
            don't think we should actually enable these blending modes for
            F32 color spaces :)
      
      BUG:353204
      e488caa3
  3. 12 Aug, 2020 1 commit
  4. 27 Jul, 2020 1 commit
  5. 02 Jul, 2020 1 commit
  6. 16 Apr, 2020 1 commit
  7. 13 Apr, 2020 1 commit
  8. 06 Apr, 2020 1 commit
  9. 02 Dec, 2019 1 commit
  10. 16 Oct, 2019 1 commit
  11. 30 Sep, 2019 1 commit
  12. 12 Sep, 2019 1 commit
  13. 05 Sep, 2019 1 commit
  14. 19 Jul, 2019 1 commit
  15. 17 Jul, 2019 1 commit
  16. 10 Jul, 2019 1 commit
    • Halla Rempt's avatar
      Fix warning -Wclass-memaccess · ca741341
      Halla Rempt authored
      In file included from /home/boud/dev/krita/libs/pigment/compositeops/KoCompositeOpCopy2.h:26,
                       from /home/boud/dev/krita/libs/pigment/colorspaces/KoAlphaColorSpace.cpp:35:
      /home/boud/dev/krita/libs/pigment/compositeops/KoCompositeOpBase.h: In instantiation of ‘void KoCompositeOpBase<_CSTraits, _compositeOp>::genericComposite(const KoCompositeOp::ParameterInfo&, const QBitArray&) const [with bool useMask = true; bool alphaLocked = true; bool allChannelFlags = true; _CSTraits = KoColorSpaceTrait<half, 1, 0>; _compositeOp = AlphaColorSpaceMultiplyOp<KoColorSpaceTrait<half, 1, 0> >]’:
      /home/boud/dev/krita/libs/pigment/compositeops/KoCompositeOpBase.h:67:72:   required from ‘void KoCompositeOpBase<_CSTraits, _compositeOp>::composite(const KoCompositeOp::ParameterInfo&) const [with _CSTraits = KoColorSpaceTrait<half, 1, 0>; _compositeOp = AlphaColorSpaceMultiplyOp<KoColorSpaceTrait<half, 1, 0> >]’
      /home/boud/dev/krita/libs/pigment/compositeops/KoCompositeOpBase.h:58:10:   required from here
      /home/boud/dev/krita/libs/pigment/compositeops/KoCompositeOpBase.h:110:27: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘KoCompositeOpBase<KoColorSpaceTrait<half, 1, 0>, AlphaColorSpaceMultiplyOp<KoColorSpaceTrait<half, 1, 0> > >::channels_type’ {aka ‘class half’} with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]
                           memset(dst, 0, pixel_size);
                           ~~~~~~^~~~~~~~~~~~~~~~~~~~
      ca741341
  17. 06 Jul, 2019 1 commit
    • Dmitry Kazakov's avatar
      Disable AVX optimizations for 32-bit composite ops · cd5450a8
      Dmitry Kazakov authored
      They cause artifacts and we don't have a fix yet :(
      
      CCBUG:404133
      
      Note from the committer:
      This commit was initially made on krita/4.2 branch.
      However between 4.2.1 and 4.2.2 the stable branch was
      reconstructed, which caused all commits that were exclusively
      on the previous krita/4.2 (and not on master) to be missing.
      
      The previous commit hash: d3e4c3aa
      
      Also regarding the artifacts: it never worked, optimization were
      enabled during the creamy flow implementation, but they never should
      be enabled until someone fix them properly.
      cd5450a8
  18. 10 May, 2019 1 commit
  19. 10 Apr, 2019 1 commit
  20. 15 Mar, 2019 1 commit
    • Miguel Lopez's avatar
      Fix to Modulo Shift Continuous · 06281313
      Miguel Lopez authored
      Summary:
      Before, I have made several test where white layer wouldn't change anything for all modulo mode to verify that they all work as expected. Then over time, I realized that at this point, modulo shift continuous just doesn't make sense from the functional point of view and the former test just don't take into account of that.
      
      The problem with older version: If you set 0 on the blend layer using modulo shift continuous, it assume that there's a shift because of inversion. However, 0 shift is 0 shift as in there shouldn't be any changes at all.
      
      This patch fix that issue from the functional point of view.
      
      Reviewers: #krita
      
      Tags: #krita
      
      Differential Revision: https://phabricator.kde.org/D19640
      06281313
  21. 23 Feb, 2019 1 commit
  22. 19 Feb, 2019 1 commit
  23. 07 Feb, 2019 1 commit
  24. 01 Feb, 2019 2 commits
  25. 28 Jan, 2019 1 commit
  26. 23 Jan, 2019 1 commit
    • Wolthera van Hövell's avatar
      Temporarily push D18467 · e3c2f5be
      Wolthera van Hövell authored
      This patch changes the way how opacity and flow interact. This can mean
      that a lot of presets work way differently from before. Therefore artists
      need to test so we can get some feedback on how the patch feels.
      
      For more information, and to give feedback, check https://phabricator.kde.org/T8576
      
      This is so that artists can test it via the nightly builds.
      
      We'll try to revert it on Monday 28th of January.
      
      Patch by William Brown.
      
      Note: We still need to do a proper code review!
      
      CCMAIL:kimageshop@kde.org
      Ref T8576
      e3c2f5be
  27. 07 Jan, 2019 1 commit
  28. 12 Oct, 2018 1 commit
  29. 07 Oct, 2018 1 commit
  30. 29 Sep, 2018 1 commit
  31. 10 Jul, 2018 2 commits
  32. 26 Jun, 2018 1 commit
    • Miguel Lopez's avatar
      Quadratic Blending Modes · 563269c9
      Miguel Lopez authored
      Summary:
      During the creation of Quadratic Blending Modes, I have did the following:
      
        - Add new category suitable for quadratic blending modes
       -  I copied and paste existing codes, and created new codes used to calculate blending of images accordingly to the Pegtop formula reference sheet
      - I have tested the 4 new blending modes, and keep adjusting until the blending modes matches that of the Pegtop blending modes
      
      -----
      - Before the testing plan, find a way to make freeze and heat with acceptable coding. Reflect Blend Mode has now been solved.
      
      Test Plan:
      - Have artists find usage of quadratic blend modes, and see if they find the blending modes useful
      - Test results of quadratic blend modes with existing programs (As far as I"m concerned, only reflect and glow are available for testing)
      -If all seem sounds, and ready to go, then maybe it can be patched in Krita
      
      Reviewers: #krita, dkazakov
      
      Subscribers: dkazakov
      
      Tags: #krita
      
      Differential Revision: https://phabricator.kde.org/D13383
      563269c9
  33. 15 Jun, 2018 1 commit
    • Miguel Lopez's avatar
      Quadratic Blending Modes · 41c72fc7
      Miguel Lopez authored
      Summary:
      During the creation of Quadratic Blending Modes, I have did the following:
      
        - Add new category suitable for quadratic blending modes
       -  I copied and paste existing codes, and created new codes used to calculate blending of images accordingly to the Pegtop formula reference sheet
      - I have tested the 4 new blending modes, and keep adjusting until the blending modes matches that of the Pegtop blending modes
      
      -----
      - Before the testing plan, find a way to make freeze and heat with acceptable coding. Reflect Blend Mode has now been solved.
      
      Test Plan:
      - Have artists find usage of quadratic blend modes, and see if they find the blending modes useful
      - Test results of quadratic blend modes with existing programs (As far as I"m concerned, only reflect and glow are available for testing)
      -If all seem sounds, and ready to go, then maybe it can be patched in Krita
      
      Reviewers: #krita, dkazakov
      
      Subscribers: dkazakov
      
      Tags: #krita
      
      Differential Revision: https://phabricator.kde.org/D13383
      41c72fc7
  34. 22 May, 2018 1 commit
  35. 15 May, 2018 1 commit
    • Ivan Yossi's avatar
      KisBrushMaskSimilarityTest: · db1ebe82
      Ivan Yossi authored
      implement tester for mask generator similarity, scalar implementation
      vs vectorized Vc implementation.
      db1ebe82
  36. 02 May, 2018 1 commit
  37. 28 Dec, 2017 1 commit
  38. 23 Dec, 2017 1 commit