From 694ae76f569931caa2e9faf7274ea971cd80104d Mon Sep 17 00:00:00 2001 From: Reinold Rojas Date: Mon, 25 Oct 2021 17:03:21 -0400 Subject: [PATCH 1/2] Fix flickering in line tool preview Before this commit the line tool preview would flicker when using tablets . This commit fixes that by making the line tool preview only update when the cursor moves the minimum amount. --- plugins/tools/basictools/kis_tool_line.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/tools/basictools/kis_tool_line.cc b/plugins/tools/basictools/kis_tool_line.cc index 24bc6a2993..b481e50ad1 100644 --- a/plugins/tools/basictools/kis_tool_line.cc +++ b/plugins/tools/basictools/kis_tool_line.cc @@ -241,8 +241,9 @@ void KisToolLine::continuePrimaryAction(KoPointerEvent *event) m_longStrokeUpdateCompressor.stop(); m_strokeUpdateCompressor.start(); m_lastUpdatedPoint = pos; - } else if (updateDistance > 1) { + } else if (updateDistance > 1 && !m_strokeUpdateCompressor.isActive() && !m_longStrokeUpdateCompressor.isActive()) { m_longStrokeUpdateCompressor.start(); + m_lastUpdatedPoint = pos; } } -- GitLab From b9b45e86668dd5d784082bb7efdf337b8ec0d28a Mon Sep 17 00:00:00 2001 From: Reinold Rojas Date: Mon, 25 Oct 2021 18:41:34 -0400 Subject: [PATCH 2/2] Decrease wait time to render line tool preview BUG:411768 --- plugins/tools/basictools/kis_tool_line.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/tools/basictools/kis_tool_line.cc b/plugins/tools/basictools/kis_tool_line.cc index b481e50ad1..712738315a 100644 --- a/plugins/tools/basictools/kis_tool_line.cc +++ b/plugins/tools/basictools/kis_tool_line.cc @@ -50,8 +50,8 @@ KisToolLine::KisToolLine(KoCanvasBase * canvas) m_helper(new KisToolLineHelper(m_infoBuilder.data(), canvas->resourceManager(), kundo2_i18n("Draw Line"))), - m_strokeUpdateCompressor(500, KisSignalCompressor::POSTPONE), - m_longStrokeUpdateCompressor(1000, KisSignalCompressor::FIRST_INACTIVE) + m_strokeUpdateCompressor(200, KisSignalCompressor::POSTPONE), + m_longStrokeUpdateCompressor(750, KisSignalCompressor::FIRST_INACTIVE) { setObjectName("tool_line"); -- GitLab