Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Krita Krita
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Bugzilla
    • Bugzilla
  • Merge requests 77
    • Merge requests 77
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • GraphicsGraphics
  • KritaKrita
  • Merge requests
  • !1361

Fix 303151: Reset button and saving the state for the digital color mixer.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bourumir Wyngs requested to merge bourumir/krita:bourumir/303151-digital-color-mixer-reset into master Mar 06, 2022
  • Overview 5
  • Commits 3
  • Pipelines 8
  • Changes 2

This path addresses the bug 303151 by adding the reset button, to reset settings of this color mixer to defaults, and also by saving and restoring the settings or this tool inside the workspace context.

Saving and restoring is done automatically when the workspace is saved or restored, without the need of any further action form the user. This is done by capturing our signals for saving and restoring the workspace and then calling setPrefixedProperties on the passed instance of the workspace. We already have the functionality to serialize colors that I have reused.

I verified that the change builds and works as expected. I am under impression that this path should provide the functionality requested buy 303151 and its closed duplicates.

Edited Mar 12, 2022 by Bourumir Wyngs
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bourumir/303151-digital-color-mixer-reset