Skip to content

NEEDS TESTING: "fix" HSL transformation for white and black images

Dmitry Kazakov requested to merge kazakov/custom-hsv-filter into master

The patch tries to address this bug: https://bugs.kde.org/show_bug.cgi?id=411863

Basically, the transformation is substituted with HCL transformation, but with clever sliding on the edges of the rhombus. I need people's input, whether the transformation is still useful for painters.

Now it looks almost like "Hue/Saturation/Luma" (it also uses chroma instead of saturation), but with a different approach to calculation of 'L' channel :)

Test Plan

Testcase 1:

  1. Open any image with a lot of dark areas
  2. Press Ctrl+U to open HSV-filter
  3. Select "Hue/Saturation/Lightness" (default choice)
  4. Try to increase "Lightness", compare result to "HSV" mode, which uses the old approach
  5. Try to increase "Saturation", compare result to "HSV" mode, which uses the old approach

Testcase 2:

  1. Open any image with a lot of light areas
  2. Press Ctrl+U to open HSV-filter
  3. Select "Hue/Saturation/Lightness" (default choice)
  4. Try to decrease "Lightness"
  5. Try to decrease "Saturation"

Formalities Checklist

No formalities yet, because the patch is considered as a proof-of-concept.

Edited by Halla Rempt

Merge request reports