NEEDS TESTING: "fix" HSL transformation for white and black images
The patch tries to address this bug: https://bugs.kde.org/show_bug.cgi?id=411863
Basically, the transformation is substituted with HCL transformation, but with clever sliding on the edges of the rhombus. I need people's input, whether the transformation is still useful for painters.
Now it looks almost like "Hue/Saturation/Luma" (it also uses chroma instead of saturation), but with a different approach to calculation of 'L' channel :)
Test Plan
Testcase 1:
- Open any image with a lot of dark areas
- Press Ctrl+U to open HSV-filter
- Select "Hue/Saturation/Lightness" (default choice)
- Try to increase "Lightness", compare result to "HSV" mode, which uses the old approach
- Try to increase "Saturation", compare result to "HSV" mode, which uses the old approach
Testcase 2:
- Open any image with a lot of light areas
- Press Ctrl+U to open HSV-filter
- Select "Hue/Saturation/Lightness" (default choice)
- Try to decrease "Lightness"
- Try to decrease "Saturation"
Formalities Checklist
No formalities yet, because the patch is considered as a proof-of-concept.
Edited by Halla Rempt