Skip to content

456463 G'MIC: stack images when returning the list

Amy spark requested to merge lsegovia/krita:work/amyspark/456463-deevad into master

The use of recursiveApplyNodes, introduced in ca0d473b as part of the refactor that enabled the rest of the input modes, missed a significant subtlety of the layer enumeration: recursiveApplyNodes works top-down, while G'MIC expects layers to be sorted bottom-up.

BUG: 456463

Test Plan

Build Krita, no update to G'MIC is necessary. Stack two images. Run G'MIC, select Stylize filter, and check that the image on top is the style, and gets applied to the bottom. Check that the image is applied on return in the bottom layer.

@davidrevoy -- as the only docs I have on this are the GIMP host code, could you please throw all you have at this and check I've not introduced any other bugs? Especially as regards layer position on return from G'MIC.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports