Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Krita Krita
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Bugzilla
    • Bugzilla
  • Merge requests 71
    • Merge requests 71
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • GraphicsGraphics
  • KritaKrita
  • Merge requests
  • !1526

Android: Handle bug with modality of windows

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sharaf Zaman requested to merge szaman/krita:bug-456807-focus-issue-android into master Jul 20, 2022
  • Overview 3
  • Commits 2
  • Pipelines 4
  • Changes 4

The issue was that there was no provision of modality in Qt Android plugin. So we added that, the popups still get higher preference over modal windows if the event is in the area of popup's bounding rect.

The oversight in previous fix of the similar bug was that I had assumed that "focus" wouldn't shift to the object which we are color picking, it didn't happen for everything but did happen for canvas where the selected vector shape would be deselected.

@rempt: One question about the merging, because the merge request patches an error prone area. It will really need some testing, I've asked the user to test it. And they've emailed me that they will. Should we merge it for the release candidate once the user clears that everything is working or should we wait for next release?

BUG:456807

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bug-456807-focus-issue-android