Skip to content

Add custom opacity and blend mode options to fill tool and enclose and fill tool

Deif Lou requested to merge deiflou/krita:deiflou/add_custom_blending_options_to_fill_tool into master

The fill enclose and fill tools take the opacity and blend mode from the global brush options. This MR add the possibility of having those as custom options on the tools. Now one can check a checkbox to select if the custom options or the brush ones should be used. This allows to have those configured independently if desired.

I also added the use of the options to the "drag & drop color to fill" feature.

I had to add the composite op combobox, so I copied the code that deals with making some of the entries disabled from the KisPaintopBox.

screenshot

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Deif Lou

Merge request reports