Skip to content

Fix HSV filter sliders not being initialized

d0d2da30 added a safe assert which was meant to verify the type combobox's index as being >=0, but mistakenly expected it to be <0. This caused the slider initialization function to exit before recolorSliders() happened, so the sliders appeared black until the value changed.

Test Plan

  1. Open a document.
  2. Open the HSV Adjustment Filter dialog. The sliders should be properly colored instead of black.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports