Skip to content

Add saving QSplitter::sizes() and if brush presets are visible to KisConfig in Brush Presets Editor

Isaiah Deppong requested to merge deppong/krita:deppong/brush-editor-splitter-size-save into master

Addressed one of the issues in BUG:471366 If the presets and scratchpad are closed or open it is saved to KisConfig so upon reopening Krita they are visible or hidden as the user left them when closed. The size of the scratchpad and brush presets is also saved, even when hidden!

P.S. this is my first ever MR or PR to any open source project! please let me know if there is anything I can do to improve or do differently

Test Plan

I set the brush presets and scratchpad to hidden, closed and reopened Krita the state was restored upon opening Krita. I then changed the size of both and the size was also restored upon reopening. After altering the sizing I then hid both panels, and upon reopening Krita they were both hidden. Once revealed the size I altered them to prior to collapsing was restored.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports