Skip to content

Render preview when dragging to create text shapes

Alvin Wong requested to merge alvinwong/krita:alvin/text-shape-preview into master

Render a preview when dragging to create text. This is achieved by creating a text shape for the preview, repositioning and resizing (inline-size) as needed, and painting the text shape directly as part of the tool decoration. This has some odd effects:

  • The preview is rendered in the view resolution, making it a bit weird when the zoom level is high.
  • The preview is overlaid on top of the image, i.e. does not respect the layer stack.
  • The preview is rendered even outside the canvas region.

The preview shape is also directly reused to be added to the shape layer once the dragging operation is finalized.

The length of the preview text is dynamically adjust with the aim to demonstrate the wrapping behaviour with the least amount of text.

Demo:
preview_english preview_chinese

I also aim to make the preview text and placeholder text change depending on what the font supports, but that will be a later MR.

Test Plan

  • Test creating text shapes in the text tool.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports