Skip to content

487103: EXR - Add XYZ to top level channel on import

Rasyuqa A H requested to merge rasyuqaa/krita:rasyuqaa/exr-fix-xyz-colorspace into master

This MR is an attempt to fix BUG: 487103

XYZ to RGB conversion is already exist in code, but X and Z channels weren't registered on top level channel list, so it got skipped.

However, another known issue is that the layer thumbnail didn't work as intended. With the test file provided in the bug report, only green text (channel) that's visible on the layer thumbnail, albeit the correct image is shown on the canvas. Maybe that's a separate issue?

Test Plan

  • Try importing EXR with XYZ channels and confirm if it's imported correctly

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Rasyuqa A H

Merge request reports