Skip to content

Port Windows packaging scripts to Python

Freya Lupen requested to merge freyalupen/krita:freyalupen/port-windows-scripts into master

An attempt at this task: https://phabricator.kde.org/T17517

'package-complete' is based on 'package-complete-msvc.py'. 'build_msix', 'sign-package', 'sign-windows-package-at-notary-service' were also ported from batch.

These scripts have not been tested been tested except for signing and need review to check if they will work correctly. They haven't been connected to anything yet and the old .cmd scripts haven't been removed.

Test Plan

(TODO) Run build-windows-package.py as usual

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Freya Lupen

Merge request reports