Skip to content

Specific Color Selector fixes

Freya Lupen requested to merge freyalupen/krita:freyalupen/specific-colsel-fixes into master

A few Specific Color Selector fixes:

  • Update the slider labels when switching between HSV/HSL/HSI/HSY. BUG:475551
  • Fix RGB sliders changing length when updated. BUG:453649
  • Change the step of the float spinboxes to .01 as they show a range of 0.00-.1.00.
  • Fix holding down spinbox arrows in RGB mode. CCBUG:453366

Also some code cleanup/simplification.

Test Plan

Open the Specific Color Selector docker.

  • In HSV mode: Switch between HSV/HSL/HSI/HSY, check the labels match.
  • In RGB mode: Change the values, notice the sliders/comboboxes don't change length.
  • In RGB mode: Switch to a float colorspace, using the spinbox arrows should be useful instead of going to 0 or 1.
  • In RGB mode: Holding down the spinbox arrows should continue changing the value instead of stopping.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports