Skip to content

Fix KoZoomTool cursor behavior, wrong cursor used when CTRL + any other key

Jean-Loup Mellion requested to merge jl/krita:jl/fix-kozoomtool-cursor-behavior into master

Fixed an issue where the KoZoomTool displayed incorrect cursor when CTRL was pressed in combination with any other key. Updated KoZoomTool.cpp and KoZoomTool.h to add m_otherKeyPressed flag and modified key event handling and updateCursor method to ensure correct zoom cursor display for all key combinations.

Test Plan

Open Krita and activate the Zoom tool. Test the following key combinations and verify correct cursor behavior:

Press and release CTRL only Press CTRL, then press any other key Press any other key, then press CTRL Press and release non-CTRL keys

Perform zoom operations with mouse clicks while testing these key combinations.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports