Skip to content

Fix issue in 'Render Animation' dialog

Mathias Wein requested to merge mwein/krita:render_animation_fix into master

I found an issue with the 'Render Animation' dialog thanks to a discussion on KA: https://krita-artists.org/t/erased-pixels-creating-ghost-images-in-export-of-16-bit-exr-files/104325

The dropdown to choose the file format for image sequence gets stuck in disabled state once rendering as video gets enabled, but disabling video should allow choosign other file formats than PNG again.

While at it, I changed the code that prevents disabling both export types. It is now symmetrical, i.e. always keeps the current option enabled, before it would enable image sequence unconditionally.

Test Plan

  • Open 'File' -> 'Render Animation...' on any animated document
  • With "Export as image sequence" enabled, toggle "Export as video" on and off. The File format dropdown should only be disabled while "Export as video" is on, and be available again once "Export as video" is off again.
  • Also make sure you can't disable "Export as image sequence" or "Export as video" when the other one already disabled.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Mathias Wein

Merge request reports