Skip to content

Add Fast Color Overlay for sketch inking

Maciej Jesionowski requested to merge yavn/krita:layer-display-color-lite into master

This is my second attempt at implementing this feature. This is the previous !2216 (closed).

I have decided to abandon the first implementation idea, as I really didn't like how complex and "hacky" it felt. Although I managed to debug fake nodes somewhat, I'm afraid we would have run into more bugs in the future (e.g. with Python scripting, order of masks).

This is a much simpler implementation, basically it just this:

  • adds Dmitry's original filter from 2020
  • adds a new action to quickly add the filter mask
  • adds a menu entry for adding the filter mask
  • adds a tiny visual enhancement in the layers docker, so that the mask's selected color is visible to the user.

I will ask for artists' feedback on the forums, but I hope this is a reasonable compromise, or perhaps a stepping stone to a better UI.
KA thread: https://krita-artists.org/t/layer-sketch-to-blue-for-inking-over-it/11246

Test Plan

  • Try adding the Fast Color Overlay filter mask to various layers, like paint and group layers.
  • Try using the action, shortcut, menu items, etc.
  • Try moving the mask to other layers, etc.
  • I checked the Right-to-Left layout to be sure the icon draws properly.

Formalities Checklist

  • I confirmed this builds (on Windows).
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
    ➡️ Original cherry picks from 2020 probably won't build, but I kept them as is for history. If needed, I can squash them with proper Author attribution.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?
    ➡️ There is no documentation MR

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Maciej Jesionowski

Merge request reports