Skip to content

Draft: Pen tilt direction angle offsets

Maciej Jesionowski requested to merge yavn/krita:tilt-direction-offset into master

This MR implements two similar feature request:

  • A global tilt direction offset -- can be helpful to make the brushes feel the same for right- and left-handed users.
  • A tilt direction angle offset in the brush editor for tilt-aware devices -- this one makes it easier to create brush presets and packs that work with tilt and no-tilt supported devices.

Here are the original requests:

Test Plan

There are two new spin boxes to test. Tilt and no-tilt support can be validated with a tilt-aware pen tablet and a mouse. Maybe best if you check out my posts here, as these describe in detail how this behaves:

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. I checked one test that seemed relevant, didn't see a place to cover this, but correct me if a new test should be added.
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository? Yes, this patch adds new UI elements and will require localization.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Maciej Jesionowski

Merge request reports