Skip to content

Add Normal and Tint as the suggested blend modes for Fast Color Overlay Filter

Maciej Jesionowski requested to merge yavn/krita:color-overlay-widget-update into master

This patch revamps the Fast Color Overlay Filter configuration widget to include the suggested and best performing blend modes:

image

The original full list of filters is available under "Custom":

image

I collected quick feedback from KA and there were no complaints. 🙂

Test Plan

  1. Paint something on the layer. Use opaque, non-black strokes to test the Tint mode.
  2. Add "Color Overlay Mask" to the layer
  3. Expand the layer, select the mask, and view its properties.

Tint blend mode

To observe this one, you need to use light, opaque strokes, e.g. light gray color stroke with Basic-1. Normal blend mode will be fully blue, while Tint mode will preserve shades of blue.

Formalities Checklist

  • I confirmed this builds on Windows.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository? No documentation PR, new strings added

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports